From niels_dekker_address_until_2024 at xs4all.nl Mon Apr 2 07:12:53 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Mon, 02 Apr 2018 13:12:53 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> Message-ID: <0c0a7961db09938f9574223db566d0e1@xs4all.nl> Update: it appears to me that these GitHub pull request links at CDash index.php are broken, because CDash strips "https://" from the GitHub URLs. Is this a known issue? Do you have a workaround? More details: CDash produces the following HTML code, for a pull request at http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Web browsers assume that the GitHub URL at href="..." is a relative path, because it does not start with "http[s]://". So there is where the link gets broken. I observed the "https://" being stripped as follows: - I went to http://trunk.cdash.org/index.php?project=SuperElastix - Logged in - Opened "Edit Project" page (createProject.php), from the Settings menu. - Went to Repository tab page. - Entered "https://github.com/SuperElastix/SuperElastix" at "Repository Viewer URL:" - Clicked the "Update Project" button, and then, "https://" was gone! I guess this stripping is done by stripHTTP($url), at: https://github.com/Kitware/CDash/blob/d46d9e06dc83d577aacecfa4b95a3613bcbca1a6/public/api/v1/project.php#L214 The GitHub URL that is stripped is internally referred to as 'cdash.project.CvsUrl' Hope you can help me to get it fixed! (A workaround would be nice as well.) Kind regards, Niels -------- Original Message -------- Date: 2018-03-30 20:25 I just experienced this really cool feature that when CTEST_CHANGE_ID is set for a specific build, a little GitHub icon appears at the index.php, in the table entry of the Build Name, for that particular build. For the SuperElastix project that I am involved with, at: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 I guess the GitHub icon should link to the GitHub pull request, https://github.com///pull/, and that would be wonderful. Unfortunately the GitHub links are broken, at the cdash.org/index.php page of our project, as they points to: http://trunk.cdash.org/github.com/SuperElastix/SuperElastix/pull/183 Which says: "The requested URL /github.com/SuperElastix/SuperElastix/pull/183 was not found on this server" I saw the same problem here: https://open.cdash.org/index.php?project=Fletch&date=2018-03-30 Which has GitHub icons linking to: https://open.cdash.org/github.com/kitware/fletch/pull/354 Do we do something wrong in our CDash project settings, or is it a bug? Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From sean at rogue-research.com Wed Apr 4 15:29:48 2018 From: sean at rogue-research.com (Sean McBride) Date: Wed, 4 Apr 2018 15:29:48 -0400 Subject: [CDash] macOS 10.13.4 confused cdash "OS Version" string Message-ID: <20180404192948.1504240828@mail.rogue-research.com> Hi cdash devs, I recently updated my Rogue15 bot from macOS 10.13.3 to 10.13.4. Before: OS Version: 17D102 After: OS Version: 1.7e+200 It should read "17E199". I guess something thinks it's floating point... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From zack.galbreath at kitware.com Fri Apr 6 10:09:03 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Fri, 6 Apr 2018 10:09:03 -0400 Subject: [CDash] macOS 10.13.4 confused cdash "OS Version" string In-Reply-To: <20180404192948.1504240828@mail.rogue-research.com> References: <20180404192948.1504240828@mail.rogue-research.com> Message-ID: On Wed, Apr 4, 2018 at 3:29 PM, Sean McBride wrote: > Hi cdash devs, > > I recently updated my Rogue15 bot from macOS 10.13.3 to 10.13.4. > > Before: > > OS Version: 17D102 > > After: > > OS Version: 1.7e+200 > > > It should read "17E199". I guess something thinks it's floating point... > Right you are, thanks for pointing this out. We previously noticed CDash interpreting some strings as numbers due to e-notation. We added a check to prevent this, but it was only looking for the presence of 'e', not 'E'. I'll modify this to be a case insensitive check instead. -------------- next part -------------- An HTML attachment was scrubbed... URL: From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 05:11:12 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 11:11:12 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <0c0a7961db09938f9574223db566d0e1@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> Message-ID: <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Update #2: As a workaround, I entered the "Repository Viewer URL" (CDash Settings, Project, Repository) with uppercase "HTTPS": HTTPS://github.com/SuperElastix/SuperElastix It appears that CDash does not strip off uppercase "HTTPS://" (while it does strip off lowercase "https://")! So now the little Octocat.png icons at our dashboard properly link to the corresponding GitHub pull requests: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Please let us know if this workaround is OK, or if it has some drawbacks. -- Niels -------- Original Message -------- Subject: Re: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php Date: 2018-04-02 13:12 Update: it appears to me that these GitHub pull request links at CDash index.php are broken, because CDash strips "https://" from the GitHub URLs. Is this a known issue? Do you have a workaround? More details: CDash produces the following HTML code, for a pull request at http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Web browsers assume that the GitHub URL at href="..." is a relative path, because it does not start with "http[s]://". So there is where the link gets broken. I observed the "https://" being stripped as follows: - I went to http://trunk.cdash.org/index.php?project=SuperElastix - Logged in - Opened "Edit Project" page (createProject.php), from the Settings menu. - Went to Repository tab page. - Entered "https://github.com/SuperElastix/SuperElastix" at "Repository Viewer URL:" - Clicked the "Update Project" button, and then, "https://" was gone! I guess this stripping is done by stripHTTP($url), at: https://github.com/Kitware/CDash/blob/d46d9e06dc83d577aacecfa4b95a3613bcbca1a6/public/api/v1/project.php#L214 The GitHub URL that is stripped is internally referred to as 'cdash.project.CvsUrl' Hope you can help me to get it fixed! (A workaround would be nice as well.) Kind regards, Niels -------- Original Message -------- Date: 2018-03-30 20:25 I just experienced this really cool feature that when CTEST_CHANGE_ID is set for a specific build, a little GitHub icon appears at the index.php, in the table entry of the Build Name, for that particular build. For the SuperElastix project that I am involved with, at: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 I guess the GitHub icon should link to the GitHub pull request, https://github.com///pull/, and that would be wonderful. Unfortunately the GitHub links are broken, at the cdash.org/index.php page of our project, as they points to: http://trunk.cdash.org/github.com/SuperElastix/SuperElastix/pull/183 Which says: "The requested URL /github.com/SuperElastix/SuperElastix/pull/183 was not found on this server" I saw the same problem here: https://open.cdash.org/index.php?project=Fletch&date=2018-03-30 Which has GitHub icons linking to: https://open.cdash.org/github.com/kitware/fletch/pull/354 Do we do something wrong in our CDash project settings, or is it a bug? Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From zack.galbreath at kitware.com Sat Apr 7 08:00:15 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Sat, 7 Apr 2018 08:00:15 -0400 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <9eeb81ac400328a9388e932c1897dede@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker < niels_dekker_address_until_2024 at xs4all.nl> wrote: > Update #2: As a workaround, I entered the "Repository Viewer URL" (CDash > Settings, Project, Repository) with uppercase "HTTPS": > > HTTPS://github.com/SuperElastix/SuperElastix > > It appears that CDash does not strip off uppercase "HTTPS://" (while it > does strip off lowercase "https://")! So now the little Octocat.png icons > at our dashboard properly link to the corresponding GitHub pull requests: > > http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 > > Please let us know if this workaround is OK, or if it has some drawbacks. That sounds like a reasonable workaround. Thanks for digging into this issue and figuring out what's causing it. I think the right fix (as you indicated) is to remove the stripHTTP function and its uses altogether. But I want to do some manual testing first to make sure this won't cause problems with any of our other external links. -------------- next part -------------- An HTML attachment was scrubbed... URL: From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 16:26:41 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 22:26:41 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: Zack Galbreath wrote on Sat, Apr 7 2018 14:00: > On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker wrote: > >> Update #2: As a workaround, I entered the "Repository Viewer URL" >> (CDash Settings, Project, Repository) with uppercase "HTTPS": > > That sounds like a reasonable workaround. Thanks for digging into > this issue and figuring out what's causing it. I think the right fix > (as you indicated) is to remove the stripHTTP function and its uses > altogether. But I want to do some manual testing first to make sure > this won't cause problems with any of our other external links. You're welcome, Zack :-) I guess there must have been a reason to do stripHTTP, that I just don't know... So far, I only saw one side effect of entering uppercase "HTTPS" in the "Repository Viewer URL" field. When I entered the URL, a text appeared next to "Test URL:", saying: "http://HTTPS://github.com/SuperElastix/SuperElastix/blob/REVISION/DIRECTORYNAME/FILENAME" That doesn't look good: "http://HTTPS://github.com/...". But does it do any harm, if it's just the "Test URL"? By the way, on the first Settings tab page ("Information"), the "Home URL" is also stripped. I don't know whether this is either buggy or useful. Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 16:48:15 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 22:48:15 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: <840dc4ab186eb3ce11c13ece432ed1a0@xs4all.nl> Update: I just found a little drawback of the workaround that I presented (entering uppercase "HTTPS" in the "Repository Viewer URL" field). It breaks the link of the "Repository" menu item, in the Project menu, at http://trunk.cdash.org/?project=SuperElastix After my workaround, the "Repository" menu item links to: http://https//github.com/SuperElastix/SuperElastix That's clearly wrong. But I feel it's more important to have correct links to pull requests. -- Niels -------- Original Message -------- Date: 2018-04-07 22:26 From: Niels Dekker Zack Galbreath wrote on Sat, Apr 7 2018 14:00: > On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker wrote: > >> Update #2: As a workaround, I entered the "Repository Viewer URL" >> (CDash Settings, Project, Repository) with uppercase "HTTPS": > > That sounds like a reasonable workaround. Thanks for digging into > this issue and figuring out what's causing it. I think the right fix > (as you indicated) is to remove the stripHTTP function and its uses > altogether. But I want to do some manual testing first to make sure > this won't cause problems with any of our other external links. You're welcome, Zack :-) I guess there must have been a reason to do stripHTTP, that I just don't know... So far, I only saw one side effect of entering uppercase "HTTPS" in the "Repository Viewer URL" field. When I entered the URL, a text appeared next to "Test URL:", saying: "http://HTTPS://github.com/SuperElastix/SuperElastix/blob/REVISION/DIRECTORYNAME/FILENAME" That doesn't look good: "http://HTTPS://github.com/...". But does it do any harm, if it's just the "Test URL"? By the way, on the first Settings tab page ("Information"), the "Home URL" is also stripped. I don't know whether this is either buggy or useful. Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From niels_dekker_address_until_2024 at xs4all.nl Tue Apr 10 11:39:37 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Tue, 10 Apr 2018 17:39:37 +0200 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? Message-ID: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> It would be very convenient if each Update page of a project would show the corresponding revision tag (Git SHA) of the project, possibly with a link to the specific revision (e.g., at GitHub). It seems like this functionality was built into CDash, but it just does not work! Colleagues of mine at LKEB (www.lkeb.nl) helped me to find some possible bugs in the CDash AngularJS code, that seem to cause this issue. Regarding the SuperElastix project that I am involved with (https://github.com/SuperElastix), I would have liked to see the Git SHA of SuperElastix at http://trunk.cdash.org/viewUpdate.php?buildid=1238277 The HTML source of that page says:
Revision: {{::cdash.update.revision}} Could it be that "cdash.updates.revision" was misspelled? Shouldn't it be "cdash.update.revision" (without the 's')? Moreover, it seems that some extra "{{" and "}}" might be needed, for AngularJS markups inside an ng-href="...". Specifically, it seems that "::cdash.update.revisionurl" should be "{{::cdash.update.revisionurl}}". What do you think? Related file (I guess): https://github.com/Kitware/CDash/blob/4f328cd838d0486901f58c2844fd11415b4abb52/public/views/viewUpdate.html HTH, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From zack.galbreath at kitware.com Thu Apr 12 14:41:10 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Thu, 12 Apr 2018 14:41:10 -0400 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? In-Reply-To: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> References: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> Message-ID: You're right, this looks like a bug on viewUpdate.php. Here's the fix: https://github.com/Kitware/CDash/pull/668 I'll reply here again when trunk.cdash.org gets updated. On Tue, Apr 10, 2018 at 11:39 AM, Niels Dekker < niels_dekker_address_until_2024 at xs4all.nl> wrote: > It would be very convenient if each Update page of a project would show > the corresponding revision tag (Git SHA) of the project, possibly with a > link to the specific revision (e.g., at GitHub). It seems like this > functionality was built into CDash, but it just does not work! Colleagues > of mine at LKEB (www.lkeb.nl) helped me to find some possible bugs in the > CDash AngularJS code, that seem to cause this issue. > > Regarding the SuperElastix project that I am involved with ( > https://github.com/SuperElastix), I would have liked to see the Git SHA > of SuperElastix at http://trunk.cdash.org/viewUpdate.php?buildid=1238277 > The HTML source of that page says: > >
> Revision: > {{::cdash.update.revision}} >
>
> Prior Revision: > {{::cdash.update. > priorrevision}} >
>
>
> > Could it be that "cdash.updates.revision" was misspelled? Shouldn't it be > "cdash.update.revision" (without the 's')? > > Moreover, it seems that some extra "{{" and "}}" might be needed, for > AngularJS markups inside an ng-href="...". Specifically, it seems that > "::cdash.update.revisionurl" should be "{{::cdash.update.revisionurl}}". > What do you think? > > > Related file (I guess): > https://github.com/Kitware/CDash/blob/4f328cd838d0486901f58c > 2844fd11415b4abb52/public/views/viewUpdate.html > > HTH, Niels > > -- > Niels Dekker > Scientific programmer > LKEB, Leiden University Medical Center > _______________________________________________ > CDash mailing list > CDash at public.kitware.com > https://public.kitware.com/mailman/listinfo/cdash > -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Sat Apr 14 07:46:18 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Sat, 14 Apr 2018 07:46:18 -0400 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? In-Reply-To: References: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> Message-ID: On Thu, Apr 12, 2018 at 2:41 PM, Zack Galbreath wrote: > I'll reply here again when trunk.cdash.org gets updated. > trunk.cdash.org has been updated with this fix. Thanks again for noticing this bug and bringing it to our attention. -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Mon Apr 23 19:05:16 2018 From: sean at rogue-research.com (Sean McBride) Date: Mon, 23 Apr 2018 19:05:16 -0400 Subject: [CDash] Link to source code from errors pages are broken Message-ID: <20180423230516.1755464250@mail.rogue-research.com> Hi, Here for example: there is a hyperlink to: It's 404 though. Someone might want to fix that. :) Does the feature work? In my own/private instance of cdash, I'd like to have that link work. Where does one configure the base URL? Thanks, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From niels_dekker_address_until_2024 at xs4all.nl Mon Apr 2 11:12:53 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Mon, 02 Apr 2018 13:12:53 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> Message-ID: <0c0a7961db09938f9574223db566d0e1@xs4all.nl> Update: it appears to me that these GitHub pull request links at CDash index.php are broken, because CDash strips "https://" from the GitHub URLs. Is this a known issue? Do you have a workaround? More details: CDash produces the following HTML code, for a pull request at http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Web browsers assume that the GitHub URL at href="..." is a relative path, because it does not start with "http[s]://". So there is where the link gets broken. I observed the "https://" being stripped as follows: - I went to http://trunk.cdash.org/index.php?project=SuperElastix - Logged in - Opened "Edit Project" page (createProject.php), from the Settings menu. - Went to Repository tab page. - Entered "https://github.com/SuperElastix/SuperElastix" at "Repository Viewer URL:" - Clicked the "Update Project" button, and then, "https://" was gone! I guess this stripping is done by stripHTTP($url), at: https://github.com/Kitware/CDash/blob/d46d9e06dc83d577aacecfa4b95a3613bcbca1a6/public/api/v1/project.php#L214 The GitHub URL that is stripped is internally referred to as 'cdash.project.CvsUrl' Hope you can help me to get it fixed! (A workaround would be nice as well.) Kind regards, Niels -------- Original Message -------- Date: 2018-03-30 20:25 I just experienced this really cool feature that when CTEST_CHANGE_ID is set for a specific build, a little GitHub icon appears at the index.php, in the table entry of the Build Name, for that particular build. For the SuperElastix project that I am involved with, at: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 I guess the GitHub icon should link to the GitHub pull request, https://github.com///pull/, and that would be wonderful. Unfortunately the GitHub links are broken, at the cdash.org/index.php page of our project, as they points to: http://trunk.cdash.org/github.com/SuperElastix/SuperElastix/pull/183 Which says: "The requested URL /github.com/SuperElastix/SuperElastix/pull/183 was not found on this server" I saw the same problem here: https://open.cdash.org/index.php?project=Fletch&date=2018-03-30 Which has GitHub icons linking to: https://open.cdash.org/github.com/kitware/fletch/pull/354 Do we do something wrong in our CDash project settings, or is it a bug? Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From sean at rogue-research.com Wed Apr 4 19:29:48 2018 From: sean at rogue-research.com (Sean McBride) Date: Wed, 4 Apr 2018 15:29:48 -0400 Subject: [CDash] macOS 10.13.4 confused cdash "OS Version" string Message-ID: <20180404192948.1504240828@mail.rogue-research.com> Hi cdash devs, I recently updated my Rogue15 bot from macOS 10.13.3 to 10.13.4. Before: OS Version: 17D102 After: OS Version: 1.7e+200 It should read "17E199". I guess something thinks it's floating point... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From zack.galbreath at kitware.com Fri Apr 6 14:09:03 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Fri, 6 Apr 2018 10:09:03 -0400 Subject: [CDash] macOS 10.13.4 confused cdash "OS Version" string In-Reply-To: <20180404192948.1504240828@mail.rogue-research.com> References: <20180404192948.1504240828@mail.rogue-research.com> Message-ID: On Wed, Apr 4, 2018 at 3:29 PM, Sean McBride wrote: > Hi cdash devs, > > I recently updated my Rogue15 bot from macOS 10.13.3 to 10.13.4. > > Before: > > OS Version: 17D102 > > After: > > OS Version: 1.7e+200 > > > It should read "17E199". I guess something thinks it's floating point... > Right you are, thanks for pointing this out. We previously noticed CDash interpreting some strings as numbers due to e-notation. We added a check to prevent this, but it was only looking for the presence of 'e', not 'E'. I'll modify this to be a case insensitive check instead. -------------- next part -------------- An HTML attachment was scrubbed... URL: From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 09:11:12 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 11:11:12 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <0c0a7961db09938f9574223db566d0e1@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> Message-ID: <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Update #2: As a workaround, I entered the "Repository Viewer URL" (CDash Settings, Project, Repository) with uppercase "HTTPS": HTTPS://github.com/SuperElastix/SuperElastix It appears that CDash does not strip off uppercase "HTTPS://" (while it does strip off lowercase "https://")! So now the little Octocat.png icons at our dashboard properly link to the corresponding GitHub pull requests: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Please let us know if this workaround is OK, or if it has some drawbacks. -- Niels -------- Original Message -------- Subject: Re: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php Date: 2018-04-02 13:12 Update: it appears to me that these GitHub pull request links at CDash index.php are broken, because CDash strips "https://" from the GitHub URLs. Is this a known issue? Do you have a workaround? More details: CDash produces the following HTML code, for a pull request at http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Web browsers assume that the GitHub URL at href="..." is a relative path, because it does not start with "http[s]://". So there is where the link gets broken. I observed the "https://" being stripped as follows: - I went to http://trunk.cdash.org/index.php?project=SuperElastix - Logged in - Opened "Edit Project" page (createProject.php), from the Settings menu. - Went to Repository tab page. - Entered "https://github.com/SuperElastix/SuperElastix" at "Repository Viewer URL:" - Clicked the "Update Project" button, and then, "https://" was gone! I guess this stripping is done by stripHTTP($url), at: https://github.com/Kitware/CDash/blob/d46d9e06dc83d577aacecfa4b95a3613bcbca1a6/public/api/v1/project.php#L214 The GitHub URL that is stripped is internally referred to as 'cdash.project.CvsUrl' Hope you can help me to get it fixed! (A workaround would be nice as well.) Kind regards, Niels -------- Original Message -------- Date: 2018-03-30 20:25 I just experienced this really cool feature that when CTEST_CHANGE_ID is set for a specific build, a little GitHub icon appears at the index.php, in the table entry of the Build Name, for that particular build. For the SuperElastix project that I am involved with, at: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 I guess the GitHub icon should link to the GitHub pull request, https://github.com///pull/, and that would be wonderful. Unfortunately the GitHub links are broken, at the cdash.org/index.php page of our project, as they points to: http://trunk.cdash.org/github.com/SuperElastix/SuperElastix/pull/183 Which says: "The requested URL /github.com/SuperElastix/SuperElastix/pull/183 was not found on this server" I saw the same problem here: https://open.cdash.org/index.php?project=Fletch&date=2018-03-30 Which has GitHub icons linking to: https://open.cdash.org/github.com/kitware/fletch/pull/354 Do we do something wrong in our CDash project settings, or is it a bug? Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From zack.galbreath at kitware.com Sat Apr 7 12:00:15 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Sat, 7 Apr 2018 08:00:15 -0400 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <9eeb81ac400328a9388e932c1897dede@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker < niels_dekker_address_until_2024 at xs4all.nl> wrote: > Update #2: As a workaround, I entered the "Repository Viewer URL" (CDash > Settings, Project, Repository) with uppercase "HTTPS": > > HTTPS://github.com/SuperElastix/SuperElastix > > It appears that CDash does not strip off uppercase "HTTPS://" (while it > does strip off lowercase "https://")! So now the little Octocat.png icons > at our dashboard properly link to the corresponding GitHub pull requests: > > http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 > > Please let us know if this workaround is OK, or if it has some drawbacks. That sounds like a reasonable workaround. Thanks for digging into this issue and figuring out what's causing it. I think the right fix (as you indicated) is to remove the stripHTTP function and its uses altogether. But I want to do some manual testing first to make sure this won't cause problems with any of our other external links. -------------- next part -------------- An HTML attachment was scrubbed... URL: From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 20:26:41 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 22:26:41 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: Zack Galbreath wrote on Sat, Apr 7 2018 14:00: > On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker wrote: > >> Update #2: As a workaround, I entered the "Repository Viewer URL" >> (CDash Settings, Project, Repository) with uppercase "HTTPS": > > That sounds like a reasonable workaround. Thanks for digging into > this issue and figuring out what's causing it. I think the right fix > (as you indicated) is to remove the stripHTTP function and its uses > altogether. But I want to do some manual testing first to make sure > this won't cause problems with any of our other external links. You're welcome, Zack :-) I guess there must have been a reason to do stripHTTP, that I just don't know... So far, I only saw one side effect of entering uppercase "HTTPS" in the "Repository Viewer URL" field. When I entered the URL, a text appeared next to "Test URL:", saying: "http://HTTPS://github.com/SuperElastix/SuperElastix/blob/REVISION/DIRECTORYNAME/FILENAME" That doesn't look good: "http://HTTPS://github.com/...". But does it do any harm, if it's just the "Test URL"? By the way, on the first Settings tab page ("Information"), the "Home URL" is also stripped. I don't know whether this is either buggy or useful. Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 20:48:15 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 22:48:15 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: <840dc4ab186eb3ce11c13ece432ed1a0@xs4all.nl> Update: I just found a little drawback of the workaround that I presented (entering uppercase "HTTPS" in the "Repository Viewer URL" field). It breaks the link of the "Repository" menu item, in the Project menu, at http://trunk.cdash.org/?project=SuperElastix After my workaround, the "Repository" menu item links to: http://https//github.com/SuperElastix/SuperElastix That's clearly wrong. But I feel it's more important to have correct links to pull requests. -- Niels -------- Original Message -------- Date: 2018-04-07 22:26 From: Niels Dekker Zack Galbreath wrote on Sat, Apr 7 2018 14:00: > On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker wrote: > >> Update #2: As a workaround, I entered the "Repository Viewer URL" >> (CDash Settings, Project, Repository) with uppercase "HTTPS": > > That sounds like a reasonable workaround. Thanks for digging into > this issue and figuring out what's causing it. I think the right fix > (as you indicated) is to remove the stripHTTP function and its uses > altogether. But I want to do some manual testing first to make sure > this won't cause problems with any of our other external links. You're welcome, Zack :-) I guess there must have been a reason to do stripHTTP, that I just don't know... So far, I only saw one side effect of entering uppercase "HTTPS" in the "Repository Viewer URL" field. When I entered the URL, a text appeared next to "Test URL:", saying: "http://HTTPS://github.com/SuperElastix/SuperElastix/blob/REVISION/DIRECTORYNAME/FILENAME" That doesn't look good: "http://HTTPS://github.com/...". But does it do any harm, if it's just the "Test URL"? By the way, on the first Settings tab page ("Information"), the "Home URL" is also stripped. I don't know whether this is either buggy or useful. Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From niels_dekker_address_until_2024 at xs4all.nl Tue Apr 10 15:39:37 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Tue, 10 Apr 2018 17:39:37 +0200 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? Message-ID: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> It would be very convenient if each Update page of a project would show the corresponding revision tag (Git SHA) of the project, possibly with a link to the specific revision (e.g., at GitHub). It seems like this functionality was built into CDash, but it just does not work! Colleagues of mine at LKEB (www.lkeb.nl) helped me to find some possible bugs in the CDash AngularJS code, that seem to cause this issue. Regarding the SuperElastix project that I am involved with (https://github.com/SuperElastix), I would have liked to see the Git SHA of SuperElastix at http://trunk.cdash.org/viewUpdate.php?buildid=1238277 The HTML source of that page says:
Revision: {{::cdash.update.revision}} Could it be that "cdash.updates.revision" was misspelled? Shouldn't it be "cdash.update.revision" (without the 's')? Moreover, it seems that some extra "{{" and "}}" might be needed, for AngularJS markups inside an ng-href="...". Specifically, it seems that "::cdash.update.revisionurl" should be "{{::cdash.update.revisionurl}}". What do you think? Related file (I guess): https://github.com/Kitware/CDash/blob/4f328cd838d0486901f58c2844fd11415b4abb52/public/views/viewUpdate.html HTH, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From zack.galbreath at kitware.com Thu Apr 12 18:41:10 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Thu, 12 Apr 2018 14:41:10 -0400 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? In-Reply-To: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> References: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> Message-ID: You're right, this looks like a bug on viewUpdate.php. Here's the fix: https://github.com/Kitware/CDash/pull/668 I'll reply here again when trunk.cdash.org gets updated. On Tue, Apr 10, 2018 at 11:39 AM, Niels Dekker < niels_dekker_address_until_2024 at xs4all.nl> wrote: > It would be very convenient if each Update page of a project would show > the corresponding revision tag (Git SHA) of the project, possibly with a > link to the specific revision (e.g., at GitHub). It seems like this > functionality was built into CDash, but it just does not work! Colleagues > of mine at LKEB (www.lkeb.nl) helped me to find some possible bugs in the > CDash AngularJS code, that seem to cause this issue. > > Regarding the SuperElastix project that I am involved with ( > https://github.com/SuperElastix), I would have liked to see the Git SHA > of SuperElastix at http://trunk.cdash.org/viewUpdate.php?buildid=1238277 > The HTML source of that page says: > >
> Revision: > {{::cdash.update.revision}} >
>
> Prior Revision: > {{::cdash.update. > priorrevision}} >
>
>
> > Could it be that "cdash.updates.revision" was misspelled? Shouldn't it be > "cdash.update.revision" (without the 's')? > > Moreover, it seems that some extra "{{" and "}}" might be needed, for > AngularJS markups inside an ng-href="...". Specifically, it seems that > "::cdash.update.revisionurl" should be "{{::cdash.update.revisionurl}}". > What do you think? > > > Related file (I guess): > https://github.com/Kitware/CDash/blob/4f328cd838d0486901f58c > 2844fd11415b4abb52/public/views/viewUpdate.html > > HTH, Niels > > -- > Niels Dekker > Scientific programmer > LKEB, Leiden University Medical Center > _______________________________________________ > CDash mailing list > CDash at public.kitware.com > https://public.kitware.com/mailman/listinfo/cdash > -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Sat Apr 14 11:46:18 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Sat, 14 Apr 2018 07:46:18 -0400 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? In-Reply-To: References: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> Message-ID: On Thu, Apr 12, 2018 at 2:41 PM, Zack Galbreath wrote: > I'll reply here again when trunk.cdash.org gets updated. > trunk.cdash.org has been updated with this fix. Thanks again for noticing this bug and bringing it to our attention. -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Mon Apr 23 23:05:16 2018 From: sean at rogue-research.com (Sean McBride) Date: Mon, 23 Apr 2018 19:05:16 -0400 Subject: [CDash] Link to source code from errors pages are broken Message-ID: <20180423230516.1755464250@mail.rogue-research.com> Hi, Here for example: there is a hyperlink to: It's 404 though. Someone might want to fix that. :) Does the feature work? In my own/private instance of cdash, I'd like to have that link work. Where does one configure the base URL? Thanks, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From niels_dekker_address_until_2024 at xs4all.nl Mon Apr 2 11:12:53 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Mon, 02 Apr 2018 13:12:53 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> Message-ID: <0c0a7961db09938f9574223db566d0e1@xs4all.nl> Update: it appears to me that these GitHub pull request links at CDash index.php are broken, because CDash strips "https://" from the GitHub URLs. Is this a known issue? Do you have a workaround? More details: CDash produces the following HTML code, for a pull request at http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Web browsers assume that the GitHub URL at href="..." is a relative path, because it does not start with "http[s]://". So there is where the link gets broken. I observed the "https://" being stripped as follows: - I went to http://trunk.cdash.org/index.php?project=SuperElastix - Logged in - Opened "Edit Project" page (createProject.php), from the Settings menu. - Went to Repository tab page. - Entered "https://github.com/SuperElastix/SuperElastix" at "Repository Viewer URL:" - Clicked the "Update Project" button, and then, "https://" was gone! I guess this stripping is done by stripHTTP($url), at: https://github.com/Kitware/CDash/blob/d46d9e06dc83d577aacecfa4b95a3613bcbca1a6/public/api/v1/project.php#L214 The GitHub URL that is stripped is internally referred to as 'cdash.project.CvsUrl' Hope you can help me to get it fixed! (A workaround would be nice as well.) Kind regards, Niels -------- Original Message -------- Date: 2018-03-30 20:25 I just experienced this really cool feature that when CTEST_CHANGE_ID is set for a specific build, a little GitHub icon appears at the index.php, in the table entry of the Build Name, for that particular build. For the SuperElastix project that I am involved with, at: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 I guess the GitHub icon should link to the GitHub pull request, https://github.com///pull/, and that would be wonderful. Unfortunately the GitHub links are broken, at the cdash.org/index.php page of our project, as they points to: http://trunk.cdash.org/github.com/SuperElastix/SuperElastix/pull/183 Which says: "The requested URL /github.com/SuperElastix/SuperElastix/pull/183 was not found on this server" I saw the same problem here: https://open.cdash.org/index.php?project=Fletch&date=2018-03-30 Which has GitHub icons linking to: https://open.cdash.org/github.com/kitware/fletch/pull/354 Do we do something wrong in our CDash project settings, or is it a bug? Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From sean at rogue-research.com Wed Apr 4 19:29:48 2018 From: sean at rogue-research.com (Sean McBride) Date: Wed, 4 Apr 2018 15:29:48 -0400 Subject: [CDash] macOS 10.13.4 confused cdash "OS Version" string Message-ID: <20180404192948.1504240828@mail.rogue-research.com> Hi cdash devs, I recently updated my Rogue15 bot from macOS 10.13.3 to 10.13.4. Before: OS Version: 17D102 After: OS Version: 1.7e+200 It should read "17E199". I guess something thinks it's floating point... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From zack.galbreath at kitware.com Fri Apr 6 14:09:03 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Fri, 6 Apr 2018 10:09:03 -0400 Subject: [CDash] macOS 10.13.4 confused cdash "OS Version" string In-Reply-To: <20180404192948.1504240828@mail.rogue-research.com> References: <20180404192948.1504240828@mail.rogue-research.com> Message-ID: On Wed, Apr 4, 2018 at 3:29 PM, Sean McBride wrote: > Hi cdash devs, > > I recently updated my Rogue15 bot from macOS 10.13.3 to 10.13.4. > > Before: > > OS Version: 17D102 > > After: > > OS Version: 1.7e+200 > > > It should read "17E199". I guess something thinks it's floating point... > Right you are, thanks for pointing this out. We previously noticed CDash interpreting some strings as numbers due to e-notation. We added a check to prevent this, but it was only looking for the presence of 'e', not 'E'. I'll modify this to be a case insensitive check instead. -------------- next part -------------- An HTML attachment was scrubbed... URL: From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 09:11:12 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 11:11:12 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <0c0a7961db09938f9574223db566d0e1@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> Message-ID: <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Update #2: As a workaround, I entered the "Repository Viewer URL" (CDash Settings, Project, Repository) with uppercase "HTTPS": HTTPS://github.com/SuperElastix/SuperElastix It appears that CDash does not strip off uppercase "HTTPS://" (while it does strip off lowercase "https://")! So now the little Octocat.png icons at our dashboard properly link to the corresponding GitHub pull requests: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Please let us know if this workaround is OK, or if it has some drawbacks. -- Niels -------- Original Message -------- Subject: Re: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php Date: 2018-04-02 13:12 Update: it appears to me that these GitHub pull request links at CDash index.php are broken, because CDash strips "https://" from the GitHub URLs. Is this a known issue? Do you have a workaround? More details: CDash produces the following HTML code, for a pull request at http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 Web browsers assume that the GitHub URL at href="..." is a relative path, because it does not start with "http[s]://". So there is where the link gets broken. I observed the "https://" being stripped as follows: - I went to http://trunk.cdash.org/index.php?project=SuperElastix - Logged in - Opened "Edit Project" page (createProject.php), from the Settings menu. - Went to Repository tab page. - Entered "https://github.com/SuperElastix/SuperElastix" at "Repository Viewer URL:" - Clicked the "Update Project" button, and then, "https://" was gone! I guess this stripping is done by stripHTTP($url), at: https://github.com/Kitware/CDash/blob/d46d9e06dc83d577aacecfa4b95a3613bcbca1a6/public/api/v1/project.php#L214 The GitHub URL that is stripped is internally referred to as 'cdash.project.CvsUrl' Hope you can help me to get it fixed! (A workaround would be nice as well.) Kind regards, Niels -------- Original Message -------- Date: 2018-03-30 20:25 I just experienced this really cool feature that when CTEST_CHANGE_ID is set for a specific build, a little GitHub icon appears at the index.php, in the table entry of the Build Name, for that particular build. For the SuperElastix project that I am involved with, at: http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 I guess the GitHub icon should link to the GitHub pull request, https://github.com///pull/, and that would be wonderful. Unfortunately the GitHub links are broken, at the cdash.org/index.php page of our project, as they points to: http://trunk.cdash.org/github.com/SuperElastix/SuperElastix/pull/183 Which says: "The requested URL /github.com/SuperElastix/SuperElastix/pull/183 was not found on this server" I saw the same problem here: https://open.cdash.org/index.php?project=Fletch&date=2018-03-30 Which has GitHub icons linking to: https://open.cdash.org/github.com/kitware/fletch/pull/354 Do we do something wrong in our CDash project settings, or is it a bug? Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From zack.galbreath at kitware.com Sat Apr 7 12:00:15 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Sat, 7 Apr 2018 08:00:15 -0400 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: <9eeb81ac400328a9388e932c1897dede@xs4all.nl> References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker < niels_dekker_address_until_2024 at xs4all.nl> wrote: > Update #2: As a workaround, I entered the "Repository Viewer URL" (CDash > Settings, Project, Repository) with uppercase "HTTPS": > > HTTPS://github.com/SuperElastix/SuperElastix > > It appears that CDash does not strip off uppercase "HTTPS://" (while it > does strip off lowercase "https://")! So now the little Octocat.png icons > at our dashboard properly link to the corresponding GitHub pull requests: > > http://trunk.cdash.org/index.php?project=SuperElastix&date=2018-03-30 > > Please let us know if this workaround is OK, or if it has some drawbacks. That sounds like a reasonable workaround. Thanks for digging into this issue and figuring out what's causing it. I think the right fix (as you indicated) is to remove the stripHTTP function and its uses altogether. But I want to do some manual testing first to make sure this won't cause problems with any of our other external links. -------------- next part -------------- An HTML attachment was scrubbed... URL: From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 20:26:41 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 22:26:41 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: Zack Galbreath wrote on Sat, Apr 7 2018 14:00: > On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker wrote: > >> Update #2: As a workaround, I entered the "Repository Viewer URL" >> (CDash Settings, Project, Repository) with uppercase "HTTPS": > > That sounds like a reasonable workaround. Thanks for digging into > this issue and figuring out what's causing it. I think the right fix > (as you indicated) is to remove the stripHTTP function and its uses > altogether. But I want to do some manual testing first to make sure > this won't cause problems with any of our other external links. You're welcome, Zack :-) I guess there must have been a reason to do stripHTTP, that I just don't know... So far, I only saw one side effect of entering uppercase "HTTPS" in the "Repository Viewer URL" field. When I entered the URL, a text appeared next to "Test URL:", saying: "http://HTTPS://github.com/SuperElastix/SuperElastix/blob/REVISION/DIRECTORYNAME/FILENAME" That doesn't look good: "http://HTTPS://github.com/...". But does it do any harm, if it's just the "Test URL"? By the way, on the first Settings tab page ("Information"), the "Home URL" is also stripped. I don't know whether this is either buggy or useful. Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From niels_dekker_address_until_2024 at xs4all.nl Sat Apr 7 20:48:15 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Sat, 07 Apr 2018 22:48:15 +0200 Subject: [CDash] Broken links to github.com///pull/CHANGE_ID at cdash.org/index.php In-Reply-To: References: <2ac442db9e2ca65a12b108d298085ee9@xs4all.nl> <0c0a7961db09938f9574223db566d0e1@xs4all.nl> <9eeb81ac400328a9388e932c1897dede@xs4all.nl> Message-ID: <840dc4ab186eb3ce11c13ece432ed1a0@xs4all.nl> Update: I just found a little drawback of the workaround that I presented (entering uppercase "HTTPS" in the "Repository Viewer URL" field). It breaks the link of the "Repository" menu item, in the Project menu, at http://trunk.cdash.org/?project=SuperElastix After my workaround, the "Repository" menu item links to: http://https//github.com/SuperElastix/SuperElastix That's clearly wrong. But I feel it's more important to have correct links to pull requests. -- Niels -------- Original Message -------- Date: 2018-04-07 22:26 From: Niels Dekker Zack Galbreath wrote on Sat, Apr 7 2018 14:00: > On Sat, Apr 7, 2018 at 5:11 AM, Niels Dekker wrote: > >> Update #2: As a workaround, I entered the "Repository Viewer URL" >> (CDash Settings, Project, Repository) with uppercase "HTTPS": > > That sounds like a reasonable workaround. Thanks for digging into > this issue and figuring out what's causing it. I think the right fix > (as you indicated) is to remove the stripHTTP function and its uses > altogether. But I want to do some manual testing first to make sure > this won't cause problems with any of our other external links. You're welcome, Zack :-) I guess there must have been a reason to do stripHTTP, that I just don't know... So far, I only saw one side effect of entering uppercase "HTTPS" in the "Repository Viewer URL" field. When I entered the URL, a text appeared next to "Test URL:", saying: "http://HTTPS://github.com/SuperElastix/SuperElastix/blob/REVISION/DIRECTORYNAME/FILENAME" That doesn't look good: "http://HTTPS://github.com/...". But does it do any harm, if it's just the "Test URL"? By the way, on the first Settings tab page ("Information"), the "Home URL" is also stripped. I don't know whether this is either buggy or useful. Kind regards, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From niels_dekker_address_until_2024 at xs4all.nl Tue Apr 10 15:39:37 2018 From: niels_dekker_address_until_2024 at xs4all.nl (Niels Dekker) Date: Tue, 10 Apr 2018 17:39:37 +0200 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? Message-ID: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> It would be very convenient if each Update page of a project would show the corresponding revision tag (Git SHA) of the project, possibly with a link to the specific revision (e.g., at GitHub). It seems like this functionality was built into CDash, but it just does not work! Colleagues of mine at LKEB (www.lkeb.nl) helped me to find some possible bugs in the CDash AngularJS code, that seem to cause this issue. Regarding the SuperElastix project that I am involved with (https://github.com/SuperElastix), I would have liked to see the Git SHA of SuperElastix at http://trunk.cdash.org/viewUpdate.php?buildid=1238277 The HTML source of that page says:
Revision: {{::cdash.update.revision}} Could it be that "cdash.updates.revision" was misspelled? Shouldn't it be "cdash.update.revision" (without the 's')? Moreover, it seems that some extra "{{" and "}}" might be needed, for AngularJS markups inside an ng-href="...". Specifically, it seems that "::cdash.update.revisionurl" should be "{{::cdash.update.revisionurl}}". What do you think? Related file (I guess): https://github.com/Kitware/CDash/blob/4f328cd838d0486901f58c2844fd11415b4abb52/public/views/viewUpdate.html HTH, Niels -- Niels Dekker Scientific programmer LKEB, Leiden University Medical Center From zack.galbreath at kitware.com Thu Apr 12 18:41:10 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Thu, 12 Apr 2018 14:41:10 -0400 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? In-Reply-To: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> References: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> Message-ID: You're right, this looks like a bug on viewUpdate.php. Here's the fix: https://github.com/Kitware/CDash/pull/668 I'll reply here again when trunk.cdash.org gets updated. On Tue, Apr 10, 2018 at 11:39 AM, Niels Dekker < niels_dekker_address_until_2024 at xs4all.nl> wrote: > It would be very convenient if each Update page of a project would show > the corresponding revision tag (Git SHA) of the project, possibly with a > link to the specific revision (e.g., at GitHub). It seems like this > functionality was built into CDash, but it just does not work! Colleagues > of mine at LKEB (www.lkeb.nl) helped me to find some possible bugs in the > CDash AngularJS code, that seem to cause this issue. > > Regarding the SuperElastix project that I am involved with ( > https://github.com/SuperElastix), I would have liked to see the Git SHA > of SuperElastix at http://trunk.cdash.org/viewUpdate.php?buildid=1238277 > The HTML source of that page says: > >
> Revision: > {{::cdash.update.revision}} >
>
> Prior Revision: > {{::cdash.update. > priorrevision}} >
>
>
> > Could it be that "cdash.updates.revision" was misspelled? Shouldn't it be > "cdash.update.revision" (without the 's')? > > Moreover, it seems that some extra "{{" and "}}" might be needed, for > AngularJS markups inside an ng-href="...". Specifically, it seems that > "::cdash.update.revisionurl" should be "{{::cdash.update.revisionurl}}". > What do you think? > > > Related file (I guess): > https://github.com/Kitware/CDash/blob/4f328cd838d0486901f58c > 2844fd11415b4abb52/public/views/viewUpdate.html > > HTH, Niels > > -- > Niels Dekker > Scientific programmer > LKEB, Leiden University Medical Center > _______________________________________________ > CDash mailing list > CDash at public.kitware.com > https://public.kitware.com/mailman/listinfo/cdash > -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Sat Apr 14 11:46:18 2018 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Sat, 14 Apr 2018 07:46:18 -0400 Subject: [CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code? In-Reply-To: References: <78509e632c0c203bf7c5defe13f5e145@xs4all.nl> Message-ID: On Thu, Apr 12, 2018 at 2:41 PM, Zack Galbreath wrote: > I'll reply here again when trunk.cdash.org gets updated. > trunk.cdash.org has been updated with this fix. Thanks again for noticing this bug and bringing it to our attention. -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Mon Apr 23 23:05:16 2018 From: sean at rogue-research.com (Sean McBride) Date: Mon, 23 Apr 2018 19:05:16 -0400 Subject: [CDash] Link to source code from errors pages are broken Message-ID: <20180423230516.1755464250@mail.rogue-research.com> Hi, Here for example: there is a hyperlink to: It's 404 though. Someone might want to fix that. :) Does the feature work? In my own/private instance of cdash, I'd like to have that link work. Where does one configure the base URL? Thanks, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada