[Cdash] Missing command arguments in build failures

[Nils Gladitz]

On 03/31/2015 04:20 PM, Nils Gladitz wrote:
> Since the mailing list currently seems to have more traction than the
> issue tracker I thought I'd mention it here as well:
>
> http://www.cmake.org/Bug/view.php?id=15484
>
> Apparently sometimes the "buildfailure2argument" table references
> arguments that are missing from the "buildfailureargument" table.
>
> This leads to seemingly random missing arguments in the command lines
> shown on viewBuildError.php which obviously makes trusting/reproducing
> them difficult.

Could it be as simple as this?

diff --git a/models/buildfailure.php b/models/buildfailure.php
index f31b72b..1fb514a 100644
--- a/models/buildfailure.php
+++ b/models/buildfailure.php
@@ -143,7 +143,7 @@ class BuildFailure
            return false;
            }

-        $argumentids[] = pdo_insert_id("buildfailure");
+        $argumentids[] = pdo_insert_id("buildfailureargument");
          }
        }


Nils