[Cdash] cdash upgrade and no longer sending emails

[Clinton Stimpson]

Ok, that does clarify some things and makes more sense.  Thanks.

However, I'm seeing that cdash attempts to send emails while processing the 
Build.xml rather than waiting for the Update.xml.

If my subscription is to get emails for any commits, then I do get the emails.
If my subscription is to get emails only for my commits, then I do not get the 
emails.

In CDash 2.0, I have in do_submit.php:
  // Send the emails if necessary
  if($handler instanceof UpdateHandler ||
     $handler instanceof TestingHandler ||
     $handler instanceof BuildHandler ||
     $handler instanceof ConfigureHandler ||
     $handler instanceof DynamicAnalysisHandler)
    {
    sendemail($handler, $projectid);
    }


In CDash 2.2, I have
  // Send the emails if necessary
  if($handler instanceof UpdateHandler)
    {
    send_update_email($handler, $projectid);
    }
  if($handler instanceof TestingHandler ||
     $handler instanceof BuildHandler ||
     $handler instanceof ConfigureHandler ||
     $handler instanceof DynamicAnalysisHandler)
    {
    sendemail($handler, $projectid);
    }


There is no longer a call to sendemail() when the handler is an UpdateHandler.

In CDash 2.2, send_update_email() only sends emails to site maintainers for 
update errors.

I'm going to try changing it to this to see if I can restore emails to 
committers.
  // Send the emails if necessary
  if($handler instanceof UpdateHandler)
    {
    send_update_email($handler, $projectid);
    }
  if($handler instanceof TestingHandler ||
     $handler instanceof BuildHandler ||
     $handler instanceof UpdateHandler ||
     $handler instanceof ConfigureHandler ||
     $handler instanceof DynamicAnalysisHandler)
    {
    sendemail($handler, $projectid);
    }


Clint

On Friday, March 27, 2015 12:18:42 PM David Cole wrote:
> (That's why your update results don't show when you send update.xml
> first. They get added, then promptly deleted again when the build.xml
> comes in...)
> 
> On Fri, Mar 27, 2015 at 12:17 PM, David Cole <DLRdave at aol.com> wrote:
> > CDash deletes a build with the same key when Build.xml is submitted.
> > 
> > It's based on the heuristic that ctest sends Build.xml first.
> > 
> > If you change that, lots of stuff will break in the wild, and mass
> > confusion will ensue.....
> > 
> > ;-)
> > 
> > On Fri, Mar 27, 2015 at 12:01 PM, Clinton Stimpson <clinton at elemtech.com> 
wrote:
> >> On Friday, March 27, 2015 10:59:46 AM Zack Galbreath wrote:
> >>> On Fri, Mar 27, 2015 at 10:55 AM, <clinton at elemtech.com> wrote:
> >>> > I also noticed that while submitting, ctest is sending the Build.xml
> >>> > file
> >>> > before the Update.xml file.  Is that a problem?
> >>> 
> >>> That very well could be what's causing your issue.  Would it be easy for
> >>> you to test submitting Update.xml before Build.xml to see if this
> >>> problem
> >>> goes away?
> >> 
> >> I'm seeing some odd behavior....
> >> I've modified ctest to send Update.xml before Build.xml.
> >> 
> >> If I submit only the Update.xml, it goes through fine and shows up on
> >> cdash. If I submit Update.xml then Build.xml together, the results of
> >> Update.xml don't show up on cdash.  If I go look in the mysql database,
> >> sure enough, its not there.
> >> 
> >> If I submit Build.xml then Update.xml, whether together or separate, they
> >> both show on cdash.
> >> 
> >> I think I'm missing something here...
> >> ctest has been submitting in alphabetical order for quite some time, and
> >> does so for everyone.
> >> 
> >> 
> >> Maybe this is related to the issue of me never getting emails from
> >> open.cdash.org.  I used to get them a few years ago... but no longer.
> >> I resort to watching open.cdash.org after commits.
> >> 
> >> My subscriptions are set to
> >> "when my checkins are causing problems in any sections of the dashboard"
> >> 
> >> Do emails work for others with this type of subscription on
> >> open.cdash.org?
> >> 
> >> Thanks,
> >> Clint
> >> _______________________________________________
> >> Cdash mailing list
> >> Cdash at public.kitware.com
> >> http://public.kitware.com/mailman/listinfo/cdash