[Cdash] [PATCH] Perforce support for CDash

[Pedro Navarro]

Filed http://public.kitware.com/Bug/view.php?id=14524 to monitor this
issue. I already have a patch for this. Thanks Igor!

Pedro


On Wed, Oct 30, 2013 at 10:50 AM, Pedro Navarro <pnavarro at netflix.com>wrote:

> Yes, I would prefer the first variant also. I assumed the variable would
> already come quoted (the second variant) because that's what I thought
> $CDASH_GIT_COMMAND was using, but looking at the git code I see that the
> comand is quoted when it's run. I'll add something similar.
>
> Pedro
>
>
> On Wed, Oct 30, 2013 at 3:17 AM, Igor Murzov <e-mail at date.by> wrote:
>
>> > > >   $p4command = $CDASH_P4_COMMAND." ".$root." -L en";
>> > >
>> > > >  $raw_output = `$p4command changes $branch@"$fromtime","$totime"
>> > > > 2>&1`;
>> > >
>> > > Can it happen that $root or $CDASH_P4_COMMAND contain spaces or some
>> > > other special characters? I think some quoting might be needed here.
>> > >
>> > >
>> > >
>> > I guess it could happen, yes, but wouldn't these values come already
>> > quoted from the configuration settings?
>>
>> I'm not sure what do you mean by this. Do you want users to quote every
>> special character?
>> For instance, if $CDASH_P4_COMMAND is set like:
>>
>>   $CDASH_P4_COMMAND = '/prefix/with space/p4';
>>
>> then your code will fail. But it would work if $CDASH_P4_COMMAND is set
>> like this:
>>
>>   $CDASH_P4_COMMAND = '/prefix/with\ space/p4';
>>
>> If I used perforce, I would prefer the first variant :)
>>
>>
>> -- Igor
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cdash/attachments/20131030/770ad137/attachment-0003.htm>