[Cdash] Dart1 and CDash submit

[Emmett, Phillip]

There must be some interaction with the version of libxml2/php also,
since after I upgraded my server I no longer get the CDATA. And I did
not update to get this patch. Perhaps php now correctly labels it as
xml/text as the bug report mentioned. 

Also, it doesn't work with cvsweb as I expected. Although I got it to
work by tweeking the php. I don't know if all cvsweb setups work like
this, I don't have much experience with them, but all I had to do for
ours was drop the .diff being added in the url being made in
get_viewcvs_diff_url. The other parts, rev/r1/r2/etc. appear to be
compatible.

-phil

-----Original Message-----
From: Julien Jomier [mailto:julien.jomier at kitware.com] 
Sent: Tuesday, March 18, 2008 8:38 AM
To: cdash at public.kitware.com
Cc: Emmett, Phillip
Subject: Re: [Cdash] Dart1 and CDash submit

Stuart Herring wrote:
> On Tue, Mar 18, 2008 at 12:20 AM, Emmett, Phillip 
> <Phillip.Emmett at xerox.com> wrote:
>>
>> Trevor,
>> If you look at the page source for "viewUpdate" do you see a bunch of

>> "addDb"s in a block of Javascript wrapped in a "CDATA" block? I think

>> the CDATA prevents the browser from parsing the javascript. This is 
>> what I see and my research appears to point at my libxml2 being old 
>> and broken. I have 2.6.20. The server is getting upgraded tomorrow, 
>> so my hunch will be tested soon. :-)
>>
>> -phil
>>
> This is the same cause as 
> http://public.kitware.com/Bug/view.php?id=6604
> Attached is a patch that should fix it..
> Although I'm sure there has to be a better way - it would get tiresome

> having to remember to wrap <script> elements with bodies in <xsl:text 
> ...> and manually escaping.
> 

The patch has been applied to svn. Thanks a lot.

The better way to do it is to put all the javascript code in a .js file
and include it in the xsl file. However for small javascript it actually
makes sense to escape it.

Julien