https://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&feed=atom&action=historyVTK/Git/Develop Release - Revision history2024-03-29T09:43:23ZRevision history for this page on the wikiMediaWiki 1.38.6https://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=56024&oldid=prevDaveDemarle: /* Reviewing and Submitting Changes */2014-04-03T14:59:34Z<p><span dir="auto"><span class="autocomment">Reviewing and Submitting Changes</span></span></p>
<table style="background-color: #fff; color: #202122;" data-mw="interface">
<col class="diff-marker" />
<col class="diff-content" />
<col class="diff-marker" />
<col class="diff-content" />
<tr class="diff-title" lang="en">
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td>
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 14:59, 3 April 2014</td>
</tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l15">Line 15:</td>
<td colspan="2" class="diff-lineno">Line 15:</td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Reviewing and Submitting Changes ==</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Reviewing and Submitting Changes ==</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>The normal [http://review.source.kitware.com/#/admin/groups/11,members set of core reviewers] can be asked to review, but a much smaller set of people has submit privileges. At present this is limited to Dave DeMarle and Marcus D. Hanwell but the list may be expanded in the future. The topics are not tested by CDash@Home or the continuous submitters but nightly dashboard tests from mac, windows and linux machines are present. </div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>The normal [http://review.source.kitware.com/#/admin/groups/11,members set of core reviewers] can be asked to review, but a much smaller set of people has submit privileges. At present this is limited to Dave DeMarle and Marcus D. Hanwell but the list may be expanded in the future. The topics are not tested by CDash@Home or the continuous submitters but nightly dashboard tests from mac, windows and linux machines are present<ins style="font-weight: bold; text-decoration: none;">, and contributors should be careful to watch them after their work is merged</ins>.</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>In order to push a topic for review do the following while in the topic:</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>In order to push a topic for review do the following while in the topic:</div></td></tr>
</table>DaveDemarlehttps://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=56023&oldid=prevDaveDemarle at 14:57, 3 April 20142014-04-03T14:57:38Z<p></p>
<table style="background-color: #fff; color: #202122;" data-mw="interface">
<col class="diff-marker" />
<col class="diff-content" />
<col class="diff-marker" />
<col class="diff-content" />
<tr class="diff-title" lang="en">
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td>
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 14:57, 3 April 2014</td>
</tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l1">Line 1:</td>
<td colspan="2" class="diff-lineno">Line 1:</td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 had several major changes, including the build system and library layout changes. Given the scope of the changes, it is important to support the 5.10 release for longer to <del style="font-weight: bold; text-decoration: none;">support </del>those who are not yet ready to port to VTK 6+. At the same time, we have decided not to encourage continued development on the branch and wish to prevent having the 5.10 branch diverge further from 6.x</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 had several major changes, including the build system and library layout changes. Given the scope of the changes, it is important to support the 5.10 release for longer to <ins style="font-weight: bold; text-decoration: none;">help </ins>those who are not yet ready to port to VTK 6+ <ins style="font-weight: bold; text-decoration: none;">make progress</ins>. At the same time, we have decided not to encourage continued development on the branch and wish to prevent having the 5.10 branch diverge further from 6.x</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>With this in mind, we have added some software development infrastructure that enables developers to maintain the 5.10 branch. Specifically we now have a release-5.10 branch in the VTK repository, Mac, Windows and Linux dashboard submitters on the branch, and a workflow by which proposed changes are shared and reviewed before merging onto the branch. The branch was started from the v5.10.1 tag and is only intended for merging '''critical''' bug fixes, and '''conservative''' patches to allow VTK 5.10 to continue working on new platforms and with new compilers until a majority of projects have made the switch to 6.x.</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>With this in mind, we have added some software development infrastructure that enables developers to maintain the 5.10 branch. Specifically we now have a release-5.10 branch in the VTK repository, Mac, Windows and Linux dashboard submitters on the branch, and a workflow by which proposed changes are shared and reviewed before merging onto the branch. The branch was started from the v5.10.1 tag and is only intended for merging '''critical''' bug fixes, and '''conservative''' patches to allow VTK 5.10 to continue working on new platforms and with new compilers until a majority of projects have made the switch to 6.x.</div></td></tr>
</table>DaveDemarlehttps://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=56022&oldid=prevDaveDemarle at 14:57, 3 April 20142014-04-03T14:57:13Z<p></p>
<table style="background-color: #fff; color: #202122;" data-mw="interface">
<col class="diff-marker" />
<col class="diff-content" />
<col class="diff-marker" />
<col class="diff-content" />
<tr class="diff-title" lang="en">
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td>
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 14:57, 3 April 2014</td>
</tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l1">Line 1:</td>
<td colspan="2" class="diff-lineno">Line 1:</td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 had several major changes, including the build system and library layout changes. Given the scope of the changes, it is important to support the 5.10 release for longer to <del style="font-weight: bold; text-decoration: none;">enable </del>those who are not yet ready to port to VTK 6+. At the same time, we have decided not to encourage continued development on the branch and wish to prevent having the 5.10 branch diverge further from 6.x</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 had several major changes, including the build system and library layout changes. Given the scope of the changes, it is important to support the 5.10 release for longer to <ins style="font-weight: bold; text-decoration: none;">support </ins>those who are not yet ready to port to VTK 6+. At the same time, we have decided not to encourage continued development on the branch and wish to prevent having the 5.10 branch diverge further from 6.x</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>With this in mind, we have added some software development infrastructure that enables developers to maintain the 5.10 branch. Specifically we now have a release-5.10 branch in the VTK repository, Mac, Windows and Linux dashboard submitters on the branch, and a workflow by which proposed changes are shared and reviewed before merging onto the branch. The branch was started from the v5.10.1 tag and is only intended for merging '''critical''' bug fixes, and '''conservative''' patches to allow VTK 5.10 to continue working on new platforms and with new compilers until a majority of projects have made the switch to 6.x.</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>With this in mind, we have added some software development infrastructure that enables developers to maintain the 5.10 branch. Specifically we now have a release-5.10 branch in the VTK repository, Mac, Windows and Linux dashboard submitters on the branch, and a workflow by which proposed changes are shared and reviewed before merging onto the branch. The branch was started from the v5.10.1 tag and is only intended for merging '''critical''' bug fixes, and '''conservative''' patches to allow VTK 5.10 to continue working on new platforms and with new compilers until a majority of projects have made the switch to 6.x.</div></td></tr>
</table>DaveDemarlehttps://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=56021&oldid=prevDaveDemarle at 14:56, 3 April 20142014-04-03T14:56:38Z<p></p>
<table style="background-color: #fff; color: #202122;" data-mw="interface">
<col class="diff-marker" />
<col class="diff-content" />
<col class="diff-marker" />
<col class="diff-content" />
<tr class="diff-title" lang="en">
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td>
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 14:56, 3 April 2014</td>
</tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l1">Line 1:</td>
<td colspan="2" class="diff-lineno">Line 1:</td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 had several major changes, including the build system and library layout changes. Given the scope of the changes, it is important to support the 5.10 release for longer to enable those who are not yet ready to port to VTK 6+. At the same time, we have decided not to encourage continued development on the branch and wish to <del style="font-weight: bold; text-decoration: none;">precent </del>having the 5.10 branch diverge <del style="font-weight: bold; text-decoration: none;">any </del>further from 6.x</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 had several major changes, including the build system and library layout changes. Given the scope of the changes, it is important to support the 5.10 release for longer to enable those who are not yet ready to port to VTK 6+. At the same time, we have decided not to encourage continued development on the branch and wish to <ins style="font-weight: bold; text-decoration: none;">prevent </ins>having the 5.10 branch diverge further from 6.x</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>With this in mind, we have added some software development infrastructure that enables developers to maintain the 5.10 branch. Specifically we now have a release-5.10 branch in the VTK repository, Mac, Windows and Linux dashboard submitters on the branch, and a workflow by which proposed changes are shared and reviewed before merging onto the branch. The branch was started from the v5.10.1 tag and is only intended for merging '''critical''' bug fixes, and '''conservative''' patches to allow VTK 5.10 to continue working on new platforms and with new compilers until a majority of projects have made the switch to 6.x.</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>With this in mind, we have added some software development infrastructure that enables developers to maintain the 5.10 branch. Specifically we now have a release-5.10 branch in the VTK repository, Mac, Windows and Linux dashboard submitters on the branch, and a workflow by which proposed changes are shared and reviewed before merging onto the branch. The branch was started from the v5.10.1 tag and is only intended for merging '''critical''' bug fixes, and '''conservative''' patches to allow VTK 5.10 to continue working on new platforms and with new compilers until a majority of projects have made the switch to 6.x.</div></td></tr>
</table>DaveDemarlehttps://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=56020&oldid=prevDaveDemarle: just clarified the text a bit2014-04-03T14:56:01Z<p>just clarified the text a bit</p>
<table style="background-color: #fff; color: #202122;" data-mw="interface">
<col class="diff-marker" />
<col class="diff-content" />
<col class="diff-marker" />
<col class="diff-content" />
<tr class="diff-title" lang="en">
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td>
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 14:56, 3 April 2014</td>
</tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l1">Line 1:</td>
<td colspan="2" class="diff-lineno">Line 1:</td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 had several major changes, including the build system and library layout changes. Given the scope of the changes, it is important to support the 5.10 release for longer to enable those who are not yet ready to port to VTK 6+ to <del style="font-weight: bold; text-decoration: none;">continue using </del>the <del style="font-weight: bold; text-decoration: none;">last release before these changes were merged</del>. <del style="font-weight: bold; text-decoration: none;">To that end</del>, we have added some software development infrastructure that enables developers to maintain the 5.10 branch. <del style="font-weight: bold; text-decoration: none;">We </del>have <del style="font-weight: bold; text-decoration: none;">added </del>a release-5.10 branch <del style="font-weight: bold; text-decoration: none;">to our </del>VTK <del style="font-weight: bold; text-decoration: none;">repositories</del>. The branch was started from the v5.10.1 tag and is only intended for merging '''critical''' bug fixes, and '''conservative''' patches to allow VTK 5.10 to continue working on new platforms and with new compilers.</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 had several major changes, including the build system and library layout changes. Given the scope of the changes, it is important to support the 5.10 release for longer to enable those who are not yet ready to port to VTK 6+<ins style="font-weight: bold; text-decoration: none;">. At the same time, we have decided not to encourage continued development on the branch and wish </ins>to <ins style="font-weight: bold; text-decoration: none;">precent having </ins>the <ins style="font-weight: bold; text-decoration: none;">5.10 branch diverge any further from 6</ins>.<ins style="font-weight: bold; text-decoration: none;">x</ins></div></td></tr>
<tr><td colspan="2" class="diff-side-deleted"></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div> </div></td></tr>
<tr><td colspan="2" class="diff-side-deleted"></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div><ins style="font-weight: bold; text-decoration: none;">With this in mind</ins>, we have added some software development infrastructure that enables developers to maintain the 5.10 branch. <ins style="font-weight: bold; text-decoration: none;">Specifically we now </ins>have a release-5.10 branch <ins style="font-weight: bold; text-decoration: none;">in the </ins>VTK <ins style="font-weight: bold; text-decoration: none;">repository, Mac, Windows and Linux dashboard submitters on the branch, and a workflow by which proposed changes are shared and reviewed before merging onto the branch</ins>. The branch was started from the v5.10.1 tag and is only intended for merging '''critical''' bug fixes, and '''conservative''' patches to allow VTK 5.10 to continue working on new platforms and with new compilers <ins style="font-weight: bold; text-decoration: none;">until a majority of projects have made the switch to 6.x</ins>.</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Submitting Patches ==</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Submitting Patches ==</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>Any topic intended for the release-5.10 branch should be <del style="font-weight: bold; text-decoration: none;">branches </del>from the tip of this branch. This can be achieved with the following in a VTK source tree:</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>Any topic intended for the release-5.10 branch should be <ins style="font-weight: bold; text-decoration: none;">branched </ins>from the tip of this branch. This can be achieved with the following in a VTK source tree:</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div> git fetch gerrit</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div> git fetch gerrit</div></td></tr>
<tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l9">Line 9:</td>
<td colspan="2" class="diff-lineno">Line 11:</td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div> git checkout -b my-backported-bugfix</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div> git checkout -b my-backported-bugfix</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>You can then work in that topic as you would normally, cherry picking commits or making changes and committing them. Please bear in mind that we will only consider conservative fixes/changes intended to fix bugs or compiler errors. These should already be present in master, and no new features will be considered for inclusion.</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>You can then work in that topic as you would normally, cherry picking commits <ins style="font-weight: bold; text-decoration: none;"> from the master (6.x) branch </ins>or making changes and committing them. Please bear in mind that we will only consider conservative fixes/changes intended to fix bugs or compiler errors. These should already be present in master, and no new features will be considered for inclusion.</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Reviewing and Submitting Changes ==</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Reviewing and Submitting Changes ==</div></td></tr>
<tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l15">Line 15:</td>
<td colspan="2" class="diff-lineno">Line 17:</td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>The normal [http://review.source.kitware.com/#/admin/groups/11,members set of core reviewers] can be asked to review, but a much smaller set of people has submit privileges. At present this is limited to Dave DeMarle and Marcus D. Hanwell but the list may be expanded in the future. The topics are not tested by CDash@Home or the continuous submitters but nightly dashboard tests from mac, windows and linux machines are present. </div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>The normal [http://review.source.kitware.com/#/admin/groups/11,members set of core reviewers] can be asked to review, but a much smaller set of people has submit privileges. At present this is limited to Dave DeMarle and Marcus D. Hanwell but the list may be expanded in the future. The topics are not tested by CDash@Home or the continuous submitters but nightly dashboard tests from mac, windows and linux machines are present. </div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>In order to push a topic for review the following <del style="font-weight: bold; text-decoration: none;">(</del>while in the topic<del style="font-weight: bold; text-decoration: none;">) will work</del>:</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>In order to push a topic for review <ins style="font-weight: bold; text-decoration: none;">do </ins>the following while in the topic:</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div> git push gerrit HEAD:refs/for/release-5.10/my-backported-bugfix</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div> git push gerrit HEAD:refs/for/release-5.10/my-backported-bugfix</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>Where my-backported-bugfix is the name of the topic as it will appear in Gerrit. Please let us know on the VTK developers list if you experience any problems in submitting changes.</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>Where my-backported-bugfix is the name of the topic as it will appear in Gerrit. Please let us know on the VTK developers list if you experience any problems in submitting changes.</div></td></tr>
</table>DaveDemarlehttps://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=54598&oldid=prevDaveDemarle: /* Reviewing and Submitting Changes */2013-12-03T22:22:55Z<p><span dir="auto"><span class="autocomment">Reviewing and Submitting Changes</span></span></p>
<table style="background-color: #fff; color: #202122;" data-mw="interface">
<col class="diff-marker" />
<col class="diff-content" />
<col class="diff-marker" />
<col class="diff-content" />
<tr class="diff-title" lang="en">
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td>
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 22:22, 3 December 2013</td>
</tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l13">Line 13:</td>
<td colspan="2" class="diff-lineno">Line 13:</td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Reviewing and Submitting Changes ==</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Reviewing and Submitting Changes ==</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>The normal [http://review.source.kitware.com/#/admin/groups/11,members set of core reviewers] can be asked to review, but a much smaller set of people has submit privileges. At present this is limited to Dave DeMarle and Marcus D. Hanwell but the list may be expanded in the future. The topics are not tested by CDash@Home but nightly <del style="font-weight: bold; text-decoration: none;">dashboards will be added</del>. In order to push a topic for review the following (while in the topic) will work:</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>The normal [http://review.source.kitware.com/#/admin/groups/11,members set of core reviewers] can be asked to review, but a much smaller set of people has submit privileges. At present this is limited to Dave DeMarle and Marcus D. Hanwell but the list may be expanded in the future. The topics are not tested by CDash@Home <ins style="font-weight: bold; text-decoration: none;">or the continuous submitters </ins>but nightly <ins style="font-weight: bold; text-decoration: none;">dashboard tests from mac, windows and linux machines are present</ins>. </div></td></tr>
<tr><td colspan="2" class="diff-side-deleted"></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div> </div></td></tr>
<tr><td colspan="2" class="diff-side-deleted"></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>In order to push a topic for review the following (while in the topic) will work:</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div> git push gerrit HEAD:refs/for/release-5.10/my-backported-bugfix</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div> git push gerrit HEAD:refs/for/release-5.10/my-backported-bugfix</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>Where my-backported-bugfix is the name of the topic as it will appear in Gerrit. Please let us know on the VTK developers list if you experience any problems in submitting changes.</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>Where my-backported-bugfix is the name of the topic as it will appear in Gerrit. Please let us know on the VTK developers list if you experience any problems in submitting changes.</div></td></tr>
</table>DaveDemarlehttps://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=54357&oldid=prevMarcus.hanwell: Minor tweaks2013-10-28T16:49:48Z<p>Minor tweaks</p>
<table style="background-color: #fff; color: #202122;" data-mw="interface">
<col class="diff-marker" />
<col class="diff-content" />
<col class="diff-marker" />
<col class="diff-content" />
<tr class="diff-title" lang="en">
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td>
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 16:49, 28 October 2013</td>
</tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l1">Line 1:</td>
<td colspan="2" class="diff-lineno">Line 1:</td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 <del style="font-weight: bold; text-decoration: none;">was a </del>major <del style="font-weight: bold; text-decoration: none;">change in which </del>the build system and library layout <del style="font-weight: bold; text-decoration: none;">was changed significantly</del>. Given the scope of the changes, it is important to support the 5.10 release longer <del style="font-weight: bold; text-decoration: none;">for </del>those who are not yet ready to port to VTK 6+. To <del style="font-weight: bold; text-decoration: none;">this </del>end, we <del style="font-weight: bold; text-decoration: none;">are building up the </del>software development infrastructure that <del style="font-weight: bold; text-decoration: none;">allows </del>developers to <del style="font-weight: bold; text-decoration: none;">extend </del>the 5.10 branch. We<del style="font-weight: bold; text-decoration: none;">'ve just </del>added a release-5.10 branch to <del style="font-weight: bold; text-decoration: none;">Kitware's git and Gerrit </del>VTK repositories. The branch was started from the v5.10.1 tag and is only intended for merging critical bug fixes, and conservative patches to allow VTK 5.10 to continue working on new platforms. </div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>VTK 6 <ins style="font-weight: bold; text-decoration: none;">had several </ins>major <ins style="font-weight: bold; text-decoration: none;">changes, including </ins>the build system and library layout <ins style="font-weight: bold; text-decoration: none;">changes</ins>. Given the scope of the changes, it is important to support the 5.10 release <ins style="font-weight: bold; text-decoration: none;">for </ins>longer <ins style="font-weight: bold; text-decoration: none;">to enable </ins>those who are not yet ready to port to VTK 6+ <ins style="font-weight: bold; text-decoration: none;">to continue using the last release before these changes were merged</ins>. To <ins style="font-weight: bold; text-decoration: none;">that </ins>end, we <ins style="font-weight: bold; text-decoration: none;">have added some </ins>software development infrastructure that <ins style="font-weight: bold; text-decoration: none;">enables </ins>developers to <ins style="font-weight: bold; text-decoration: none;">maintain </ins>the 5.10 branch. We <ins style="font-weight: bold; text-decoration: none;">have </ins>added a release-5.10 branch to <ins style="font-weight: bold; text-decoration: none;">our </ins>VTK repositories. The branch was started from the v5.10.1 tag and is only intended for merging <ins style="font-weight: bold; text-decoration: none;">'''</ins>critical<ins style="font-weight: bold; text-decoration: none;">''' </ins>bug fixes, and <ins style="font-weight: bold; text-decoration: none;">'''</ins>conservative<ins style="font-weight: bold; text-decoration: none;">''' </ins>patches to allow VTK 5.10 to continue working on new platforms <ins style="font-weight: bold; text-decoration: none;">and with new compilers</ins>.</div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Submitting Patches ==</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Submitting Patches ==</div></td></tr>
</table>Marcus.hanwellhttps://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=54356&oldid=prevDaveDemarle at 16:45, 28 October 20132013-10-28T16:45:11Z<p></p>
<table style="background-color: #fff; color: #202122;" data-mw="interface">
<col class="diff-marker" />
<col class="diff-content" />
<col class="diff-marker" />
<col class="diff-content" />
<tr class="diff-title" lang="en">
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td>
<td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 16:45, 28 October 2013</td>
</tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l1">Line 1:</td>
<td colspan="2" class="diff-lineno">Line 1:</td></tr>
<tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>We <del style="font-weight: bold; text-decoration: none;">recently </del>added <del style="font-weight: bold; text-decoration: none;">the </del>release-5.10 branch to Gerrit<del style="font-weight: bold; text-decoration: none;">, this </del>was started from the v5.10.1 tag and is only intended for merging bug fixes, and conservative patches to allow VTK 5.10<del style="font-weight: bold; text-decoration: none;">.y </del>to continue working on new platforms<del style="font-weight: bold; text-decoration: none;">. VTK 6 was a major change in which the build system and library layout was changes significantly, and is the primary reason for treating the 5.10 release differently for those who are not yet ready to port to VTK 6+</del>.</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div><ins style="font-weight: bold; text-decoration: none;">VTK 6 was a major change in which the build system and library layout was changed significantly. Given the scope of the changes, it is important to support the 5.10 release longer for those who are not yet ready to port to VTK 6+. To this end, we are building up the software development infrastructure that allows developers to extend the 5.10 branch. </ins>We<ins style="font-weight: bold; text-decoration: none;">'ve just </ins>added <ins style="font-weight: bold; text-decoration: none;">a </ins>release-5.10 branch to <ins style="font-weight: bold; text-decoration: none;">Kitware's git and </ins>Gerrit <ins style="font-weight: bold; text-decoration: none;">VTK repositories. The branch </ins>was started from the v5.10.1 tag and is only intended for merging <ins style="font-weight: bold; text-decoration: none;">critical </ins>bug fixes, and conservative patches to allow VTK 5.10 to continue working on new platforms. </div></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br/></td></tr>
<tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Submitting Patches ==</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== Submitting Patches ==</div></td></tr>
</table>DaveDemarlehttps://public.kitware.com/Wiki/index.php?title=VTK/Git/Develop_Release&diff=54349&oldid=prevMarcus.hanwell: Added some initial notes about pushing to 5.102013-10-28T15:57:01Z<p>Added some initial notes about pushing to 5.10</p>
<p><b>New page</b></p><div>We recently added the release-5.10 branch to Gerrit, this was started from the v5.10.1 tag and is only intended for merging bug fixes, and conservative patches to allow VTK 5.10.y to continue working on new platforms. VTK 6 was a major change in which the build system and library layout was changes significantly, and is the primary reason for treating the 5.10 release differently for those who are not yet ready to port to VTK 6+.<br />
<br />
== Submitting Patches ==<br />
<br />
Any topic intended for the release-5.10 branch should be branches from the tip of this branch. This can be achieved with the following in a VTK source tree:<br />
<br />
git fetch gerrit<br />
git checkout release-5.10<br />
git checkout -b my-backported-bugfix<br />
<br />
You can then work in that topic as you would normally, cherry picking commits or making changes and committing them. Please bear in mind that we will only consider conservative fixes/changes intended to fix bugs or compiler errors. These should already be present in master, and no new features will be considered for inclusion.<br />
<br />
== Reviewing and Submitting Changes ==<br />
<br />
The normal [http://review.source.kitware.com/#/admin/groups/11,members set of core reviewers] can be asked to review, but a much smaller set of people has submit privileges. At present this is limited to Dave DeMarle and Marcus D. Hanwell but the list may be expanded in the future. The topics are not tested by CDash@Home but nightly dashboards will be added. In order to push a topic for review the following (while in the topic) will work:<br />
<br />
git push gerrit HEAD:refs/for/release-5.10/my-backported-bugfix<br />
<br />
Where my-backported-bugfix is the name of the topic as it will appear in Gerrit. Please let us know on the VTK developers list if you experience any problems in submitting changes.</div>Marcus.hanwell