ITK Release 4/QuadEdgeMesh Filter: Difference between revisions

From KitwarePublic
Jump to navigationJump to search
Line 25: Line 25:


No specific order
No specific order
=== Conditional Iterators ===
* I have written mesh iterators for VTK. I have allowed the iterator to be a "conditional iterator" by subclassing and reimplementing the AddVertex function. It performs any test the user would like on the current vertex and the next vertex. (I.e. you can add the next vertex to the queue only if it is close enough (by any metric - distance, color, normal angle, etc) to the current vertex). I tried to do this a long time ago with itkQuadEdgeMeshFrontIterator and it was very confusing.
Here is my superclass:
http://github.com/daviddoria/daviddoria-vtk/blob/VTK-ConditionalGraphIterators/Filtering/vtkGraphIterator.h
And then a derived class: (this one is long because it shows 3 different conditions)
http://github.com/daviddoria/daviddoria-vtk/blob/VTK-ConditionalGraphIterators/Infovis/vtkGraphVertexDataConditionalIterator.cxx
Just my $.02 :) [[User:Daviddoria|daviddoria]] 07:25, 17 September 2010 (EDT)


=== Move Existing classes out of review ===
=== Move Existing classes out of review ===

Revision as of 11:25, 17 September 2010

QuadEdgeMesh Filters

original page

Wen Li - Iowa

Insight Journal contributions

There are two filters about to be committed.

  • Window Scalars Mesh Filter
  • Shift Scalars Mesh Filter

Alex Gouaillard et al

during the span of the project : Creatis@lyon, Sun Microsystems ERI@beijing, caltech, Harvard Med. School, A*STAR@singapore, CoSMo@everywhere

Whith help from A. Gelas, E. Boix, L.Florez, M. Malaterre.

TODO

No specific order

Conditional Iterators

  • I have written mesh iterators for VTK. I have allowed the iterator to be a "conditional iterator" by subclassing and reimplementing the AddVertex function. It performs any test the user would like on the current vertex and the next vertex. (I.e. you can add the next vertex to the queue only if it is close enough (by any metric - distance, color, normal angle, etc) to the current vertex). I tried to do this a long time ago with itkQuadEdgeMeshFrontIterator and it was very confusing.

Here is my superclass: http://github.com/daviddoria/daviddoria-vtk/blob/VTK-ConditionalGraphIterators/Filtering/vtkGraphIterator.h

And then a derived class: (this one is long because it shows 3 different conditions) http://github.com/daviddoria/daviddoria-vtk/blob/VTK-ConditionalGraphIterators/Infovis/vtkGraphVertexDataConditionalIterator.cxx

Just my $.02 :) daviddoria 07:25, 17 September 2010 (EDT)

Move Existing classes out of review

  • rename filters?
  • remove VTK reader / writer in favor of iowa's Mesh IO?
  • test compilation without ITK_USE_REVIEW to check there is no left behind
  • fix the test drivers
  • check coverage

Review and possibly move other filters from Insight Journal

move Cuberille Implicit Surface Polygonization for ITK to ITK

  • review IJ paper
  • make it work with QuadEdge
    • use exceptions here and there in QE to catch non-manifoldness
  • global code review
  • move it

Illustrate and optimize

  • write benchmarks for data structure ( => Example)
  • profile
  • document structure building process (AddCell)
  • come up with an optimal building process (AddCell)
  • optimize code for speed
  • profil decimation and other slow filters
  • optimize code for speed

Document

  • Add a Surface Mesh part to the ITK software guide.
    • structure
    • Euler Operators
    • FIlters

recode and replace the simplex implementation with the old QEMeshWithDual design

  • write the data structure with a second point container
  • write trianglemeshtosimplexmesh (and back) filters, use them for benchmark
  • check the other filters of the simplex framework for QE compatibility
  • see if we can have the complete framework leverage QE (note, if there is no topological change, it might be slower to use QE)

move out of review

First step of moving QE out of review

The basic structure as well as the Euler Operators and the helpers have been moved to Common. The filters have been moved to Algorithms and the VTKPolyData readers and wroteers to IO. The source files for the test have been moved to the corresponding directory under Testing. The tests have been removed or disabled and need further attention.

Change-Id: Ib25a00ca58c58103c184100ad51b561e5406cf72


oving files needed by QuadEdgeMesh tests out of review.

Those one felt between the cracks the first time.

Change-Id: I656be8aee7a318493272146223d288c38a6e7b1d

Moved to Code/Algorithm

  • itkPriorityQueueContainer.h # container. should it go to Common?
  • itkQuadEdgeMeshBorderTransform.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshBorderTransform.txx # should we rename and add Filter at the end?
  • itkQuadEdgeMeshCleanFilter.h
  • itkQuadEdgeMeshDecimationCriteria.h
  • itkQuadEdgeMeshDecimationFilter.h
  • itkQuadEdgeMeshDecimationQuadricElementHelper.h
  • itkQuadEdgeMeshDelaunayConformingFilter.h
  • itkQuadEdgeMeshDelaunayConformingFilter.txx
  • itkQuadEdgeMeshDiscreteCurvatureEstimator.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshDiscreteCurvatureTensorEstimator.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshDiscreteGaussianCurvatureEstimator.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshDiscreteMaxCurvatureEstimator.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshDiscreteMeanCurvatureEstimator.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshDiscreteMinCurvatureEstimator.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshDiscretePrincipalCurvaturesEstimator.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshEdgeMergeDecimationFilter.h
  • itkQuadEdgeMeshEdgeMergeDecimationFilter.txx
  • itkQuadEdgeMeshNormalFilter.h
  • itkQuadEdgeMeshNormalFilter.txx
  • itkQuadEdgeMeshParam.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshParam.txx # should we rename and add Filter at the end?
  • itkQuadEdgeMeshParamMatrixCoefficients.h
  • itkQuadEdgeMeshQuadricDecimation.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshSmoothing.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshSmoothing.txx # should we rename and add Filter at the end?
  • itkQuadEdgeMeshSquaredEdgeLengthDecimation.h # should we rename and add Filter at the end?
  • itkQuadEdgeMeshSquaredEdgeLengthDecimation.txx # should we rename and add Filter at the end?
  • itkQuadEdgeMeshToQuadEdgeMeshFilter.h
  • itkQuadEdgeMeshToQuadEdgeMeshFilter.txx

Moved to Code/Common

  • itkGeometricalQuadEdge.h
  • itkGeometricalQuadEdge.txx
  • itkQuadEdge.cxx
  • itkQuadEdge.h
  • itkQuadEdgeCellTraitsInfo.h
  • itkQuadEdgeMesh.h
  • itkQuadEdgeMesh.txx
  • itkQuadEdgeMeshBaseIterator.h
  • itkQuadEdgeMeshBoundaryEdgesMeshFunction.h
  • itkQuadEdgeMeshBoundaryEdgesMeshFunction.txx
  • itkQuadEdgeMeshEulerOperatorCreateCenterVertexFunction.h
  • itkQuadEdgeMeshEulerOperatorCreateCenterVertexFunction.txx
  • itkQuadEdgeMeshEulerOperatorDeleteCenterVertexFunction.h
  • itkQuadEdgeMeshEulerOperatorDeleteCenterVertexFunction.txx
  • itkQuadEdgeMeshEulerOperatorFlipEdgeFunction.h
  • itkQuadEdgeMeshEulerOperatorFlipEdgeFunction.txx
  • itkQuadEdgeMeshEulerOperatorJoinFacetFunction.h
  • itkQuadEdgeMeshEulerOperatorJoinFacetFunction.txx
  • itkQuadEdgeMeshEulerOperatorJoinVertexFunction.h
  • itkQuadEdgeMeshEulerOperatorJoinVertexFunction.txx
  • itkQuadEdgeMeshEulerOperatorSplitEdgeFunction.h
  • itkQuadEdgeMeshEulerOperatorSplitFacetFunction.h
  • itkQuadEdgeMeshEulerOperatorSplitFacetFunction.txx
  • itkQuadEdgeMeshEulerOperatorSplitVertexFunction.h
  • itkQuadEdgeMeshEulerOperatorSplitVertexFunction.txx
  • itkQuadEdgeMeshExtendedTraits.h
  • itkQuadEdgeMeshFrontIterator.h
  • itkQuadEdgeMeshFrontIterator.txx
  • itkQuadEdgeMeshFunctionBase.h
  • itkQuadEdgeMeshLineCell.h
  • itkQuadEdgeMeshLineCell.txx
  • itkQuadEdgeMeshMacro.h
  • itkQuadEdgeMeshPoint.h
  • itkQuadEdgeMeshPoint.txx
  • itkQuadEdgeMeshPolygonCell.h
  • itkQuadEdgeMeshPolygonCell.txx
  • itkQuadEdgeMeshTopologyChecker.h
  • itkQuadEdgeMeshTopologyChecker.txx
  • itkQuadEdgeMeshTraits.h
  • itkQuadEdgeMeshZipMeshFunction.h
  • itkQuadEdgeMeshZipMeshFunction.txx
  • itkTriangleHelper.h
  • itkTriangleHelper.txx

Moved to Code/IO

  • itkQuadEdgeMeshScalarDataVTKPolyDataWriter.h
  • itkQuadEdgeMeshScalarDataVTKPolyDataWriter.txx

Shall we remove the following in favor of Mesh IO ?

  • itkVTKPolyDataReader.h
  • itkVTKPolyDataReader.txx
  • itkVTKPolyDataWriter.h
  • itkVTKPolyDataWriter.txx

Moved to Testing/Code/Algorithms

  • itkQuadEdgeMeshCleanFilterTest.cxx
  • itkQuadEdgeMeshDelaunayConformingFilterTest.cxx
  • itkQuadEdgeMeshGaussianCurvatureTest.cxx
  • itkQuadEdgeMeshLinearParameterizationTest.cxx
  • itkQuadEdgeMeshMaxCurvatureTest.cxx
  • itkQuadEdgeMeshMeanCurvatureTest.cxx
  • itkQuadEdgeMeshMinCurvatureTest.cxx
  • itkQuadEdgeMeshNormalFilterTest.cxx
  • itkQuadEdgeMeshQuadricDecimationTest.cxx
  • itkQuadEdgeMeshSmoothingTest.cxx
  • itkQuadEdgeMeshSquaredEdgeLengthDecimationTest.cxx

Moved to Testing/Code/Common

Here some of the tests are duplicate of itkMesh tests. We have to double check that those stay together (i.e check that common is the right place).

  • itkAutomaticTopologyQuadEdgeMeshSourceTest.cxx
  • itkBinaryMask3DQuadEdgeMeshSourceTest.cxx
  • itkCrossHelperTest.cxx
  • itkDynamicQuadEdgeMeshTest.cxx
  • itkGeometricalQuadEdgeTest1.cxx
  • itkPriorityQueueTest.cxx
  • itkQuadEdgeMeshAddFaceTest1.cxx
  • itkQuadEdgeMeshAddFaceTest2.cxx
  • itkQuadEdgeMeshBasicLayerTest.cxx
  • itkQuadEdgeMeshCellInterfaceTest.cxx
  • itkQuadEdgeMeshCountingCellsTest.cxx
  • itkQuadEdgeMeshDeleteEdgeTest.cxx
  • itkQuadEdgeMeshDeletePointAndReorderIDsTest.cxx
  • itkQuadEdgeMeshEulerOperatorCreateCenterVertexTest.cxx
  • itkQuadEdgeMeshEulerOperatorDeleteCenterVertexTest.cxx
  • itkQuadEdgeMeshEulerOperatorFlipTest.cxx
  • itkQuadEdgeMeshEulerOperatorJoinFacetTest.cxx
  • itkQuadEdgeMeshEulerOperatorJoinVertexTest.cxx
  • itkQuadEdgeMeshEulerOperatorSplitEdgeTest.cxx
  • itkQuadEdgeMeshEulerOperatorSplitFaceTest.cxx
  • itkQuadEdgeMeshEulerOperatorSplitVertexTest.cxx
  • itkQuadEdgeMeshEulerOperatorsTestHelper.h
  • itkQuadEdgeMeshFrontIteratorTest.cxx
  • itkQuadEdgeMeshIteratorTest.cxx
  • itkQuadEdgem_NoPointTest.cxx -> itkQuadEdgeMeshNoPointConstTest.cxx
  • itkQuadEdgeMeshPointTest1.cxx
  • itkQuadEdgeMeshPolygonCellTest.cxx
  • itkQuadEdgeMeshTest1.cxx
  • itkQuadEdgeMeshTest2.cxx
  • itkQuadEdgeMeshTest3.cxx
  • itkQuadEdgeTest1.cxx
  • itkRegularSphereQuadEdgeMeshSourceTest.cxx
  • itkTriangleHelperTest.cxx

Move to Testing/Code/IO

  • itkQuadEdgeMeshScalarDataVTKPolyDataWriterTest1.cxx
  • itkVTKPolyDataIOQuadEdgeMeshTest.cxx
  • itkVTKPolyDataReaderQuadEdgeMeshTest.cxx
  • itkVTKPolyDataReaderTest.cxx
  • itkVTKPolyDataWriterTest.cxx
  • itkVTKPolyDataWriterTest2.cxx

Modified code

  • Code/Common/CMakeLists.txt
  • Code/Review/CMakeLists.txt
  • Testing/Code/Common/CMakeLists.txt
  • Testing/Code/Review/CMakeLists.txt
  • Testing/Code/Review/itkReviewTests.cxx
  • Testing/Code/Review/itkReviewTests2.cxx