View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0009639

CMake

public

2009-10-02 04:24

2011-06-06 18:25

Reporter

Claudio Bley

Assigned To

Bill Hoffman

Priority

normal

Severity

tweak

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

CMake 2.8.4

Summary

0009639: gcc "deprecated conversion from string constant to char*" warnings

Description

I don't like annoying warnings like these:

------------------------------------------------------------------------------
c:/build/CMake/Source/kwsys/SystemTools.cxx: In static member function 'static bool cmsys::SystemTools::WriteRegistryValue(const char*, const char*, cmsys::SystemTools::KeyWOW64)':
c:/build/CMake/Source/kwsys/SystemTools.cxx:740: warning: deprecated conversion from string constant to 'CHAR*'
[ 2%] Building CXX object Source/kwsys/CMakeFiles/cmsys.dir/Registry.obj
c:/build/CMake/Source/kwsys/Registry.cxx: In member function 'virtual bool cmsys::RegistryHelper::Open(const char*, const char*, int)':
c:/build/CMake/Source/kwsys/Registry.cxx:406: warning: deprecated conversion from string constant to 'CHAR*'
...
c:/build/CMake/Source/cmGlobalVisualStudioGenerator.cxx: In function 'void WriteVSMacrosFileRegistryEntry(const std::string&, const std::string&, const std::string&)':
c:/build/CMake/Source/cmGlobalVisualStudioGenerator.cxx:622: warning: deprecated conversion from string constant to 'CHAR*'
[ 46%] Building CXX object Source/CMakeFiles/CMakeLib.dir/cmWin32ProcessExecution.obj
c:/build/CMake/Source/cmWin32ProcessExecution.cxx: In function 'BOOL RealPopenCreateProcess(const char*, const char*, const char*, void*, void*, void*, void**, bool, std::string&)':
c:/build/CMake/Source/cmWin32ProcessExecution.cxx:287: warning: deprecated conversion from string constant to 'char*'
------------------------------------------------------------------------------

The attached patch fixes these warnings.

Tags

No tags attached.

Attached Files

cmake_string_conversion_warning.diff [^] (2,756 bytes) 2009-10-02 04:24 [Show Content] [Hide Content]

Index: Source/cmGlobalVisualStudioGenerator.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmGlobalVisualStudioGenerator.cxx,v
retrieving revision 1.20
diff -u -r1.20 cmGlobalVisualStudioGenerator.cxx
--- Source/cmGlobalVisualStudioGenerator.cxx	1 Oct 2009 14:27:02 -0000	1.20
+++ Source/cmGlobalVisualStudioGenerator.cxx	2 Oct 2009 07:39:33 -0000
@@ -618,7 +618,7 @@
     {
     // Create the subkey and set the values of interest:
     HKEY hsubkey = NULL;
-    result = RegCreateKeyEx(hkey, nextAvailableSubKeyName.c_str(), 0, "", 0,
+    result = RegCreateKeyEx(hkey, nextAvailableSubKeyName.c_str(), 0, NULL, 0,
       KEY_READ|KEY_WRITE, 0, &hsubkey, 0);
     if (ERROR_SUCCESS == result)
       {
Index: Source/cmWin32ProcessExecution.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmWin32ProcessExecution.cxx,v
retrieving revision 1.34
diff -u -r1.34 cmWin32ProcessExecution.cxx
--- Source/cmWin32ProcessExecution.cxx	28 Sep 2009 15:42:49 -0000	1.34
+++ Source/cmWin32ProcessExecution.cxx	2 Oct 2009 07:41:40 -0000
@@ -284,7 +284,8 @@
 {
   PROCESS_INFORMATION piProcInfo;
   STARTUPINFO siStartInfo;
-  char *s1=0,*s2=0, *s3 = " /c ";
+  char *s1=0,*s2=0;
+  const char *s3 = " /c ";
   int i = GetEnvironmentVariable("COMSPEC",NULL,0);
   if (i)
     {
Index: Source/kwsys/Registry.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/kwsys/Registry.cxx,v
retrieving revision 1.25
diff -u -r1.25 Registry.cxx
--- Source/kwsys/Registry.cxx	28 Sep 2009 15:37:22 -0000	1.25
+++ Source/kwsys/Registry.cxx	2 Oct 2009 07:33:54 -0000
@@ -402,7 +402,7 @@
     else
       {
       res = ( RegCreateKeyEx(scope, str.str().c_str(),
-          0, "", REG_OPTION_NON_VOLATILE, KEY_READ|KEY_WRITE,
+          0, NULL, REG_OPTION_NON_VOLATILE, KEY_READ|KEY_WRITE,
           NULL, &this->HKey, &dwDummy) == ERROR_SUCCESS );
       }
     if ( res != 0 )
Index: Source/kwsys/SystemTools.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/kwsys/SystemTools.cxx,v
retrieving revision 1.253
diff -u -r1.253 SystemTools.cxx
--- Source/kwsys/SystemTools.cxx	28 Sep 2009 15:37:23 -0000	1.253
+++ Source/kwsys/SystemTools.cxx	2 Oct 2009 07:33:59 -0000
@@ -732,7 +732,7 @@
   if(RegCreateKeyEx(primaryKey, 
                     second.c_str(), 
                     0, 
-                    "",
+                    NULL,
                     REG_OPTION_NON_VOLATILE,
                     SystemToolsMakeRegistryMode(KEY_WRITE, view),
                     NULL,

Relationships

Notes
(0026689) David Cole (manager) 2011-06-06 18:25	Closing resolved issues that have not been updated in more than 3 months.

Issue History
Date Modified	Username	Field	Change
2009-10-02 04:24	Claudio Bley	New Issue
2009-10-02 04:24	Claudio Bley	File Added: cmake_string_conversion_warning.diff
2010-12-15 09:07	David Cole	Status	new => assigned
2010-12-15 09:07	David Cole	Assigned To	=> Bill Hoffman
2011-02-03 18:23	David Cole	Status	assigned => resolved
2011-02-03 18:23	David Cole	Fixed in Version	=> CMake 2.8.4
2011-02-03 18:23	David Cole	Resolution	open => fixed
2011-06-06 18:25	David Cole	Status	resolved => closed
2011-06-06 18:25	David Cole	Note Added: 0026689