View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0016030

CMake

public

2016-03-22 12:10

2016-06-10 14:21

Reporter

Gregor Jasny

Assigned To

Gregor Jasny

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake 3.4

Target Version

CMake 3.5.2

Fixed in Version

CMake 3.5.2

Summary

0016030: CMAKE_ASM_NASM_COMPILE_OBJECT lacks <INCLUDES>

Description

Starting with CMake 3.4 the ASM_NASM language does not pass forward include_directories(XYZ) to the nasm compiler line.

output of the test case:

-- <CMAKE_ASM_NASM_COMPILER> <FLAGS> -f elf64 -o <OBJECT> <SOURCE>
[ 66%] Building ASM_NASM object CMakeFiles/vpxCodec.dir/foo.asm.o
/usr/bin/yasm   -f elf64 -o CMakeFiles/vpxCodec.dir/foo.asm.o /uhome/gjasny/src/cmake-yasm-bug/foo.asm

As far as I can see <INCLUDES> is missing for other assemblers as well.

Steps To Reproduce

cmake_minimum_required(VERSION 3.3 FATAL_ERROR)

project(Foo)

find_program(COLYASM_EXECUTABLE NAMES yasm)
set(CMAKE_ASM_NASM_COMPILER ${COLYASM_EXECUTABLE})
enable_language(ASM_NASM)

include_directories(build/x86_64-linux-gcc)

add_library(vpxCodec STATIC bar.cpp foo.asm)

message(STATUS "${CMAKE_ASM_NASM_COMPILE_OBJECT}")

Tags

No tags attached.

Attached Files

Relationships

Notes
(0040778) Gregor Jasny (developer) 2016-03-31 12:51	topic asm-includes got merged into master with 90f24f016e93d18f6a244b39fd21c68355bdbe48

(0040779) Gregor Jasny (developer) 2016-03-31 12:52	Brad, this is a regression introduced with 3.4. Could you please merge into release?

(0040782) Brad King (manager) 2016-03-31 13:23	I've backported the commit as: ASM: Add missing <INCLUDES> placeholder for "compile" rules https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=677c091b [^] and queued it for merge to 'release' for 3.5.2.

(0041207) Kitware Robot (administrator) 2016-06-10 14:21	This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2016-03-22 12:10	Gregor Jasny	New Issue
2016-03-25 18:15	Gregor Jasny	Assigned To	=> Gregor Jasny
2016-03-25 18:15	Gregor Jasny	Status	new => assigned
2016-03-31 12:51	Gregor Jasny	Note Added: 0040778
2016-03-31 12:52	Gregor Jasny	Note Added: 0040779
2016-03-31 13:23	Brad King	Note Added: 0040782
2016-03-31 13:26	Brad King	Status	assigned => resolved
2016-03-31 13:26	Brad King	Resolution	open => fixed
2016-03-31 13:26	Brad King	Fixed in Version	=> CMake 3.5.2
2016-03-31 13:26	Brad King	Target Version	=> CMake 3.5.2
2016-06-10 14:21	Kitware Robot	Note Added: 0041207
2016-06-10 14:21	Kitware Robot	Status	resolved => closed