View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0015531 | CMake | Modules | public | 2015-04-24 05:12 | 2015-11-02 09:13 | ||||
Reporter | Bjoern Thiel | ||||||||
Assigned To | |||||||||
Priority | high | Severity | major | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | Windows | OS Version | ||||||
Product Version | |||||||||
Target Version | CMake 3.3 | Fixed in Version | CMake 3.3 | ||||||
Summary | 0015531: InstallRequiredSystemLibraries misses MBCS MFC libraries | ||||||||
Description | if("${v}" LESS 12 OR EXISTS "${MSVC${v}_MFC_DIR}/mfc${v}0d.dll") may be false for version >= 12 as ${MSVC${v}_MFC_DIR} is not always set correctly at that time. | ||||||||
Additional Information | I patched it replacing the if(mbcs) with if("${v}" LESS 12 OR EXISTS "${MSVC${v}_MFC_DIR}/mfc${v}0d.dll") and if("${v}" LESS 12 OR EXISTS "${MSVC${v}_MFC_DIR}/mfc${v}0.dll") and erasing the set(mbcs ... stuff. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | |||||||||
Relationships | ||||||
|
Relationships |
Notes | |
(0038613) Brad King (manager) 2015-04-27 10:01 |
Related change made in CMake 3.0: InstallRequiredSystemLibraries: MBCS MFC is optional on VS 12 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c0a6646d [^] |
(0038614) Brad King (manager) 2015-04-27 10:13 |
Change applied, thanks: InstallRequiredSystemLibraries: Fix MBCS MFC detection http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ff183986 [^] |
(0039790) Robert Maynard (manager) 2015-11-02 09:13 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2015-04-24 05:12 | Bjoern Thiel | New Issue | |
2015-04-27 10:01 | Brad King | Relationship added | related to 0014903 |
2015-04-27 10:01 | Brad King | Note Added: 0038613 | |
2015-04-27 10:13 | Brad King | Note Added: 0038614 | |
2015-04-27 10:13 | Brad King | Severity | crash => major |
2015-04-27 10:13 | Brad King | Status | new => resolved |
2015-04-27 10:13 | Brad King | Resolution | open => fixed |
2015-04-27 10:13 | Brad King | Fixed in Version | => CMake 3.3 |
2015-04-27 10:13 | Brad King | Target Version | => CMake 3.3 |
2015-11-02 09:13 | Robert Maynard | Note Added: 0039790 | |
2015-11-02 09:13 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |