View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0015518CMakeCMakepublic2015-04-17 04:032015-11-02 09:13
ReporterPaul "TBBle" Hampson 
Assigned ToBrad King 
PrioritynormalSeveritytextReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 3.2.2 
Target VersionCMake 3.3Fixed in VersionCMake 3.3 
Summary0015518: PDB_NAME documentation doesn't mention that it uses OUTPUT_NAME if defined
DescriptionThe PDB_NAME documentation has always stated:

This property specifies the base name for the debug symbols file. If not set, the logical target name is used by default.

(since 2.8.10 when it was introduced: http://www.cmake.org/cmake/help/v2.8.10/cmake.html#prop_tgt:PDB_NAME [^] up to 3.2: http://www.cmake.org/cmake/help/v3.2/prop_tgt/PDB_NAME.html [^])

However, examining the original commit (http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3f60dbf1#patch7 [^]) shows that it actually uses cmTarget::GetFullNameInternal, which honours OUTPUT_NAME.

This is also true of the _<CONFIG> variants.

It's correct behaviour, so it's just the documentation that needs updating, hence the given Severity.
Steps To Reproduce* Create a target using OUTPUT_NAME that differs from the logical target name.
* Generate a Visual Studio solution
* Note that the PDB generated is OUTPUT_NAME.pdb, not logicalName.pdb.
Additional InformationThe unit tests don't cover this case, but I expect that a unit test setting OUTPUT_NAME and PDB_NAME would trivially demonstrate the actual behaviour.

I assume the text was just copied from the OUTPUT_NAME documentation, which is the only other place that this text appears, and it makes sense there.
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0038538)
Brad King (manager)
2015-04-17 11:06

 Thanks for pointing out this omission! Fixed:

 Help: Clarify PDB_NAME fallback behavior
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=164f1df2 [^]
(0039780)
Robert Maynard (manager)
2015-11-02 09:13

 Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2015-04-17 04:03 Paul "TBBle" Hampson New Issue
2015-04-17 11:06 Brad King Note Added: 0038538
2015-04-17 11:06 Brad King Assigned To => Brad King
2015-04-17 11:06 Brad King Status new => resolved
2015-04-17 11:06 Brad King Resolution open => fixed
2015-04-17 11:06 Brad King Fixed in Version => CMake 3.3
2015-04-17 11:06 Brad King Target Version => CMake 3.3
2015-11-02 09:13 Robert Maynard Note Added: 0039780
2015-11-02 09:13 Robert Maynard Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team