| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0015268 | CMake | Modules | public | 2014-11-28 11:19 | 2015-05-04 09:05 | ||||
| Reporter | GreatEmerald | ||||||||
| Assigned To | Brad King | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | Linux | OS | openSUSE | OS Version | 13.1 | ||||
| Product Version | CMake 3.0.2 | ||||||||
| Target Version | CMake 3.2 | Fixed in Version | CMake 3.2 | ||||||
| Summary | 0015268: FindOpenGL.cmake incorrectly depends on X11 on Linux | ||||||||
| Description | Currently on Linux the FindOpenGL.cmake module includes FindX11.cmake. That is not right, because there is little reason to ever link against X11 explicitly, and the checks will outright fail on Wayland. Furthermore, having FindX11 included adds quite a bit more complexity to builds (takes more time, doesn't work if you don't have a C compiler enabled etc.), and projects can always use find_package(X11) manually if need be. | ||||||||
| Additional Information | It seems that the blanket check for X11 was added back in 2002, and didn't change much since: https://github.com/Kitware/CMake/commit/079e8469abd4a2b404fd460ff41012e8d8b6fd1d [^] | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0037326) Brad King (manager) 2014-12-01 11:09 |
Thanks. I think the only way to find out if anything really needed this to remove it: FindOpenGL: Drop explicit dependency on X11 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d051cbda [^] |
|
(0038681) Robert Maynard (manager) 2015-05-04 09:05 |
Closing resolved issues that have not been updated in more than 4 months. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2014-11-28 11:19 | GreatEmerald | New Issue | |
| 2014-12-01 11:09 | Brad King | Note Added: 0037326 | |
| 2014-12-01 11:09 | Brad King | Assigned To | => Brad King |
| 2014-12-01 11:09 | Brad King | Status | new => resolved |
| 2014-12-01 11:09 | Brad King | Resolution | open => fixed |
| 2014-12-01 11:09 | Brad King | Fixed in Version | => CMake 3.2 |
| 2014-12-01 11:09 | Brad King | Target Version | => CMake 3.2 |
| 2015-05-04 09:05 | Robert Maynard | Note Added: 0038681 | |
| 2015-05-04 09:05 | Robert Maynard | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |