View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014804 | CMake | QtDialog | public | 2014-03-12 06:41 | 2014-10-06 10:32 | ||||
Reporter | Peter Kuemmel | ||||||||
Assigned To | Brad King | ||||||||
Priority | high | Severity | crash | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | CMake 3.1 | Fixed in Version | CMake 3.1 | ||||||
Summary | 0014804: Crash in QCMake.cxx | ||||||||
Description | QCMake.cxx line 120, extraGen is NULL: if ( itm.Find("CMAKE_GENERATOR")) { const char* extraGen = cachem->GetCacheValue("CMAKE_EXTRA_GENERATOR"); std::string curGen = cmExternalMakefileProjectGenerator:: CreateFullGeneratorName(itm.GetValue(), extraGen); this->setGenerator(QString::fromLocal8Bit(curGen.c_str())); } Checking for CMAKE_GENERATOR and then getting CMAKE_EXTRA_GENERATOR? | ||||||||
Steps To Reproduce | Generator "Visual Studio 12 2013 Win64" | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-cmake-gui-Fix-handling-of-missing-CMAKE_EXTRA_GENERA.patch [^] (1,333 bytes) 2014-03-12 09:56 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0035388) Brad King (manager) 2014-03-12 09:48 |
It looks like that block was introduced way back in 2007: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cfa723d4#patch4 [^] but the NULL was tolerated until the recent stringapi changes: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1a1b737c#patch4 [^] |
(0035389) Brad King (manager) 2014-03-12 09:56 |
Please try 0001-cmake-gui-Fix-handling-of-missing-CMAKE_EXTRA_GENERA.patch |
(0035391) Brad King (manager) 2014-03-12 14:52 |
Re 0014804:0035389: I've applied the patch here: cmake-gui: Fix handling of missing CMAKE_EXTRA_GENERATOR http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ae32622b [^] However, I was not able to reproduce this crash on Linux so please test to make sure it is the only problem. |
(0036940) Robert Maynard (manager) 2014-10-06 10:32 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2014-03-12 06:41 | Peter Kuemmel | New Issue | |
2014-03-12 09:48 | Brad King | Note Added: 0035388 | |
2014-03-12 09:56 | Brad King | File Added: 0001-cmake-gui-Fix-handling-of-missing-CMAKE_EXTRA_GENERA.patch | |
2014-03-12 09:56 | Brad King | Note Added: 0035389 | |
2014-03-12 09:57 | Brad King | Product Version | CMake 3.0 => |
2014-03-12 09:57 | Brad King | Target Version | => CMake 3.1 |
2014-03-12 14:52 | Brad King | Note Added: 0035391 | |
2014-03-13 16:41 | Brad King | Assigned To | => Brad King |
2014-03-13 16:41 | Brad King | Status | new => resolved |
2014-03-13 16:41 | Brad King | Resolution | open => fixed |
2014-03-13 16:41 | Brad King | Fixed in Version | => CMake 3.1 |
2014-10-06 10:32 | Robert Maynard | Note Added: 0036940 | |
2014-10-06 10:32 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |