View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014775CMakeModulespublic2014-02-26 07:462014-10-06 10:32
ReporterNikolay Orliuk 
Assigned ToBrad King 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.12.2 
Target VersionCMake 3.1Fixed in VersionCMake 3.1 
Summary0014775: GTEST_ADD_TESTS from FindGTest may find sources automatically
DescriptionWe can use get_target_property() for SOURCES property of executable.

See attached patch.
TagsNo tags attached.
Attached Filespatch file icon 0002-FindGTest-detect-sources-automatically.patch [^] (1,749 bytes) 2014-02-26 07:48 [Show Content]
patch file icon 0001-FindGTest-Optionally-detect-sources-automatically-14.patch [^] (1,901 bytes) 2014-02-26 09:21 [Show Content]

 Relationships

  Notes
(0035205)
Stephen Kelly (developer)
2014-02-26 08:30

It would be better to create an IMPORTED INTERFACE target for it and populate the INTERFACE_SOURCES property. That won't be possible until the INTERFACE_SOURCES property feature is complete.
(0035206)
Stephen Kelly (developer)
2014-02-26 09:02

Hmm, my comment above is not really relevant. I didn't understand the issue before commenting.
(0035207)
Brad King (manager)
2014-02-26 09:22

I've revised the patch slightly as

 0001-FindGTest-Optionally-detect-sources-automatically-14.patch

Please try this version.
(0035212)
Nikolay Orliuk (reporter)
2014-02-26 23:02

Brad King, yep that works too.
(0035213)
Brad King (manager)
2014-02-27 08:55

Applied, thanks:

 FindGTest: Optionally detect sources automatically
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c50325b8 [^]
(0036919)
Robert Maynard (manager)
2014-10-06 10:32

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2014-02-26 07:46 Nikolay Orliuk New Issue
2014-02-26 07:48 Nikolay Orliuk File Added: 0002-FindGTest-detect-sources-automatically.patch
2014-02-26 08:30 Stephen Kelly Note Added: 0035205
2014-02-26 09:02 Stephen Kelly Note Added: 0035206
2014-02-26 09:21 Brad King File Added: 0001-FindGTest-Optionally-detect-sources-automatically-14.patch
2014-02-26 09:22 Brad King Note Added: 0035207
2014-02-26 23:02 Nikolay Orliuk Note Added: 0035212
2014-02-27 08:55 Brad King Note Added: 0035213
2014-02-27 08:55 Brad King Assigned To => Brad King
2014-02-27 08:55 Brad King Status new => resolved
2014-02-27 08:55 Brad King Resolution open => fixed
2014-02-27 08:55 Brad King Fixed in Version => CMake 3.1
2014-02-27 08:55 Brad King Target Version => CMake 3.1
2014-10-06 10:32 Robert Maynard Note Added: 0036919
2014-10-06 10:32 Robert Maynard Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team