Attached Files | 0001-BUG-Fix-conditional-comments-in-generated-html-markd.patch [^] (4,348 bytes) 2013-10-25 11:39 [Show Content] [Hide Content]From c460e5095ac464dd37e82c4155f127b60ad2aa74 Mon Sep 17 00:00:00 2001
From: Igor Murzov <e-mail@date.by>
Date: Tue, 22 Oct 2013 16:02:41 +0400
Subject: [PATCH 1/7] BUG: Fix conditional comments in generated html markdown
---
createProject.xsl | 4 ++--
manageBuildGroup.xsl | 4 ++--
manageProjectRoles.xsl | 4 ++--
manageSubproject.xsl | 4 ++--
subscribeProject.xsl | 6 +++---
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/createProject.xsl b/createProject.xsl
index 406b13b..03b437e 100644
--- a/createProject.xsl
+++ b/createProject.xsl
@@ -28,9 +28,9 @@
<xsl:call-template name="headscripts_local"/>
</xsl:if>
- <xsl:comment><![CDATA[[if IE]></xsl:comment>
+ <xsl:comment><![CDATA[[if IE]>
<link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
- <xsl:comment><![ endif]]></xsl:comment>
+ <![endif]]]></xsl:comment>
<script type="text/javascript" src="javascript/jquery-1.6.2.js"></script>
<script type="text/javascript" src="javascript/ui.tabs.js"></script>
<script type="text/javascript" src="javascript/cdashCreateProject.js"></script>
diff --git a/manageBuildGroup.xsl b/manageBuildGroup.xsl
index be44bd4..232aa30 100644
--- a/manageBuildGroup.xsl
+++ b/manageBuildGroup.xsl
@@ -21,9 +21,9 @@
<link rel="StyleSheet" type="text/css">
<xsl:attribute name="href"><xsl:value-of select="cdash/cssfile"/></xsl:attribute>
</link>
- <xsl:comment><![CDATA[[if IE]></xsl:comment>
+ <xsl:comment><![CDATA[[if IE]>
<link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
- <xsl:comment><![ endif]]></xsl:comment>
+ <![endif]]]></xsl:comment>
<script src="javascript/jquery-1.6.2.js"></script>
<script type="text/javascript" src="javascript/ui.tabs.js"></script>
diff --git a/manageProjectRoles.xsl b/manageProjectRoles.xsl
index 38f376c..628c768 100644
--- a/manageProjectRoles.xsl
+++ b/manageProjectRoles.xsl
@@ -21,9 +21,9 @@
<link rel="StyleSheet" type="text/css">
<xsl:attribute name="href"><xsl:value-of select="cdash/cssfile"/></xsl:attribute>
</link>
- <xsl:comment><![CDATA[[if IE]></xsl:comment>
+ <xsl:comment><![CDATA[[if IE]>
<link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
- <xsl:comment><![ endif]]></xsl:comment>
+ <![endif]]]></xsl:comment>
<!-- Include project roles -->
<script src="javascript/jquery-1.6.2.js"></script>
<script src="javascript/cdashProjectRole.js"></script>
diff --git a/manageSubproject.xsl b/manageSubproject.xsl
index 108f07a..d26eea0 100644
--- a/manageSubproject.xsl
+++ b/manageSubproject.xsl
@@ -21,9 +21,9 @@
<link rel="StyleSheet" type="text/css">
<xsl:attribute name="href"><xsl:value-of select="cdash/cssfile"/></xsl:attribute>
</link>
- <xsl:comment><![CDATA[[if IE]></xsl:comment>
+ <xsl:comment><![CDATA[[if IE]>
<link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
- <xsl:comment><![ endif]]></xsl:comment>
+ <![endif]]]></xsl:comment>
<script src="javascript/jquery-1.6.2.js"></script>
<script type="text/javascript" src="javascript/ui.tabs.js"></script>
</head>
diff --git a/subscribeProject.xsl b/subscribeProject.xsl
index ea7e2ab..44fd36a 100644
--- a/subscribeProject.xsl
+++ b/subscribeProject.xsl
@@ -19,9 +19,9 @@
<link rel="StyleSheet" type="text/css">
<xsl:attribute name="href"><xsl:value-of select="cdash/cssfile"/></xsl:attribute>
</link>
- <xsl:comment><![CDATA[[if IE]></xsl:comment>
- <link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
- <xsl:comment><![ endif]]></xsl:comment>
+ <xsl:comment><![CDATA[[if IE]>
+ <link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
+ <![endif]]]></xsl:comment>
<xsl:call-template name="headscripts"/>
<script type="text/javascript">
function saveChanges()
--
1.7.9.5
0002-PEDANTIC-Correctly-set-selected-checked-and-multiple.patch [^] (16,595 bytes) 2013-10-25 11:40 [Show Content] [Hide Content]From 84fb67e2f912428e6439341a703c4d61b8b4f346 Mon Sep 17 00:00:00 2001
From: Igor Murzov <e-mail@date.by>
Date: Thu, 24 Oct 2013 21:59:42 +0400
Subject: [PATCH 2/7] PEDANTIC: Correctly set 'selected', 'checked' and
'multiple' html attributes
---
createProject.xsl | 2 +-
manageBuildGroup.xsl | 10 +++++-----
manageClient.xsl | 32 ++++++++++++++++----------------
manageCoverage.xsl | 16 ++++++++--------
manageProjectRoles.xsl | 2 +-
subscribeProject.xsl | 8 ++++----
6 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/createProject.xsl b/createProject.xsl
index 03b437e..f9d39a4 100644
--- a/createProject.xsl
+++ b/createProject.xsl
@@ -500,7 +500,7 @@
<xsl:attribute name="value"><xsl:value-of
select="value" /></xsl:attribute>
<xsl:if test="selected=1">
- <xsl:attribute name="selected">true</xsl:attribute>
+ <xsl:attribute name="selected">selected</xsl:attribute>
</xsl:if>
<xsl:value-of select="description" />
</option>
diff --git a/manageBuildGroup.xsl b/manageBuildGroup.xsl
index 232aa30..0dc791f 100644
--- a/manageBuildGroup.xsl
+++ b/manageBuildGroup.xsl
@@ -150,28 +150,28 @@ project page</a>
<br/>
<input name="summaryEmail" onclick="form.submit();" type="checkbox" value="1">
<xsl:if test="summaryemail=1">
- <xsl:attribute name="checked">1</xsl:attribute>
+ <xsl:attribute name="checked">checked</xsl:attribute>
</xsl:if>
</input>
Summary email
<br/>
<input name="summaryEmail" onclick="form.submit();" type="checkbox" value="2">
<xsl:if test="summaryemail=2">
- <xsl:attribute name="checked">1</xsl:attribute>
+ <xsl:attribute name="checked">checked</xsl:attribute>
</xsl:if>
</input>
No email
<br/>
<input name="emailCommitters" onclick="form.submit();" type="checkbox" value="1">
<xsl:if test="emailcommitters != 0">
- <xsl:attribute name="checked">1</xsl:attribute>
+ <xsl:attribute name="checked">checked</xsl:attribute>
</xsl:if>
</input>
Email committers
<br/>
<input name="includeInSummary" onclick="form.submit();" type="checkbox" value="1">
<xsl:if test="includeinsummary=1">
- <xsl:attribute name="checked">1</xsl:attribute>
+ <xsl:attribute name="checked">checked</xsl:attribute>
</xsl:if>
</input>
Included in subproject summary
@@ -243,7 +243,7 @@ project page</a>
<tr>
<td><div align="right"></div></td>
<td>
- <select name="movebuilds[]" size="15" multiple="true" id="movebuilds">
+ <select name="movebuilds[]" size="15" multiple="multiple" id="movebuilds">
<xsl:for-each select="cdash/currentbuild">
<option>
<xsl:attribute name="value"><xsl:value-of select="id"/></xsl:attribute>
diff --git a/manageClient.xsl b/manageClient.xsl
index 6660bc4..c5bdc15 100644
--- a/manageClient.xsl
+++ b/manageClient.xsl
@@ -68,7 +68,7 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<xsl:for-each select="/cdash/project/repository">
<option>
<xsl:attribute name="value"><xsl:value-of select="url"/></xsl:attribute>
- <xsl:if test="selected=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>
+ <xsl:if test="selected=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>
<xsl:value-of select="url"/>
</option>
</xsl:for-each>
@@ -118,11 +118,11 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<tr>
<td valign="top" align="right"><b>Operating System:</b><br/><a href="#" onclick="return clearOS();">[clear all]</a></td>
<td>
- <select multiple="true" name="system[]" id="system_select" onchange="checkSystem();">
+ <select multiple="multiple" name="system[]" id="system_select" onchange="checkSystem();">
<xsl:for-each select="/cdash/os">
<option>
<xsl:attribute name="value"><xsl:value-of select="id" /></xsl:attribute>
- <xsl:if test="selected=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>
+ <xsl:if test="selected=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>
<xsl:value-of select="name"/>
</option>
</xsl:for-each>
@@ -132,11 +132,11 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<tr>
<td valign="top" align="right"><b>Compiler:</b><br/><a href="#" onclick="return clearCompiler();">[clear all]</a></td>
<td>
- <select multiple="true" name="compiler[]" id="compiler_select" onchange="checkSystem();">
+ <select multiple="multiple" name="compiler[]" id="compiler_select" onchange="checkSystem();">
<xsl:for-each select="/cdash/compiler">
<option>
<xsl:attribute name="value"><xsl:value-of select="id" /></xsl:attribute>
- <xsl:if test="selected=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>
+ <xsl:if test="selected=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>
<xsl:value-of select="name"/>
</option>
</xsl:for-each>
@@ -146,11 +146,11 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<tr>
<td valign="top" align="right"><b>CMake:</b><br/><a href="#" onclick="return clearCMake()">[clear all]</a></td>
<td>
- <select multiple="true" name="cmake[]" id="cmake_select" onchange="checkSystem();">
+ <select multiple="multiple" name="cmake[]" id="cmake_select" onchange="checkSystem();">
<xsl:for-each select="/cdash/cmake">
<option>
<xsl:attribute name="value"><xsl:value-of select="id" /></xsl:attribute>
- <xsl:if test="selected=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>
+ <xsl:if test="selected=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>
<xsl:value-of select="version"/>
</option>
</xsl:for-each>
@@ -160,11 +160,11 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<tr>
<td valign="top" align="right"><b>Libraries:</b><br/><a href="#" onclick="return clearLibrary()">[clear all]</a></td>
<td>
- <select multiple="true" name="library[]" id="library_select" onchange="checkSystem();">
+ <select multiple="multiple" name="library[]" id="library_select" onchange="checkSystem();">
<xsl:for-each select="/cdash/library">
<option>
<xsl:attribute name="value"><xsl:value-of select="id" /></xsl:attribute>
- <xsl:if test="selected=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>
+ <xsl:if test="selected=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>
<xsl:value-of select="name"/>
</option>
</xsl:for-each>
@@ -174,12 +174,12 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<tr>
<td valign="top" align="right"><b>Site:</b><br/><a href="#" onclick="return clearSite()">[clear all]</a></td>
<td>
- <select multiple="true" name="site[]" id="site_select" onchange="checkSystem();">
+ <select multiple="multiple" name="site[]" id="site_select" onchange="checkSystem();">
<xsl:for-each select="/cdash/site">
<option>
<xsl:if test="availablenow=0"><xsl:attribute name="style">color:red</xsl:attribute></xsl:if>
<xsl:attribute name="value"><xsl:value-of select="id" /></xsl:attribute>
- <xsl:if test="selected=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>
+ <xsl:if test="selected=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>
<xsl:value-of select="name"/>
</option>
</xsl:for-each>
@@ -201,9 +201,9 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<tr>
<td align="right" valign="top"><b>Type:</b></td>
<td><select name="type">
- <option value="0"><xsl:if test="/cdash/type=0"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Experimental</option>
- <option value="1"><xsl:if test="/cdash/type=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Nightly</option>
- <option value="2"><xsl:if test="/cdash/type=2"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Continuous</option>
+ <option value="0"><xsl:if test="/cdash/type=0"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Experimental</option>
+ <option value="1"><xsl:if test="/cdash/type=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Nightly</option>
+ <option value="2"><xsl:if test="/cdash/type=2"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Continuous</option>
</select>
</td>
</tr>
@@ -216,7 +216,7 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<xsl:for-each select="/cdash/buildconfiguration">
<option>
<xsl:attribute name="value"><xsl:value-of select="id"/></xsl:attribute>
- <xsl:if test="selected=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>
+ <xsl:if test="selected=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>
<xsl:value-of select="name"/>
</option>
</xsl:for-each>
@@ -253,7 +253,7 @@ Visit <a href="http://public.kitware.com/Wiki/CDash:Build_Management">the wiki p
<td align="right" valign="top"><b>Enable:</b></td>
<td><input name="enable" type="checkbox">
<xsl:if test="/cdash/enable=1">
- <xsl:attribute name="checked">true</xsl:attribute>
+ <xsl:attribute name="checked">checked</xsl:attribute>
</xsl:if>
</input>
</td>
diff --git a/manageCoverage.xsl b/manageCoverage.xsl
index 7cfff5d..99f355a 100644
--- a/manageCoverage.xsl
+++ b/manageCoverage.xsl
@@ -126,10 +126,10 @@
<xsl:attribute name="action">manageCoverage.php?projectid=<xsl:value-of select="/cdash/project/id"/>&buildid=<xsl:value-of select="/cdash/project/buildid"/></xsl:attribute>
<select onchange="this.form.submit();" name="prioritySelection">
<option value="0">Choose Priority</option>
- <option value="1"><xsl:if test="priority=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Low</option>
- <option value="2"><xsl:if test="priority=2"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Medium</option>
- <option value="3"><xsl:if test="priority=3"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>High</option>
- <option value="4"><xsl:if test="priority=4"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Urgent</option>
+ <option value="1"><xsl:if test="priority=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Low</option>
+ <option value="2"><xsl:if test="priority=2"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Medium</option>
+ <option value="3"><xsl:if test="priority=3"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>High</option>
+ <option value="4"><xsl:if test="priority=4"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Urgent</option>
</select>
<input type="hidden" name="fullpath"><xsl:attribute name="value"><xsl:value-of select="fullpath"/></xsl:attribute></input>
</form>
@@ -192,10 +192,10 @@
<td>
<select name="prioritySelectedSelection">
<option value="0">Choose Priority</option>
- <option value="1"><xsl:if test="priority=1"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Low</option>
- <option value="2"><xsl:if test="priority=2"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Medium</option>
- <option value="3"><xsl:if test="priority=3"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>High</option>
- <option value="4"><xsl:if test="priority=4"><xsl:attribute name="selected">true</xsl:attribute></xsl:if>Urgent</option>
+ <option value="1"><xsl:if test="priority=1"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Low</option>
+ <option value="2"><xsl:if test="priority=2"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Medium</option>
+ <option value="3"><xsl:if test="priority=3"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>High</option>
+ <option value="4"><xsl:if test="priority=4"><xsl:attribute name="selected">selected</xsl:attribute></xsl:if>Urgent</option>
</select>
<input type="submit" name="changePrioritySelected" value="Change priority of selected files >>"/></td>
</tr>
diff --git a/manageProjectRoles.xsl b/manageProjectRoles.xsl
index 628c768..138ea4f 100644
--- a/manageProjectRoles.xsl
+++ b/manageProjectRoles.xsl
@@ -103,7 +103,7 @@
<xsl:for-each select="cdash/cvsuser">
<tr>
<td><input type="checkbox" value="1">
- <xsl:attribute name="checked">true</xsl:attribute>
+ <xsl:attribute name="checked">checked</xsl:attribute>
<xsl:attribute name="name">cvsuser[<xsl:value-of select="id"/>]</xsl:attribute>
</input>
</td>
diff --git a/subscribeProject.xsl b/subscribeProject.xsl
index 44fd36a..6436a46 100644
--- a/subscribeProject.xsl
+++ b/subscribeProject.xsl
@@ -97,7 +97,7 @@
<table width="800" >
<tr>
<td></td>
- <td><input type="radio" onchange="saveChanges();" name="role" value="0" checked="true">
+ <td><input type="radio" onchange="saveChanges();" name="role" value="0" checked="checked">
<xsl:if test="/cdash/role=0">
<xsl:attribute name="checked"></xsl:attribute>
</xsl:if>
@@ -120,7 +120,7 @@
</tr>
<tr>
<td></td>
- <td ><input type="radio" onchange="saveChanges();" name="role" value="2" checked="true">
+ <td ><input type="radio" onchange="saveChanges();" name="role" value="2" checked="checked">
<xsl:if test="/cdash/role=2">
<xsl:attribute name="checked"></xsl:attribute>
</xsl:if>
@@ -364,7 +364,7 @@
<tr>
<td align="right">
Available Labels (last 7 days)<br/>
- <select name="movelabels[]" size="15" multiple="true" id="movelabels" onDblClick="rightTransfer()">
+ <select name="movelabels[]" size="15" multiple="multiple" id="movelabels" onDblClick="rightTransfer()">
<xsl:for-each select="/cdash/project/label">
<option>
<xsl:attribute name="value"><xsl:value-of select="id"/></xsl:attribute>
@@ -379,7 +379,7 @@
</td>
<td align="left">
Email Labels <br/>
- <select name="emaillabels[]" size="15" multiple="true" id="emaillabels" onDblClick="leftTransfer()">
+ <select name="emaillabels[]" size="15" multiple="multiple" id="emaillabels" onDblClick="leftTransfer()">
<xsl:for-each select="/cdash/project/labelemail">
<option>
<xsl:attribute name="value"><xsl:value-of select="id"/></xsl:attribute>
--
1.7.9.5
0003-PEDANTIC-Always-specify-type-attribute-for-script-ta.patch [^] (4,514 bytes) 2013-10-25 11:40 [Show Content] [Hide Content]From 3f4fad0d66cf793df8fc3646d032d0f465bd7c21 Mon Sep 17 00:00:00 2001
From: Igor Murzov <e-mail@date.by>
Date: Thu, 24 Oct 2013 22:07:11 +0400
Subject: [PATCH 3/7] PEDANTIC: Always specify 'type' attribute for <script>
tag
---
manageBuildGroup.xsl | 4 ++--
manageProjectRoles.xsl | 8 ++++----
manageSubproject.xsl | 4 ++--
manageUsers.xsl | 6 +++---
viewUpdate.xsl | 2 +-
5 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/manageBuildGroup.xsl b/manageBuildGroup.xsl
index 0dc791f..386fdf3 100644
--- a/manageBuildGroup.xsl
+++ b/manageBuildGroup.xsl
@@ -24,8 +24,8 @@
<xsl:comment><![CDATA[[if IE]>
<link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
<![endif]]]></xsl:comment>
- <script src="javascript/jquery-1.6.2.js"></script>
- <script type="text/javascript" src="javascript/ui.tabs.js"></script>
+ <script src="javascript/jquery-1.6.2.js" type="text/javascript"></script>
+ <script src="javascript/ui.tabs.js" type="text/javascript"></script>
<!-- Functions to confirm the remove -->
<xsl:text disable-output-escaping="yes">
diff --git a/manageProjectRoles.xsl b/manageProjectRoles.xsl
index 138ea4f..85d2eaa 100644
--- a/manageProjectRoles.xsl
+++ b/manageProjectRoles.xsl
@@ -25,14 +25,14 @@
<link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
<![endif]]]></xsl:comment>
<!-- Include project roles -->
- <script src="javascript/jquery-1.6.2.js"></script>
- <script src="javascript/cdashProjectRole.js"></script>
- <script type="text/javascript" src="javascript/ui.tabs.js"></script>
+ <script src="javascript/jquery-1.6.2.js" type="text/javascript"></script>
+ <script src="javascript/cdashProjectRole.js" type="text/javascript"></script>
+ <script src="javascript/ui.tabs.js" type="text/javascript"></script>
<!-- Functions to confirm the email -->
<xsl:text disable-output-escaping="yes">
- <script language="JavaScript">
+ <script type="text/javascript">
function confirmEmail() {
if (window.confirm("Are you sure you want to send this email to all site maintainers?")){
return true;
diff --git a/manageSubproject.xsl b/manageSubproject.xsl
index d26eea0..b9b2c58 100644
--- a/manageSubproject.xsl
+++ b/manageSubproject.xsl
@@ -24,8 +24,8 @@
<xsl:comment><![CDATA[[if IE]>
<link rel="stylesheet" href="tabs_ie.css" type="text/css" media="projection, screen" />
<![endif]]]></xsl:comment>
- <script src="javascript/jquery-1.6.2.js"></script>
- <script type="text/javascript" src="javascript/ui.tabs.js"></script>
+ <script src="javascript/jquery-1.6.2.js" type="text/javascript"></script>
+ <script src="javascript/ui.tabs.js" type="text/javascript"></script>
</head>
<body bgcolor="#ffffff">
diff --git a/manageUsers.xsl b/manageUsers.xsl
index 8946aca..ede3b91 100644
--- a/manageUsers.xsl
+++ b/manageUsers.xsl
@@ -23,11 +23,11 @@
</link>
<!-- Include project roles -->
- <script src="javascript/jquery-1.6.2.js"></script>
- <script src="javascript/cdashManageUsers.js"></script>
+ <script src="javascript/jquery-1.6.2.js" type="text/javascript"></script>
+ <script src="javascript/cdashManageUsers.js" type="text/javascript"></script>
<!-- Functions to confirm the email -->
<xsl:text disable-output-escaping="yes">
- <script language="JavaScript">
+ <script language="JavaScript" type="text/javascript">
function confirmRemove() {
if (window.confirm("Are you sure you want to remove this user from the database?")){
return true;
diff --git a/viewUpdate.xsl b/viewUpdate.xsl
index 20fe0fd..8acc3e2 100644
--- a/viewUpdate.xsl
+++ b/viewUpdate.xsl
@@ -101,7 +101,7 @@ Show Activity Graph
<p></p>
<xsl:text disable-output-escaping="yes">
-<script LANGUAGE="JavaScript"></xsl:text><xsl:value-of select="cdash/updates/javascript"/>
+<script type="text/javascript" language="JavaScript"></xsl:text><xsl:value-of select="cdash/updates/javascript"/>
<xsl:text disable-output-escaping="yes">
</script>
</xsl:text>
--
1.7.9.5
0004-PEDANTIC-HTML-doesn-t-allow-link-tags-in-the-body.patch [^] (1,226 bytes) 2013-10-25 11:40 [Show Content] [Hide Content]From 111993dba130d413cac0f9384af9ee0fb70af482 Mon Sep 17 00:00:00 2001
From: Igor Murzov <e-mail@date.by>
Date: Tue, 22 Oct 2013 16:47:55 +0400
Subject: [PATCH 4/7] PEDANTIC: HTML doesn't allow 'link' tags in the <body>
This fixes tons of errors like "File does not exist: /var/www/favicon.ico,
referer: http://localhost/cdash/createProject.php" in httpd logs.
---
headeradminproject.xsl | 2 --
headerback.xsl | 2 --
2 files changed, 4 deletions(-)
diff --git a/headeradminproject.xsl b/headeradminproject.xsl
index 10b5e2c..5feb41f 100644
--- a/headeradminproject.xsl
+++ b/headeradminproject.xsl
@@ -3,8 +3,6 @@
<xsl:output method="xml" doctype-public="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd" encoding="UTF-8"/>
<xsl:template name="headeradminproject">
-<link rel="shortcut icon" href="favicon.ico"/>
-
<div id="header">
<div id="headertop">
diff --git a/headerback.xsl b/headerback.xsl
index 1d42ce4..84b1200 100644
--- a/headerback.xsl
+++ b/headerback.xsl
@@ -6,8 +6,6 @@
<xsl:include href="local/headscripts.xsl"/>
<xsl:template name="headerback">
-<link rel="shortcut icon" href="favicon.ico"/>
-
<div id="header">
<div id="headertop">
--
1.7.9.5
0005-BUG-Fix-minor-html-markdown-issues.patch [^] (7,573 bytes) 2013-10-25 11:40 [Show Content] [Hide Content]From 4aecc9663f422c751f048affe04a8894bad1934f Mon Sep 17 00:00:00 2001
From: Igor Murzov <e-mail@date.by>
Date: Thu, 24 Oct 2013 22:07:38 +0400
Subject: [PATCH 5/7] BUG: Fix minor html markdown issues
---
createProject.xsl | 2 +-
register.xsl | 2 +-
siteStatistics.xsl | 3 ++-
subscribeProject.xsl | 6 +++---
viewCoverage.xsl | 2 +-
viewMap.xsl | 2 +-
viewNotes.xsl | 2 +-
viewUpdate.xsl | 8 ++++----
8 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/createProject.xsl b/createProject.xsl
index f9d39a4..5aa41a4 100644
--- a/createProject.xsl
+++ b/createProject.xsl
@@ -1278,7 +1278,7 @@
<div class="tab_help"></div>
<table width="100%">
<tr>
- <td valign="top" align="righ"><strong>CTest Template Script:</strong>
+ <td valign="top" align="right"><strong>CTest Template Script:</strong>
</td>
<td >
<textarea name="ctestTemplateScript" onchange="saveChanges();"
diff --git a/register.xsl b/register.xsl
index fb94a81..4e00674 100644
--- a/register.xsl
+++ b/register.xsl
@@ -74,7 +74,7 @@
<div style="color: red;"><xsl:value-of select="cdash/error" /><br/></div>
<!-- Main -->
-<form method="post" action="register.php" name="regform" onSubmit="doSubmit();">
+<form method="post" action="register.php" name="regform" onsubmit="doSubmit();">
<table border="0" cellpadding="4" cellspacing="0" width="100%" class="tabb">
<tbody>
<tr class="treven">
diff --git a/siteStatistics.xsl b/siteStatistics.xsl
index 421a2e5..fba7cd1 100644
--- a/siteStatistics.xsl
+++ b/siteStatistics.xsl
@@ -5,7 +5,8 @@
<xsl:include href="local/footer.xsl"/>
<xsl:include href="headerback.xsl"/>
- <xsl:output method="html" />
+ <xsl:output method="xml" indent="yes" doctype-public="-//W3C//DTD XHTML 1.0 Transitional//EN"
+ doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd" />
<xsl:template match="/">
<html>
<head>
diff --git a/subscribeProject.xsl b/subscribeProject.xsl
index 6436a46..4dc2fa4 100644
--- a/subscribeProject.xsl
+++ b/subscribeProject.xsl
@@ -33,7 +33,7 @@
<script type="text/javascript" src="javascript/cdashUserLabels.js"></script>
<script type="text/javascript" src="javascript/ui.tabs.js"></script>
</head>
- <body bgcolor="#ffffff" onLoad="opt.init(document.forms[1])">
+ <body bgcolor="#ffffff" onload="opt.init(document.forms[1])">
<xsl:choose>
<xsl:when test="/cdash/uselocaldirectory=1">
@@ -364,7 +364,7 @@
<tr>
<td align="right">
Available Labels (last 7 days)<br/>
- <select name="movelabels[]" size="15" multiple="multiple" id="movelabels" onDblClick="rightTransfer()">
+ <select name="movelabels[]" size="15" multiple="multiple" id="movelabels" ondblclick="rightTransfer()">
<xsl:for-each select="/cdash/project/label">
<option>
<xsl:attribute name="value"><xsl:value-of select="id"/></xsl:attribute>
@@ -379,7 +379,7 @@
</td>
<td align="left">
Email Labels <br/>
- <select name="emaillabels[]" size="15" multiple="multiple" id="emaillabels" onDblClick="leftTransfer()">
+ <select name="emaillabels[]" size="15" multiple="multiple" id="emaillabels" ondblclick="leftTransfer()">
<xsl:for-each select="/cdash/project/labelemail">
<option>
<xsl:attribute name="value"><xsl:value-of select="id"/></xsl:attribute>
diff --git a/viewCoverage.xsl b/viewCoverage.xsl
index 00c7fe6..bd4eddf 100644
--- a/viewCoverage.xsl
+++ b/viewCoverage.xsl
@@ -123,7 +123,7 @@
</td>
</xsl:if>
- <td valign="Top" align="right">
+ <td valign="top" align="right">
<table border="0" cellpadding="3" cellspacing="1" bgcolor="#0000aa" width="350">
<tr class="table-heading1">
<th>Coverage Legend</th>
diff --git a/viewMap.xsl b/viewMap.xsl
index b9ce364..59cd071 100644
--- a/viewMap.xsl
+++ b/viewMap.xsl
@@ -74,7 +74,7 @@
<div style="position:relative;">
<div style="float:left; padding-right:20px;">
<!-- Display the table of maintainers -->
-<table id="maintainerTable" witdh="100%" cellspacing="0" class="tabb">
+<table id="maintainerTable" width="100%" cellspacing="0" class="tabb">
<thead>
<tr class="table-heading1">
<th id="sort_0">Site Name</th>
diff --git a/viewNotes.xsl b/viewNotes.xsl
index 604dfaf..a07882a 100644
--- a/viewNotes.xsl
+++ b/viewNotes.xsl
@@ -36,7 +36,7 @@
<h3 style="background: #b0c4de">Notes for <xsl:value-of select="cdash/build/site"/>--<xsl:value-of select="cdash/build/buildname"/>-<xsl:value-of select="cdash/build/stamp"/></h3>
<xsl:for-each select="cdash/note">
<p>
- <img SRC="images/document.png" ALT="Notes" border="0" ALIGN="texttop"/>
+ <img src="images/document.png" alt="Notes" border="0" align="top"/>
<b> <xsl:value-of select="time"/></b>
<b> -- <xsl:value-of select="name"/></b><br/>
<pre>
diff --git a/viewUpdate.xsl b/viewUpdate.xsl
index 8acc3e2..387bd27 100644
--- a/viewUpdate.xsl
+++ b/viewUpdate.xsl
@@ -95,9 +95,9 @@ Show Activity Graph
</h3>
<xsl:text disable-output-escaping="yes"><script type="text/javascript">var Icons = "images/";</script></xsl:text>
-<script type="text/javascript" SRC="javascript/tree.js"></script>
+<script type="text/javascript" src="javascript/tree.js"></script>
-<a xmlns:lxslt="http://xml.apache.org/xslt" href="javascript:reload()" onMouseOver="window.parent.status='Expand all';return true;" onClick="explode()">Expand all</a> <xsl:text> </xsl:text>|<xsl:text> </xsl:text><a xmlns:lxslt="http://xml.apache.org/xslt" href="javascript:reload()" onMouseOver="window.parent.status='Collapse all';return true;" onClick="contract()">Collapse all</a>
+<a xmlns:lxslt="http://xml.apache.org/xslt" href="javascript:reload()" onmouseover="window.parent.status='Expand all';return true;" onclick="explode()">Expand all</a> <xsl:text> </xsl:text>|<xsl:text> </xsl:text><a xmlns:lxslt="http://xml.apache.org/xslt" href="javascript:reload()" onmouseover="window.parent.status='Collapse all';return true;" onclick="contract()">Collapse all</a>
<p></p>
<xsl:text disable-output-escaping="yes">
@@ -106,9 +106,9 @@ Show Activity Graph
</script>
</xsl:text>
-<script type="text/javascript" SRC="javascript/tree_init.js"></script>
+<script type="text/javascript" src="javascript/tree_init.js"></script>
<br/>
-<a xmlns:lxslt="http://xml.apache.org/xslt" href="javascript:reload()" onMouseOver="window.parent.status='Expand all';return true;" onClick="explode()">Expand all</a> <xsl:text> </xsl:text>|<xsl:text> </xsl:text><a xmlns:lxslt="http://xml.apache.org/xslt" href="javascript:reload()" onMouseOver="window.parent.status='Collapse all';return true;" onClick="contract()">Collapse all</a>
+<a xmlns:lxslt="http://xml.apache.org/xslt" href="javascript:reload()" onmouseover="window.parent.status='Expand all';return true;" onclick="explode()">Expand all</a> <xsl:text> </xsl:text>|<xsl:text> </xsl:text><a xmlns:lxslt="http://xml.apache.org/xslt" href="javascript:reload()" onmouseover="window.parent.status='Collapse all';return true;" onclick="contract()">Collapse all</a>
<br/>
<!-- FOOTER -->
--
1.7.9.5
0006-BUG-Fix-displaying-help-message-for-the-CTestConfig-.patch [^] (1,965 bytes) 2013-10-25 11:40 [Show Content] [Hide Content]From 10c709dbd1cb549805774b2d3589f2dd9a4dec98 Mon Sep 17 00:00:00 2001
From: Igor Murzov <e-mail@date.by>
Date: Tue, 22 Oct 2013 17:24:25 +0400
Subject: [PATCH 6/7] BUG: Fix displaying help message for the CTestConfig
entry on Edit Project page
---
createProject.xsl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/createProject.xsl b/createProject.xsl
index 5aa41a4..af80f08 100644
--- a/createProject.xsl
+++ b/createProject.xsl
@@ -1167,7 +1167,7 @@
<a
href="http://www.cdash.org/Wiki/CDash:Administration#Creating_a_project"
target="blank">
- <img onmouseover="showHelp('ctestConfig_help');"
+ <img onmouseover="showHelp('blockList_help');"
src="images/help.gif" border="0" />
</a>
</strong>
@@ -1197,7 +1197,7 @@
</table>
</td>
- <span class="help_content" id="ctestConfig_help">
+ <span class="help_content" id="blockList_help">
<b>Block List</b>
<br />
Submission to CDash can be blocked given a sitename,
@@ -1282,7 +1282,7 @@
</td>
<td >
<textarea name="ctestTemplateScript" onchange="saveChanges();"
- onfocus="$('.ctesttemplatescript_help').html('');" id="description" cols="80"
+ onfocus="$('.ctesttemplatescript_help').html('');" id="ctestScript" cols="80"
rows="30" wrap="off">
<xsl:value-of select="cdash/project/ctesttemplatescript" />
</textarea>
--
1.7.9.5
|