View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014484

CMake

CTest

public

2013-10-15 08:15

2013-10-28 13:52

Reporter

Nils Gladitz

Assigned To

Nils Gladitz

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake 2.8.12

Target Version

Fixed in Version

CMake 3.0

Summary

0014484: CTest ignores RUN_SERIAL if test gets run as a dependency of another test

Description

I've attached a test case that reproduces the problem to this issue.

The "sleep" command may have to be substituted with something platform specific (sorry I couldn't find a portable sleep replacement in cmake).

When I run it on my system with ctest -j 24
the following tests are started simultaneously:
    Start 8: i_want_to_be_alone
    Start 6: i_like_company_5
    Start 5: i_like_company_4
    Start 4: i_like_company_3
    Start 3: i_like_company_2
    Start 2: i_like_company_1
    Start 1: i_like_company_0

I'd expect "i_want_to_be_alone" to be run by itself.

Tags

No tags attached.

Attached Files

CMakeLists.txt [^] (630 bytes) 2013-10-15 10:40 [Show Content] [Hide Content]

if(TEST_NAME)
	set(CTEST_RUN_CURRENT_SCRIPT 0)
	ctest_sleep(20)
	return()
endif()

cmake_minimum_required(VERSION 2.8.12)

message(${CMAKE_CURRENT_LIST_FILE})

enable_testing()

function(my_add_test NAME)
	add_test(${NAME} 
		${CMAKE_CTEST_COMMAND} -DTEST_NAME=${NAME} 
		-S ${CMAKE_CURRENT_LIST_FILE})
endfunction()

foreach(ID RANGE 5)
	math(EXPR TIME "61+${ID}")
	my_add_test(i_like_company_${ID})
endforeach()

my_add_test(i_have_dependencies)
set_tests_properties(i_have_dependencies PROPERTIES 
	DEPENDS "i_want_to_be_alone")

my_add_test(i_want_to_be_alone)
set_tests_properties(i_want_to_be_alone PROPERTIES RUN_SERIAL 1)

Relationships

Notes
(0034120) David Cole (manager) 2013-10-15 09:00	This is with 2.8.12? Have you tried using "1" instead of lower-case "true"? I thought we had this problem in a previous release, and it had been fixed... (But I may be remembering incorrectly.) FYI, I use the following as a "ctest -S" script as a cross-platform sleep implementation: if(NOT DEFINED seconds) set(seconds 1) endif() set(CTEST_RUN_CURRENT_SCRIPT 0) ctest_sleep(${seconds})

(0034121) Nils Gladitz (developer) 2013-10-15 09:09	Yes, I am using 2.8.12. RUN_SERIAL by itself does work. It only starts breaking when the test gets started as a dependency. I tried with "1" nonetheless (just in case) but it did not help. I think I've had this problem for a while but have only just now been able to trace it back to this.

(0034124) Nils Gladitz (developer) 2013-10-15 10:42	I attached a new version of my CMakeLists.txt which should now be portable :)

(0034149) Nils Gladitz (developer) 2013-10-17 16:45	I created a patch and started discussion here: http://public.kitware.com/pipermail/cmake-developers/2013-October/008653.html [^]

(0034275) Nils Gladitz (developer) 2013-10-28 13:52	fixed by http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=38fc334fd0619bf7b440003a1598f5467ed9a728;hp=ef13fc4dfcbb2b7cf79aade2d7612c3748fb24b2 [^] and http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ecc6d7f9190a660c0f442c4d03854b06e3fc7856;hp=387b93d09d99caf10039dded8a739942e5fea15c [^]

Issue History
Date Modified	Username	Field	Change
2013-10-15 08:15	Nils Gladitz	New Issue
2013-10-15 08:15	Nils Gladitz	File Added: CMakeLists.txt
2013-10-15 09:00	David Cole	Note Added: 0034120
2013-10-15 09:09	Nils Gladitz	Note Added: 0034121
2013-10-15 10:40	Nils Gladitz	File Deleted: CMakeLists.txt
2013-10-15 10:40	Nils Gladitz	File Added: CMakeLists.txt
2013-10-15 10:42	Nils Gladitz	Note Added: 0034124
2013-10-17 16:45	Nils Gladitz	Note Added: 0034149
2013-10-27 15:35	Nils Gladitz	Assigned To	=> Nils Gladitz
2013-10-27 15:35	Nils Gladitz	Status	new => assigned
2013-10-28 13:52	Nils Gladitz	Note Added: 0034275
2013-10-28 13:52	Nils Gladitz	Status	assigned => resolved
2013-10-28 13:52	Nils Gladitz	Fixed in Version	=> CMake 3.0
2013-10-28 13:52	Nils Gladitz	Resolution	open => fixed
2013-10-28 13:52	Nils Gladitz	Status	resolved => closed