[Hide Content]From 38bb850220cce952c0af8f7c0986f25c87f5265f Mon Sep 17 00:00:00 2001
From: Igor Murzov <e-mail@date.by>
Date: Thu, 10 Oct 2013 19:30:58 +0400
Subject: [PATCH] BUG: Drop unnecessary MySql-style quotes from SQL queries.
PostgreSQL throws syntax errors on names in backquotes.
---
monitor.php | 2 +-
testSummary.php | 4 ++--
viewTest.php | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/monitor.php b/monitor.php
index 8cdb084..2abed0f 100755
--- a/monitor.php
+++ b/monitor.php
@@ -143,7 +143,7 @@ function echo_average_wait_time($projectid)
"AVG(TIMESTAMPDIFF(SECOND, started, finished)) AS mean, ".
"MIN(TIMESTAMPDIFF(SECOND, started, finished)) AS shortest, ".
"MAX(TIMESTAMPDIFF(SECOND, started, finished)) AS longest ".
- "FROM `submission` WHERE status = 2 AND projectid = $projectid ".
+ "FROM submission WHERE status = 2 AND projectid = $projectid ".
"GROUP BY hours_ago ORDER BY hours_ago ASC LIMIT 48";
}
diff --git a/testSummary.php b/testSummary.php
index 3e8e58a..d5a7f41 100644
--- a/testSummary.php
+++ b/testSummary.php
@@ -117,7 +117,7 @@ $columncount=pdo_num_rows($getcolumnnumber);
if($columncount>0)
{
$etestquery=pdo_query("SELECT test.id, test.projectid, build2test.buildid, build2test.status, build2test.timestatus, test.name,
- testmeasurement.name, testmeasurement.value, build.starttime, build2test.time, measurement.testpage FROM `test`
+ testmeasurement.name, testmeasurement.value, build.starttime, build2test.time, measurement.testpage FROM test
JOIN testmeasurement ON (test.id = testmeasurement.testid)
JOIN build2test ON (build2test.testid = test.id)
JOIN build ON (build.id = build2test.buildid)
@@ -207,7 +207,7 @@ $columncount=pdo_num_rows($getcolumnnumber);
// If at least one column is selected
if($columncount>0)
{
- $etestquery=pdo_query("SELECT test.id, test.projectid, build2test.buildid, build2test.status, build2test.timestatus, test.name, testmeasurement.name, testmeasurement.value, build.starttime, build2test.time, measurement.testpage FROM `test`
+ $etestquery=pdo_query("SELECT test.id, test.projectid, build2test.buildid, build2test.status, build2test.timestatus, test.name, testmeasurement.name, testmeasurement.value, build.starttime, build2test.time, measurement.testpage FROM test
JOIN testmeasurement ON (test.id = testmeasurement.testid)
JOIN build2test ON (build2test.testid = test.id)
JOIN build ON (build.id = build2test.buildid)
diff --git a/viewTest.php b/viewTest.php
index 87c7051..6fd0310 100644
--- a/viewTest.php
+++ b/viewTest.php
@@ -277,7 +277,7 @@ if($columncount>0)
$etestquery=pdo_query("SELECT test.id, test.projectid, build2test.buildid,
build2test.status, build2test.timestatus, test.name, testmeasurement.name,
testmeasurement.value, build.starttime,
- build2test.time, measurement.testpage FROM `test`
+ build2test.time, measurement.testpage FROM test
JOIN testmeasurement ON (test.id = testmeasurement.testid)
JOIN build2test ON (build2test.testid = test.id)
JOIN build ON (build.id = build2test.buildid)
--
1.7.9.5