View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014451 | CDash | (No Category) | public | 2013-10-01 11:25 | 2013-10-01 11:36 | ||||
Reporter | Joe Snyder | ||||||||
Assigned To | Julien Jomier | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Platform | Linux | OS | Ubuntu | OS Version | 12.04.03 | ||||
Product Version | 2.0 | ||||||||
Target Version | Fixed in Version | 2.2 | |||||||
Summary | 0014451: clientjobschedule.php doesn't encode project name before adding to submit URL | ||||||||
Description | When building the URL to submit the results from a scheduled run, a project with spaces in the name will not be encoded. This leads to a "not a valid project" message when using the URL: Submit files (using http) Using HTTP submit method Drop site:http://code.osehra.org/CDash/submit.php?project=Open [^] Source EHR&clientscheduleid=26 Upload file: C:/temp/VistATesting-bin/Testing/20131001-1352/Build.xml to http://code.osehra.org/CDash/submit.php?project=Open [^] Source EHR&clientscheduleid=26&FileName=palaven.kitware___Windows-7-64-Cache-2011.1___20131001-1352-Experimental___XML___Build.xml&MD5=60ddeca5b5270f26be4a0852c147bc60 Size: 1233 Submission failed: Not a valid project. which repeats for each file upload attempt. I don't see this as being platform specific, but I've added the server specification where this instance is being hosted. | ||||||||
Steps To Reproduce | Create CDash project that has a space in the name like "Open Source EHR" Schedule a build using the "Manage Client" page After testing completion and during submission attempt, error will appear | ||||||||
Additional Information | I've attached a diff for adding a 'urlencode' call on the project name in clientjobschedule.php where the URL is being created. This may not be the best place for it, but it solved the problem for me. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | encode-project-name.diff [^] (675 bytes) 2013-10-01 11:25 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0033960) Julien Jomier (manager) 2013-10-01 11:36 |
Fixed in SVN. Thanks for the report and patch! |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2013-10-01 11:25 | Joe Snyder | New Issue | |
2013-10-01 11:25 | Joe Snyder | File Added: encode-project-name.diff | |
2013-10-01 11:34 | Julien Jomier | Assigned To | => Julien Jomier |
2013-10-01 11:34 | Julien Jomier | Status | new => assigned |
2013-10-01 11:36 | Julien Jomier | Note Added: 0033960 | |
2013-10-01 11:36 | Julien Jomier | Status | assigned => resolved |
2013-10-01 11:36 | Julien Jomier | Fixed in Version | => 2.2 |
2013-10-01 11:36 | Julien Jomier | Resolution | open => fixed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |