View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013986CMakeCMakepublic2013-03-06 08:312013-10-07 10:03
ReporterBenjamin Kloster 
Assigned ToStephen Kelly 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSUbuntuOS Version12.04 x64
Product VersionCMake 2.8.10.2 
Target VersionCMake 2.8.11Fixed in VersionCMake 2.8.11 
Summary0013986: Target names may not contain a plus sign anymore
DescriptionSince the latest revision in Git (commit efdf152), CMake balks at targets with a plus sign in their name. Since it's a common practice to name C++ wrapper of some libraries as MyLib++, that's a little strange. Attached is a diff that adds the plus sign to the regex used to verify target names.
Steps To ReproduceInvoke CMake with a CMakeLists.txt containing:

add_executable(mylib++ ${SOURCE_FILES})

It will fail with the error message "Target name not supported"
Additional InformationSee also: http://www.mail-archive.com/cmake@cmake.org/msg45517.html [^]
TagsNo tags attached.
Attached Filesdiff file icon allow_plus_sign.diff [^] (637 bytes) 2013-03-06 08:31 [Show Content]

 Relationships

  Notes
(0032521)
Stephen Kelly (developer)
2013-03-06 11:00

Hi,

Thanks for the report and the patch.

I tried reproducing the problem with the snippet you provided, but it doesn't fail for me. Is there something else needed?

Thanks,

Steve.
(0032522)
Stephen Kelly (developer)
2013-03-06 11:07

Ah, I have to create a second target and link to the first one.
(0032527)
Rolf Eike Beer (developer)
2013-03-07 02:07

Stephen, as you found out that those target names are illegal with the borland compiler anyway, would it make sense to give a proper error message (from CMake) when generating for Borland instead of letting everything pass through and later fail with some compiler error message where the reason is hard to guess?
(0032528)
Stephen Kelly (developer)
2013-03-07 04:38

I wouldn't object to such a patch, but I don't think it's really in scope for this bug.
(0032602)
Stephen Kelly (developer)
2013-03-13 11:46

Please file a separate feature request for the Borland issue if you wish.
(0033995)
Robert Maynard (manager)
2013-10-07 10:03

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2013-03-06 08:31 Benjamin Kloster New Issue
2013-03-06 08:31 Benjamin Kloster File Added: allow_plus_sign.diff
2013-03-06 08:55 Brad King Assigned To => Stephen Kelly
2013-03-06 08:55 Brad King Status new => assigned
2013-03-06 08:55 Brad King Target Version => CMake 2.8.11
2013-03-06 11:00 Stephen Kelly Note Added: 0032521
2013-03-06 11:07 Stephen Kelly Note Added: 0032522
2013-03-07 02:07 Rolf Eike Beer Note Added: 0032527
2013-03-07 04:38 Stephen Kelly Note Added: 0032528
2013-03-13 11:46 Stephen Kelly Note Added: 0032602
2013-03-13 11:46 Stephen Kelly Status assigned => resolved
2013-03-13 11:46 Stephen Kelly Fixed in Version => CMake 2.8.11
2013-03-13 11:46 Stephen Kelly Resolution open => fixed
2013-10-07 10:03 Robert Maynard Note Added: 0033995
2013-10-07 10:03 Robert Maynard Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team