View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0013651

CMake

public

2012-11-04 09:30

2013-04-17 08:54

Reporter

Gino van den Bergen

Assigned To

Brad King

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake 2.8.10

Target Version

CMake 2.8.10.1

Fixed in Version

CMake 2.8.10.1

Summary

0013651: FindSDL.cmake is broken

Description

After adding a Copyright to his name, Mr. Benjamin Eikel (what's in a name) decided to remove a number of path suffixes that plainly broke the FindSDL.cmake to be used in combination with the environment variable SDLDIR. This change was unnecessary as the FindSDL.cmake script works fine for the different platforms. I am puzzled by this action since it simply does not fix anything. I've attached a patch that would fix this for me but clearly the best thing to do would be revert the FindSDL*.cmake scripts back to 2.8.9 before Mr. Benjamin Eikel started his actions.

Steps To Reproduce

Set environment variable pointing to your SDL installation, that would typically look like

<SDLDIR>/bin
<SDLDIR>/include/SDL
<SDLDIR>/lib

Try to find the SDL headers and libraries with cmake 2.8.10 and see the latest script fail.

Additional Information

Could someone please take some action against maintainers adding a Copyright notice to the Find scripts, as Mr. Benjamin Eikel did? This behavior is quite obnoxious but also puts users in a difficult position since their rights become unclear. I do not oppose against people getting credited for their contributions but taking a Copyright over a few modified lines of script is simply not helping the product.

Tags

No tags attached.

Attached Files

FindSDL.patch [^] (602 bytes) 2012-11-04 09:30 [Show Content] [Hide Content]

 Modules/FindSDL.cmake | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Modules/FindSDL.cmake b/Modules/FindSDL.cmake
index 9359323..f2e9f25 100644
--- a/Modules/FindSDL.cmake
+++ b/Modules/FindSDL.cmake
@@ -70,7 +70,7 @@
 find_path(SDL_INCLUDE_DIR SDL.h
   HINTS
     ENV SDLDIR
-  PATH_SUFFIXES SDL SDL12 SDL11
+  PATH_SUFFIXES include/SDL include/SDL12 include/SDL11 include
 )
 
 # SDL-1.1 is the name used by FreeBSD ports...
@@ -79,6 +79,7 @@ find_library(SDL_LIBRARY_TEMP
   NAMES SDL SDL-1.1
   HINTS
     ENV SDLDIR
+  PATH_SUFFIXES lib
 )
 
 if(NOT SDL_BUILDING_LIBRARY)

Relationships

Notes
(0031420) Benjamin Eikel (developer) 2012-11-05 03:47	Hello Gino, thank you for your bug report. I will look into it as soon as possible. I am sorry if the behavior was changed by my commits. This was not my intention. I assume that you are talking about this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9ed24c5316fc4e9b56e3b491dee2f88b2cbb6f17 [^] I think I misunderstood the find_path and find_library documentation. The suffixes "include" and "lib" are not appended to the paths given in HINT (is that correct?), only to the prefix paths. Therefore, something like the solution given in your patch might be necessary to restore the old behavior. Kind regards Benjamin

(0031429) Brad King (manager) 2012-11-05 10:02	Re 0013651:0031420: Correct, the find_path and find_library commands add "include" and "lib" only to the prefix paths. @Gino van den Bergen: Please use a more constructive tone. Benjamin made a good-faith effort to improve CMake with his contributions. Copyright notices do not affect the rights of users. Rights are granted by the license (3-clase BSD in this case). Furthermore, Benjamin made 20 commits to improve the FindSDL*.cmake modules: http://cmake.org/gitweb?p=cmake.git;a=commit;h=7d03885d [^] His notice of copyright covers the net modifications, which were hardly trivial.

(0031430) Brad King (manager) 2012-11-05 10:04	Patch applied with an explanation: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7cb51739 [^]

(0032863) Robert Maynard (manager) 2013-04-17 08:54	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2012-11-04 09:30	Gino van den Bergen	New Issue
2012-11-04 09:30	Gino van den Bergen	File Added: FindSDL.patch
2012-11-05 03:47	Benjamin Eikel	Note Added: 0031420
2012-11-05 10:02	Brad King	Note Added: 0031429
2012-11-05 10:02	Brad King	Assigned To	=> Brad King
2012-11-05 10:02	Brad King	Status	new => assigned
2012-11-05 10:04	Brad King	Note Added: 0031430
2012-11-05 10:04	Brad King	Status	assigned => resolved
2012-11-05 10:04	Brad King	Resolution	open => fixed
2012-11-06 15:18	David Cole	Target Version	=> CMake 2.8.10.1
2012-11-07 13:36	David Cole	Fixed in Version	=> CMake 2.8.10.1
2013-04-17 08:54	Robert Maynard	Note Added: 0032863
2013-04-17 08:54	Robert Maynard	Status	resolved => closed