View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013591CMakeCMakepublic2012-10-16 07:042013-10-07 10:03
ReporterEric NOULARD 
Assigned ToPeter Kuemmel 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.9 
Target VersionFixed in VersionCMake 2.8.11 
Summary0013591: Ninja: generator fail with multi-line COMMENT in custom command
DescriptionIf one uses a newline character "\n" in a COMMENT of a
custom command/target, the Nija generator will produce an
invalid build.ninja file.

Steps To Reproduce$ cat CMakeLists.txt
cmake_minimum_required(VERSION 2.8)

project(NinjaCustomCommand NONE)

add_custom_target(GotYou ALL
  COMMAND ${CMAKE_COMMAND} -E echo \"Got You\"
  COMMENT "This may \n breaks Ninja")

$ mkdir b
$ cd b
$ cmake -G Ninja ..
-- Configuring done
-- Generating done
-- Build files have been written to: /home/erk/CMake/Contrib/NinjaAndCustomCommand/b
erk@CT-WDTIM102H:b$ ninja
ninja: error: build.ninja:54: expected '=', got identifier
 breaks Ninja
        ^ near here
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0032550)
Peter Kuemmel (developer)
2013-03-09 06:09

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3b4436aa90ba9f56085667d36c0a6c24c55c0cd7 [^]
(0033986)
Robert Maynard (manager)
2013-10-07 10:03

 Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2012-10-16 07:04 Eric NOULARD New Issue
2013-02-09 07:01 Peter Kuemmel Summary Ninja generator fail with multi-line COMMENT in custom command => Ninja: generator fail with multi-line COMMENT in custom command
2013-03-09 05:42 Peter Kuemmel Assigned To => Peter Kuemmel
2013-03-09 05:42 Peter Kuemmel Status new => assigned
2013-03-09 06:09 Peter Kuemmel Note Added: 0032550
2013-03-09 06:09 Peter Kuemmel Status assigned => resolved
2013-03-09 06:09 Peter Kuemmel Fixed in Version => CMake 2.8.11
2013-03-09 06:09 Peter Kuemmel Resolution open => fixed
2013-10-07 10:03 Robert Maynard Note Added: 0033986
2013-10-07 10:03 Robert Maynard Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team