View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0013426 | CMake | Modules | public | 2012-07-19 14:15 | 2014-06-02 08:37 | ||||
Reporter | Matt Williams | ||||||||
Assigned To | jschueller | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86_64 | OS | openSUSE | OS Version | 11.2 | ||||
Product Version | CMake 2.8.8 | ||||||||
Target Version | CMake 3.0 | Fixed in Version | CMake 3.0 | ||||||
Summary | 0013426: FindSWIG.cmake doesn't mark variables as advanced | ||||||||
Description | FindSWIG.cmake sets number of variables in the process of finding SWIG, notably: • SWIG_DIR • SWIG_EXECUTABLE • SWIG_VERSION Of the three of these, SWIG_EXECUTABLE is used to obtain the other two and it's CMake convention to only have one non-advanced variable per module which can then set the others. In this case, SWIG_DIR and SWIG_VERSION could be mark_as_advanced() without any loss to functionality while making the cmake-gui display cleaner. Searching around, I see at least two projects which are manually setting these varaibles as advanced in their own code (presumably simply to make cmake-gui or ccmake cleaner): http://dtk.inria.fr/+sup/dtk/dtk-clone-sup/blobs/ac62dd518871e2ccbeebe5c96dc6c6b1c815539f/cmake/dtkDependencies.cmake [^] http://speect.git.sourceforge.net/git/gitweb.cgi?p=speect/speect;a=commitdiff_plain;h=36485b8b7fc38be46c11aeedbc3ccf4abd26f2f6 [^] http://www.mail-archive.com/cmake@cmake.org/msg38240.html [^] | ||||||||
Steps To Reproduce | Run a CMake script which calls find_package(SWIG) and then run 'cmake -LA' and see that all three variables are shown. Only SWIG_EXECUTABLE should be. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0030089) Matt Williams (reporter) 2012-07-19 14:30 |
Of course, in "Steps to reproduce" I meant to run 'cmake -L' and not 'cmake -LA'. |
(0031942) Matt Williams (reporter) 2012-12-26 10:52 |
This bug is still present in CMake 2.8.10.2. All that is needed to fix it is a mark_as_advanced(SWIG_DIR SWIG_VERSION) towards the end of FindSWIG.cmake. |
(0034517) Brad King (manager) 2013-11-22 09:14 |
FindSWIG: Mark SWIG_DIR & SWIG_VERSION as advanced http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6620dc76 [^] |
(0034545) jschueller (developer) 2013-11-25 09:06 |
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8c127c9e [^] |
(0036026) Robert Maynard (manager) 2014-06-02 08:37 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2012-07-19 14:15 | Matt Williams | New Issue | |
2012-07-19 14:30 | Matt Williams | Note Added: 0030089 | |
2012-12-26 10:52 | Matt Williams | Note Added: 0031942 | |
2013-11-22 09:07 | Brad King | Assigned To | => jschueller |
2013-11-22 09:07 | Brad King | Status | new => assigned |
2013-11-22 09:14 | Brad King | Note Added: 0034517 | |
2013-11-22 09:20 | Brad King | Target Version | => CMake 3.0 |
2013-11-25 09:06 | jschueller | Note Added: 0034545 | |
2013-11-25 09:06 | jschueller | Status | assigned => resolved |
2013-11-25 09:06 | jschueller | Fixed in Version | => CMake 3.0 |
2013-11-25 09:06 | jschueller | Resolution | open => fixed |
2014-06-02 08:37 | Robert Maynard | Note Added: 0036026 | |
2014-06-02 08:37 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |