View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013176CMakeCPackpublic2012-04-30 05:122015-04-06 09:07
ReporterSergei Golubchik 
Assigned ToDomen Vrankar 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformanyOSLinuxOS Version
Product VersionCMake 2.8.8 
Target VersionCMake 2.8.12Fixed in VersionCMake 3.2 
Summary0013176: CPackRPM support for per-component summary/description
DescriptionCPackRPM supports per-component configuration, to a certain extent.
It can build many rpm's from one project, and these rpm's may have different require/obsolete, and prein/etc scripts.

But they all have the same summary and description.
One might expect CPACK_RPM_<component>_PACKAGE_SUMMARY and CPACK_RPM_<component>_PACKAGE_DESCRIPTION to work, but they don't.

Alternatively, CPackRPM could use CPACK_COMPONENT_<component>_DESCRIPTION, which may be less intuitive, but might allow better code reuse (in CMakeLists.txt) and less copy-pasting.
TagsNo tags attached.
Attached Filespatch file icon CPackRPM_component_summary_description.patch [^] (1,284 bytes) 2014-05-05 21:45 [Show Content]
patch file icon 0001-CPackRPM-component-based-packaging-description-and-s.patch [^] (5,040 bytes) 2014-10-14 03:51 [Show Content]
patch file icon 0001-add-added-semantic-tests-for-rpm-component-descripti.patch [^] (6,250 bytes) 2014-10-21 02:10 [Show Content]

 Relationships

  Notes
(0029365)
Eric NOULARD (developer)
2012-04-30 05:32

Hi Sergei,

You are right, the feature is missing.
I agree that we could probably go for using
CPACK_COMPONENT_<compName>_DESCRIPTION in the component case.

May be the best way should be to use
CPACK_RPM_<component>_PACKAGE_SUMMARY and
CPACK_RPM_<component>_PACKAGE_DESCRIPTION

with some default value if they are not defined.

e.g. for CPACK_RPM_<component>_PACKAGE_DESCRIPTION
default value could be:
1) CPACK_COMPONENT_<compName>_DESCRIPTION if defined
2) CPACK_RPM_PACKAGE_DESCRIPTION if defined


I cannot ensure any deadline to fix this.
Would you be willing to try to propose patch?
(0029366)
Sergei Golubchik (reporter)
2012-04-30 05:55

Yes, gladly. But I cannot ensure any deadline either :(

This issue is not a show-stopper for us (having identical summaries/descriptions might be acceptable, and if not, there's a workaround CPACK_RPM_USER_BINARY_SPECFILE).
(0035822)
clan (reporter)
2014-05-05 21:46

I don't know if this is still in the works but I've attached a patch that should allow per-component description/summary via CPACK_RPM_<component>_PACKAGE_SUMMARY and _PACKAGE_DESCRIPTION variables.
(0037026)
Domen Vrankar (developer)
2014-10-14 03:54

I have expanded the patch with documentation, fallback to CPACK_COMPONENT_<component>_DESCRIPTION and handling of cases when DESCRIPTION and/or SUMMARY is not set for all components.
(0037057)
Domen Vrankar (developer)
2014-10-21 02:13

I have fixed a bug in my previous patch - CPACK_COMPONENT_<component>_DESCRIPTION component must be in upper case.
I have also added semantic check tests of component description and summary fall backs.

Patches must be applied in order:
0001-CPackRPM-component-based-packaging-description-and-s.patch
0001-add-added-semantic-tests-for-rpm-component-descripti.patch
(0038444)
Robert Maynard (manager)
2015-04-06 09:07

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2012-04-30 05:12 Sergei Golubchik New Issue
2012-04-30 05:21 Eric NOULARD Assigned To => Eric NOULARD
2012-04-30 05:21 Eric NOULARD Status new => assigned
2012-04-30 05:32 Eric NOULARD Note Added: 0029365
2012-04-30 05:55 Sergei Golubchik Note Added: 0029366
2012-08-14 14:27 Eric NOULARD Product Version => CMake 2.8.8
2012-08-14 14:27 Eric NOULARD Target Version => CMake 2.8.10
2012-10-14 08:45 Eric NOULARD Target Version CMake 2.8.10 => CMake 2.8.11
2013-05-17 09:33 Robert Maynard Target Version CMake 2.8.11 => CMake 2.8.12
2014-05-05 21:45 clan File Added: CPackRPM_component_summary_description.patch
2014-05-05 21:46 clan Note Added: 0035822
2014-10-14 03:13 Eric NOULARD Assigned To Eric NOULARD => Domen Vrankar
2014-10-14 03:51 Domen Vrankar File Added: 0001-CPackRPM-component-based-packaging-description-and-s.patch
2014-10-14 03:54 Domen Vrankar Note Added: 0037026
2014-10-21 02:10 Domen Vrankar File Added: 0001-add-added-semantic-tests-for-rpm-component-descripti.patch
2014-10-21 02:13 Domen Vrankar Note Added: 0037057
2014-11-08 16:02 Domen Vrankar File Added: 0001-CPackRPM-handling-of-symbolic-links.patch
2014-11-08 16:03 Domen Vrankar File Deleted: 0001-CPackRPM-handling-of-symbolic-links.patch
2014-11-13 12:29 Domen Vrankar Status assigned => resolved
2014-11-13 12:29 Domen Vrankar Fixed in Version => CMake 3.2
2014-11-13 12:29 Domen Vrankar Resolution open => fixed
2015-04-06 09:07 Robert Maynard Note Added: 0038444
2015-04-06 09:07 Robert Maynard Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team