View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0012999CMakeCMakepublic2012-02-26 18:062012-09-03 16:02
ReporterModestas Vainius 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformamd64OSDebian GNU/LinuxOS Versionsid
Product VersionCMake 2.8.7 
Target VersionCMake 2.8.8Fixed in VersionCMake 2.8.8 
Summary0012999: Metachars should be escaped before embedding paths into the regex
Description${CMake_SOURCE_DIR} and ${CMake_BINARY_DIR} cannot be embedded into regex
directly. If they contain special regex metacharacters like +, the regex
will break. This could be fixed by escaping such metacharacters with a backslash before embedding the path into the regex (patch attached). Maybe it's even worth adding a subroutine to STRING command which does escaping, isn't it?

The issue affects the following tests: CTestTestConfigFileInBuildDir1 and
CTestTestConfigFileInBuildDir2.

The build log exhibiting the problem can be found at https://buildd.debian.org/status/fetch.php?pkg=cmake&arch=mipsel&ver=2.8.7-2%2Bb1&stamp=1330241990 [^]
TagsNo tags attached.
Attached Filesdiff file icon paths_in_regex_espace_metachars.diff [^] (2,770 bytes) 2012-02-26 18:06 [Show Content]

 Relationships

  Notes
(0028725)
Brad King (manager)
2012-02-27 09:03

Applied, thanks:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f5cf8f98 [^]
(0030883)
David Cole (manager)
2012-09-03 16:02

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2012-02-26 18:06 Modestas Vainius New Issue
2012-02-26 18:06 Modestas Vainius File Added: paths_in_regex_espace_metachars.diff
2012-02-27 09:03 Brad King Note Added: 0028725
2012-02-27 09:03 Brad King Status new => resolved
2012-02-27 09:03 Brad King Fixed in Version => CMake 2.8.8
2012-02-27 09:03 Brad King Resolution open => fixed
2012-02-27 09:03 Brad King Assigned To => Brad King
2012-04-19 15:51 David Cole Target Version => CMake 2.8.8
2012-09-03 16:02 David Cole Note Added: 0030883
2012-09-03 16:02 David Cole Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team