View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012449

CMake

Documentation

public

2011-09-08 11:34

2012-02-06 06:07

Reporter

Andreas Mohr

Assigned To

Eric NOULARD

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake 2.8.5

Target Version

CMake 2.8.6

Fixed in Version

CMake 2.8.6

Summary

0012449: CPack.cmake wrong CPACK_INSTALLED_DIRECTORIES docs, caused wrong docs at Wiki/CMake:CPackConfiguration#Advanced_settings

Description

git CPack.cmake wrongly lists CPACK_INSTALL_DIRECTORIES, which probably caused http://www.cmake.org/Wiki/CMake:CPackConfiguration#Advanced_settings [^] to (originally) adopt the same invalid spelling (should be CPACK_INSTALLED_DIRECTORIES). Source handling always does seem to reference the INSTALL*ED* setting.

Priority urgent since it's an almost-unforgivable documentation mistake which rippled through several places and can be fixed easily.
And severity major since users adopting that misspelt variable likely leaves them without any directories installed.

Thanks!

Tags

No tags attached.

Attached Files

0001-CPack-fix-12449-doc-mispelled.patch [^] (892 bytes) 2011-09-08 16:28 [Show Content] [Hide Content]

From 59204e11265eee5f8a482cf52b5daf5d57ed85c7 Mon Sep 17 00:00:00 2001
From: Eric NOULARD <eric.noulard@gmail.com>
Date: Thu, 8 Sep 2011 22:00:34 +0200
Subject: [PATCH] CPack fix #12449 doc mispelled
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

CPACK_INSTALL_DIRECTORIES-->CPACK_INSTALLED_DIRECTORIESœ
---
 Modules/CPack.cmake |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Modules/CPack.cmake b/Modules/CPack.cmake
index d82de93..2cc27cf 100644
--- a/Modules/CPack.cmake
+++ b/Modules/CPack.cmake
@@ -215,7 +215,7 @@
 #
 #   CPACK_INSTALL_COMMANDS - Extra commands to install components.
 #
-#   CPACK_INSTALL_DIRECTORIES - Extra directories to install.
+#   CPACK_INSTALLED_DIRECTORIES - Extra directories to install.
 #
 
 #=============================================================================
-- 
1.7.5.4

Relationships

Notes
(0027394) Eric NOULARD (developer) 2011-09-08 16:28	The fix should be in its way to stage and then to next but I'm experiencing serious network slow down which may prevent me for commiting tonight. I'll add the corresponding patch just in case I fail to push

(0027395) Eric NOULARD (developer) 2011-09-08 17:01	Looks like git access is incredibily slow tonight. I was able to push but the merge to next is not ending... ssh git@cmake.org stagemake merge -b next CPack-DocFix-bug12449 Fetching upstream next [forever paused...] So I'm not sure whether if it has been really merged. I'll try tomorrow morning unless someone would be kind enough to check and merge to next if it hasn't been done

(0027398) Eric NOULARD (developer) 2011-09-09 08:43	Fetching upstream next Merge topic 'CPack-DocFix-bug12449' into next b7457de CPack fix template too

(0028497) David Cole (manager) 2012-02-06 06:07	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2011-09-08 11:34	Andreas Mohr	New Issue
2011-09-08 15:55	Eric NOULARD	Assigned To	=> Eric NOULARD
2011-09-08 15:55	Eric NOULARD	Status	new => assigned
2011-09-08 16:28	Eric NOULARD	Note Added: 0027394
2011-09-08 16:28	Eric NOULARD	File Added: 0001-CPack-fix-12449-doc-mispelled.patch
2011-09-08 16:29	Eric NOULARD	Product Version	=> CMake 2.8.5
2011-09-08 16:29	Eric NOULARD	Target Version	=> CMake 2.8.6
2011-09-08 17:01	Eric NOULARD	Note Added: 0027395
2011-09-09 08:43	Eric NOULARD	Note Added: 0027398
2011-09-09 08:43	Eric NOULARD	Status	assigned => resolved
2011-09-09 08:43	Eric NOULARD	Fixed in Version	=> CMake 2.8.6
2011-09-09 08:43	Eric NOULARD	Resolution	open => fixed
2012-02-06 06:07	David Cole	Note Added: 0028497
2012-02-06 06:07	David Cole	Status	resolved => closed