View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012006

CMake

CPack

public

2011-03-23 17:56

2011-09-05 11:37

Reporter

Martin Konrad

Assigned To

Eric NOULARD

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Linux

Debian

OS Version

Product Version

Target Version

CMake 2.8.5

Fixed in Version

CMake 2.8.5

Summary

0012006: CPackDeb: packages for different components have the same package name

Description

The current development version of CPackDeb seems to handle Debian package names wrong: If we package more than one components (each into an own package) they all have the same name. This leads to a warning by dpkg when installing the packages. This probably breaks package installation.

Solution: Each deb file should get it's own package name e.g. foobar-lib and foobar-headers.

Steps To Reproduce

$ make test
$ cd Tests/CPackComponentsForAll/buildDEB-OnePackPerGroup/
$ sudo dpkg -i MyLib-1.0.2-Linux-*.deb
Selecting previously deselected package mylib.
(Reading database ... 301254 files and directories currently installed.)
Unpacking mylib (from MyLib-1.0.2-Linux-Development.deb) ...
Preparing to replace mylib 1.0.2 (using MyLib-1.0.2-Linux-Runtime.deb) ...
Unpacking replacement mylib ...
More than one copy of package mylib has been unpacked
in this run ! Only configuring it once.
Setting up mylib (1.0.2) ...

Tags

No tags attached.

Attached Files

0001_CPackDeb_fix_broken_package_names.diff [^] (1,004 bytes) 2011-03-23 17:57 [Show Content] [Hide Content]

commit aaf48594f799aa3e482ff54ec11e2ee25339bfa6
Author: Martin Konrad <konrad@ikp.tu-darmstadt.de>
Date:   Sun Mar 20 02:25:58 2011 +0100

    CPackDeb: Fix broken package names
    
    Package names were the same for all compontents which breaks installation of
    more than one of them - fixed.

diff --git a/Modules/CPackDeb.cmake b/Modules/CPackDeb.cmake
index 469f08f..90c80a4 100644
--- a/Modules/CPackDeb.cmake
+++ b/Modules/CPackDeb.cmake
@@ -316,6 +316,7 @@ IF(CPACK_DEB_PACKAGE_COMPONENT)
   SET(CPACK_DEB_PACKAGE_COMPONENT_PART_NAME "-${CPACK_DEB_PACKAGE_COMPONENT}")
   SET(CPACK_DEB_PACKAGE_COMPONENT_PART_PATH "/${CPACK_DEB_PACKAGE_COMPONENT}")
   SET(WDIR "${CPACK_TOPLEVEL_DIRECTORY}/${CPACK_PACKAGE_FILE_NAME}/${CPACK_DEB_PACKAGE_COMPONENT}")
+  STRING(TOLOWER "${CPACK_PACKAGE_NAME}${CPACK_DEB_PACKAGE_COMPONENT_PART_NAME}" CPACK_DEBIAN_PACKAGE_NAME)
 ELSE(CPACK_DEB_PACKAGE_COMPONENT)
   SET(CPACK_DEB_PACKAGE_COMPONENT_PART_NAME "")
   SET(CPACK_DEB_PACKAGE_COMPONENT_PART_PATH "")

Relationships

Notes
(0025891) Martin Konrad (reporter) 2011-03-23 18:00	Here is a patch that fixes the issue.

(0025892) Eric NOULARD (developer) 2011-03-23 18:09	I'll do that soon but I did push some rework on CPack Deb, RPM and Archive Generator today: http://public.kitware.com/Bug/view.php?id=11930 [^] So I may wait this branch to reach master before fixing it or I'll see whether if both patch may merge without trouble. Nevertheless thanks for the report and the patch.

(0025893) Eric NOULARD (developer) 2011-03-24 04:27	Fetching upstream next Merge topic 'fix12006-brokenPackageName' into next 33391c6 CPackDeb: Fix 0012006 broken package names

(0027340) David Cole (manager) 2011-09-05 11:37	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2011-03-23 17:56	Martin Konrad	New Issue
2011-03-23 17:57	Martin Konrad	File Added: 0001_CPackDeb_fix_broken_package_names.diff
2011-03-23 18:00	Martin Konrad	Note Added: 0025891
2011-03-23 18:05	Eric NOULARD	Assigned To	=> Eric NOULARD
2011-03-23 18:05	Eric NOULARD	Status	new => assigned
2011-03-23 18:06	Eric NOULARD	OS	=> Debian
2011-03-23 18:06	Eric NOULARD	Platform	=> Linux
2011-03-23 18:06	Eric NOULARD	Target Version	=> CMake 2.8.5
2011-03-23 18:09	Eric NOULARD	Note Added: 0025892
2011-03-24 04:27	Eric NOULARD	Note Added: 0025893
2011-03-24 04:27	Eric NOULARD	Status	assigned => resolved
2011-03-24 04:27	Eric NOULARD	Fixed in Version	=> CMake 2.8.5
2011-03-24 04:27	Eric NOULARD	Resolution	open => fixed
2011-09-05 11:37	David Cole	Status	resolved => closed
2011-09-05 11:37	David Cole	Note Added: 0027340