View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011338CMakeCMakepublic2010-10-19 18:132014-06-02 08:37
ReporterK. R. Walker 
Assigned ToStephen Kelly 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 3.0Fixed in VersionCMake 3.0 
Summary0011338: CMake adds CURRENT_SOURCE_DIR to include_directories if there is a VTK project.
DescriptionCMake adds CMAKE_CURRENT_SOURCE_DIR to the list of include directories if a project named VTK is added to a CMake solution.

cmLocalGenerator.cxx checks for the presence of VTK_SOURCE_DIR (which will be found in the cache if VTK or a project named VTK is part of the solution anywhere). If it's there, then it also looks for VTK_MAJOR_VERSION and VTK_MINOR_VERSION. If those aren't found (as they would not be in a parent scope of VTK, or a project that isn't actually building VTK), then the backwards compatibility "hack" is triggered and includeSourceDir is set to true.

Our current workaround is to change the VTK CMake to FORCE VTK_MAJOR_VERSION and VTK_MINOR_VERSION into the cache to prevent the hack from being encountered.
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0030525)
Brad King (manager)
2012-08-13 10:37

Sending issues I'm not actively working on to the backlog to await someone with time for them.

If an issue you care about is sent to the backlog when you feel it should have been addressed in a different manner, please bring it up on the CMake mailing list for discussion. Sign up for the mailing list here, if you're not already on it:

 http://www.cmake.org/mailman/listinfo/cmake [^]

It's easy to re-activate a bug here if you can find a CMake developer or contributor who has the bandwidth to take it on.
(0034331)
Stephen Kelly (developer)
2013-11-02 11:20

A policy should be added to CMake 3.0.0 to remove this hack.
(0034846)
Stephen Kelly (developer)
2013-12-21 05:07

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=db7d1112 [^]
(0036062)
Robert Maynard (manager)
2014-06-02 08:37

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2010-10-19 18:13 K. R. Walker New Issue
2010-10-20 11:28 Bill Hoffman Status new => assigned
2010-10-20 11:28 Bill Hoffman Assigned To => Brad King
2011-01-19 11:27 Brad King Relationship added has duplicate 0011722
2011-01-19 11:28 Brad King Relationship deleted has duplicate 0011722
2012-08-13 10:37 Brad King Status assigned => backlog
2012-08-13 10:37 Brad King Note Added: 0030525
2013-11-02 11:20 Stephen Kelly Note Added: 0034331
2013-11-02 11:20 Stephen Kelly Target Version => CMake 3.0
2013-12-21 05:07 Stephen Kelly Note Added: 0034846
2013-12-21 05:07 Stephen Kelly Status backlog => resolved
2013-12-21 05:07 Stephen Kelly Fixed in Version => CMake 3.0
2013-12-21 05:07 Stephen Kelly Resolution open => fixed
2013-12-21 05:07 Stephen Kelly Assigned To Brad King => Stephen Kelly
2014-06-02 08:37 Robert Maynard Note Added: 0036062
2014-06-02 08:37 Robert Maynard Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team