View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011249

CMake

Modules

public

2010-09-19 23:44

2010-11-09 22:57

Reporter

Philip Lowman

Assigned To

Philip Lowman

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake-2-8

Target Version

CMake 2.8.3

Fixed in Version

CMake 2.8.3

Summary

0011249: FindFLEX.cmake: Sends a CMake fatal error if flex execution fails or doesn't support --version flag

Description

As reported by Bill Hoffman:

In FindFLEX.cmake, you have this:
EXECUTE_PROCESS(COMMAND ${FLEX_EXECUTABLE} --version
   OUTPUT_VARIABLE FLEX_version_output
   ERROR_VARIABLE FLEX_version_error
   RESULT_VARIABLE FLEX_version_result
   OUTPUT_STRIP_TRAILING_WHITESPACE)
IF(NOT ${FLEX_version_result} EQUAL 0)
   MESSAGE(SEND_ERROR "Command \"${FLEX_EXECUTABLE} --version\" failed with output:\n${FLEX_version_error}")
ELSE()

So, if the flex that is found does not support the --version flag, or fails to run, it is always a fatal error. It should only be a fatal error if the find_package(FLEX REQUIRED) is given.

Tags

No tags attached.

Attached Files

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2010-09-19 23:44	Philip Lowman	New Issue
2010-09-19 23:45	Philip Lowman	Assigned To	=> Philip Lowman
2010-09-19 23:45	Philip Lowman	Status	new => assigned
2010-09-19 23:45	Philip Lowman	Target Version	=> CMake 2.8.3
2010-09-20 08:09	Philip Lowman	Status	assigned => resolved
2010-09-20 08:09	Philip Lowman	Fixed in Version	=> CMake 2.8.3
2010-09-20 08:09	Philip Lowman	Resolution	open => fixed
2010-11-09 22:57	Philip Lowman	Status	resolved => closed