View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010691CMakeModulespublic2010-05-09 11:272010-11-09 22:58
ReporterModestas Vainius 
Assigned ToPhilip Lowman 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformamd64OSDebian GNU/LinuxOS Versionsid
Product VersionCMake-2-8 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0010691: Find pangommconfig include directory in FindGTK2.cmake
DescriptionThere is a small bug in FindGTK2.cmake that makes the include dirs not set
properly when using pangomm. Pangomm has, like many of the other libraries, now
two include dirs, one for the arch specific 'config' header, and another dir
for the arch independent headers.
Additional InformationThe patch below applies op top of 2.8.1 and master branch.

From 035db011a472d1ff44fd5fdb2731f1973c6a550a Mon Sep 17 00:00:00 2001
From: Modestas Vainius <modestas@vainius.eu>
Date: Sun, 9 May 2010 18:20:41 +0300
Subject: [PATCH 2/2] Find pangommconfig include directory in FindGTK2.

There is a small bug in FindGTK2.cmake that makes the include dirs not set
properly when using pangomm. Pangomm has, like many of the other libraries, now
two include dirs, one for the arch specific 'config' header, and another dir
for the arch independent headers.

Author: Sune Vuorela <reportbug@pusling.com>
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579718 [^]
Origin: vendor, http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=cmake-find-gtk2-pangomm-config;att=1;bug=579718 [^]
Forwarded: yes
Last-Update: 2010-04-30
---
 Modules/FindGTK2.cmake | 1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Modules/FindGTK2.cmake b/Modules/FindGTK2.cmake
index c871417..202cfb6 100644
--- a/Modules/FindGTK2.cmake
+++ b/Modules/FindGTK2.cmake
@@ -439,6 +439,7 @@ foreach(_GTK2_component ${GTK2_FIND_COMPONENTS})
         _GTK2_FIND_LIBRARY (GTK2_CAIROMM_LIBRARY cairomm true true)
 
         _GTK2_FIND_INCLUDE_DIR(GTK2_PANGOMM_INCLUDE_DIR pangomm.h)
+ _GTK2_FIND_INCLUDE_DIR(GTK2_PANGOMMCONFIG_INCLUDE_DIR pangommconfig.h)
         _GTK2_FIND_LIBRARY (GTK2_PANGOMM_LIBRARY pangomm true true)
 
         _GTK2_FIND_INCLUDE_DIR(GTK2_SIGC++_INCLUDE_DIR sigc++/sigc++.h)
--
1.7.1



TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0021864)
Philip Lowman (developer)
2010-08-20 00:01

 I checked in this fix last week and it will be in CMake 2.8.3. Thank you for filing the bug ticket and attaching the patch.
(0022045)
Philip Lowman (developer)
2010-09-01 00:19

 Reopening to set "Target Release" / "Fixed In Version" fields

 Issue History
Date Modified Username Field Change
2010-05-09 11:27 Modestas Vainius New Issue
2010-08-20 00:00 Philip Lowman Status new => assigned
2010-08-20 00:00 Philip Lowman Assigned To => Philip Lowman
2010-08-20 00:01 Philip Lowman Note Added: 0021864
2010-08-20 00:01 Philip Lowman Status assigned => resolved
2010-08-20 00:01 Philip Lowman Resolution open => fixed
2010-09-01 00:19 Philip Lowman Note Added: 0022045
2010-09-01 00:19 Philip Lowman Status resolved => assigned
2010-09-01 00:19 Philip Lowman Target Version => CMake 2.8.3
2010-09-01 00:20 Philip Lowman Status assigned => resolved
2010-09-01 00:20 Philip Lowman Fixed in Version => CMake 2.8.3
2010-11-09 22:58 Philip Lowman Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team