MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009778CMakeCMakepublic2009-10-26 13:322016-06-10 14:31
Reporteraugiedoggie 
Assigned ToBill Hoffman 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0009778: minor changes to platform module for Haiku OS
DescriptionI have created a patch which changes a couple of minor things in the Haiku platform module.

1) It creates a HAIKU variable to go along with the BEOS variable. Since Haiku is source and binary compatible with BeOS, having it define BEOS is good, but, Haiku offers things that BeOS didn't. Having this variable would make it easier for projects to check for Haiku.

2) It overrides the default compile flags for a 'Release' build to remove the -O3 optimization flag. While Haiku does include both gcc2 and gcc4, the default will remain as gcc2 for at least a year or two. Since gcc2 is notorious for doing bad things with -O3, I think it should changed to -O2 by default. This problem has been known by BeOS developers for a very long time and they always avoid using this flag.

Is the platform module the appropriate place to override this? Or should there be an 'if' statement added to the gcc.cmake module?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff haiku_module.diff (891) 2009-10-26 13:32
https://public.kitware.com/Bug/file/2600/haiku_module.diff
Issue History
Date ModifiedUsernameFieldChange
2009-10-26 13:32augiedoggieNew Issue
2009-10-26 13:32augiedoggieFile Added: haiku_module.diff
2009-10-26 13:49augiedoggieNote Added: 0018241
2010-12-14 16:10David ColeAssigned To => Bill Hoffman
2010-12-14 16:10David ColeStatusnew => assigned
2016-06-10 14:27Kitware RobotNote Added: 0041607
2016-06-10 14:27Kitware RobotStatusassigned => resolved
2016-06-10 14:27Kitware RobotResolutionopen => moved
2016-06-10 14:31Kitware RobotStatusresolved => closed

Notes
(0018241)
augiedoggie   
2009-10-26 13:49   
As a side note unrelated to this ticket...

Would you like me to create a code cleanup patch for Haiku to remove some things that are no longer needed? The chances that someone would run into a problem with these changes is about 0.001%. Basically it would involve removing the ifdef checks where __BEOS__ and __HAIKU__ are both being tested for. gcc hasn't defined both of these variables for quite some time. Also you could remove the custom code for usleep(Haiku has this function) and the custom dynamic library code(Haiku uses dlopen as the basis for symbol loading). These aren't really hurting anything so it's a matter of whether you would like to remove this stuff or not.

In order for someone to be affected by this they would have to check out the old versions of both Haiku and the gcc2 compiler from the Haiku repository, build them, and then try to build cmake with these old versions.
(0041607)
Kitware Robot   
2016-06-10 14:27   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.