MantisBT - CMake
View Issue Details
0009031CMakeCPackpublic2009-05-14 10:392009-05-29 16:10
Eric NOULARD 
Alex Neundorf 
normalmajoralways
closedfixed 
CMake-2-6 
 
0009031: CPack RPM fails on Mandriva 2009.1 because of #% comment lines
Mandriva 2009.1 (Spring) which uses rpm 4.6.0
complains when used with current CMake 2-6 branch and/or HEAD
because the CPack RPM generated spec file contains comment line
beginning with
#%define and the like.

No tags attached.
patch bug9031-CPackRPM-erk1.patch (932) 2009-05-14 10:40
https://public.kitware.com/Bug/file/2244/bug9031-CPackRPM-erk1.patch
Issue History
2009-05-14 10:39Eric NOULARDNew Issue
2009-05-14 10:40Eric NOULARDFile Added: bug9031-CPackRPM-erk1.patch
2009-05-14 10:42Eric NOULARDNote Added: 0016438
2009-05-14 15:35Alex NeundorfNote Added: 0016445
2009-05-14 16:04Eric NOULARDNote Added: 0016451
2009-05-15 03:07Eric NOULARDNote Added: 0016469
2009-05-26 07:28Eric NOULARDNote Added: 0016566
2009-05-28 17:57Alex NeundorfStatusnew => assigned
2009-05-28 17:57Alex NeundorfAssigned To => Alex Neundorf
2009-05-29 16:10Alex NeundorfNote Added: 0016597
2009-05-29 16:10Alex NeundorfStatusassigned => closed
2009-05-29 16:10Alex NeundorfResolutionopen => fixed

Notes
(0016438)
Eric NOULARD   
2009-05-14 10:42   
Provided patch replaced '#%' with '#p ' which seems to calm down
Mandriva 2009.1 rpm 4.6.0 error.

(note that the very same version of rpm tool on Fedora Core 10
 did not complain about that!!)
(0016445)
Alex Neundorf   
2009-05-14 15:35   
Aren't these lines just comments anyway ?
Which meaning do #% and #p have exactly ?

Alex
(0016451)
Eric NOULARD   
2009-05-14 16:04   
These are effectively comment line but I think they deserves
to stay here as a reminder.
They should normally be there in a "classical" spec file.

the

%<something>

are classical spec file directives.

#<whatever ...>

is a comment line.

Some of the %<directive> were commented because the CPack RPM spec
is somehow a "shortcutted" spec:

no build --> %build --> #%build
no install --> %install --> #%install

since Mandriva rpm 4.6.0 was complaining about #% combination
I did simply search and replace
#%
by
# p

p == percent.

Those lines may be safely removed but I'd like to keep them:

 1) Because most of the time no-one reads the generated
    spec file besides me (or curious people).
    Thus the uglyness of those line are not read very often.

 2) because it helps me (or potential contributor) to
    keep track of "classical" spec file %<directive>
(0016469)
Eric NOULARD   
2009-05-15 03:07   
Last small note.
If you'd rather throw away comment lines with #% / #p
that's fine for me.
My memory is not that bad and,
they will remain in the CVS history, so it's
"as-you-like"
(0016566)
Eric NOULARD   
2009-05-26 07:28   
Ping.

Alex,
What do you want me to do?
Do you want another patch with "# p" lines removed?
(0016597)
Alex Neundorf   
2009-05-29 16:10   
Patch committed to HEAD, thanks.

Alex