Notes |
|
(0016438)
|
Eric NOULARD
|
2009-05-14 10:42
|
|
Provided patch replaced '#%' with '#p ' which seems to calm down
Mandriva 2009.1 rpm 4.6.0 error.
(note that the very same version of rpm tool on Fedora Core 10
did not complain about that!!) |
|
|
(0016445)
|
Alex Neundorf
|
2009-05-14 15:35
|
|
Aren't these lines just comments anyway ?
Which meaning do #% and #p have exactly ?
Alex |
|
|
(0016451)
|
Eric NOULARD
|
2009-05-14 16:04
|
|
These are effectively comment line but I think they deserves
to stay here as a reminder.
They should normally be there in a "classical" spec file.
the
%<something>
are classical spec file directives.
#<whatever ...>
is a comment line.
Some of the %<directive> were commented because the CPack RPM spec
is somehow a "shortcutted" spec:
no build --> %build --> #%build
no install --> %install --> #%install
since Mandriva rpm 4.6.0 was complaining about #% combination
I did simply search and replace
#%
by
# p
p == percent.
Those lines may be safely removed but I'd like to keep them:
1) Because most of the time no-one reads the generated
spec file besides me (or curious people).
Thus the uglyness of those line are not read very often.
2) because it helps me (or potential contributor) to
keep track of "classical" spec file %<directive> |
|
|
(0016469)
|
Eric NOULARD
|
2009-05-15 03:07
|
|
Last small note.
If you'd rather throw away comment lines with #% / #p
that's fine for me.
My memory is not that bad and,
they will remain in the CVS history, so it's
"as-you-like" |
|
|
(0016566)
|
Eric NOULARD
|
2009-05-26 07:28
|
|
Ping.
Alex,
What do you want me to do?
Do you want another patch with "# p" lines removed? |
|
|
(0016597)
|
Alex Neundorf
|
2009-05-29 16:10
|
|
Patch committed to HEAD, thanks.
Alex
|
|