MantisBT - ITK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0008990ITKpublic2009-05-09 03:392010-10-21 14:17
ReporterDaniel Mueller 
Assigned Toxiaoxiao 
PrioritynormalSeverityminorReproducibilityalways
StatusassignedResolutionopen 
PlatformOSOS Version
Product VersionITK-3-12 
Target VersionFixed in Version 
Resolution Date
Sprint
Sprint Status
Summary0008990: FastMarchingImageFilter does not correctly handle adjacent trial points
DescriptionIn itkFastMarchingImageFilter.txx the UpdateNeighbors method checks if the candidate neighbour is an alive point. If so, then it is skipped from further processing. If not, then it is processed (ie. output value updated). This method should also test if the candidate neighbour is a *trial* point. If it is a trial point, then the output value has already been set, and does not need to be updated. Doing so will actually produce incorrect values.

See attached patch.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch itkFastMarchingImageFilter.txx.patch (284) 2009-05-09 03:39
https://public.kitware.com/Bug/file/2227/itkFastMarchingImageFilter.txx.patch
patch FastMarching.patch (2,516) 2009-05-14 14:17
https://public.kitware.com/Bug/file/2248/FastMarching.patch
Issue History
Date ModifiedUsernameFieldChange
2009-05-09 03:39Daniel MuellerNew Issue
2009-05-09 03:39Daniel MuellerFile Added: itkFastMarchingImageFilter.txx.patch
2009-05-09 03:41Daniel MuellerNote Added: 0016360
2009-05-09 14:25Daniel MuellerNote Added: 0016361
2009-05-14 14:17Daniel MuellerFile Added: FastMarching.patch
2009-05-14 14:18Daniel MuellerNote Added: 0016443
2010-01-13 09:16lantigaStatusnew => assigned
2010-01-13 09:16lantigaAssigned To => lantiga
2010-04-23 03:16lantigaNote Added: 0020370
2010-04-23 03:19lantigaNote Added: 0020371
2010-10-21 14:16Hans JohnsonAssigned Tolantiga => xiaoxiao
2010-10-21 14:17Hans JohnsonNote Added: 0022645

Notes
(0016360)
Daniel Mueller   
2009-05-09 03:41   
See: http://www.itk.org/pipermail/insight-users/2009-May/030279.html [^]
(0016361)
Daniel Mueller   
2009-05-09 14:25   
The patch attached to this bug is not the full story.

See: http://www.itk.org/pipermail/insight-users/2009-May/030282.html [^]

> Hi Dan,
> shouldn't you check if the update value computed for the trial point
> is smaller than the already existing value for that trial point and if
> so update it regardless?
>
> Luca
(0016443)
Daniel Mueller   
2009-05-14 14:18   
See FastMarching.patch for a more complete solution
(0020370)
lantiga   
2010-04-23 03:16   
The fix has been committed Jan 13 2010. The bug report has been left open until a test for the issue has been submitted.
(0020371)
lantiga   
2010-04-23 03:19   
The fix has been committed Jan 13 2010. The bug report has been left open to remind that further testing is necessary.
(0022645)
Hans Johnson   
2010-10-21 14:17   
We just need to add a test for this case.