MantisBT - CMake |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0008707 | CMake | CMake | public | 2009-03-09 18:54 | 2013-10-21 11:22 |
|
Reporter | Pau Garcia i Quiles | |
Assigned To | David Cole | |
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | fixed | |
Platform | | OS | | OS Version | |
Product Version | CMake-2-6 | |
Target Version | CMake 2.8.6 | Fixed in Version | CMake 2.8.6 | |
|
Summary | 0008707: Add support for global variables in Visual Studio generator |
Description | The attached patch against CVS adds support for SET_TARGET_PROPERTIES( thetarget PROPERTIES VS_GLOBAL_<variable> value ) in the Visual Studio generator. That creates this section in the .vcproj:
<Global
Name="QtVersion"
Value="4.5.0"
/>
It's useful for the Qt integration.
|
Steps To Reproduce | |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | 0013666 | closed | | CMake fails to support existing custom VS_GLOBAL_* properties in VS10 (ProjectExtensions -> VisualStudio -> UserProperties) | related to | 0014493 | closed | Brad King | Document relationship of VS_KEYWORD and VS_GLOBAL_KEYWORD |
|
Attached Files | vs_global.diff (4,407) 2009-03-09 18:54 https://public.kitware.com/Bug/file/2114/vs_global.diff
vs_global_2.8.1rc1.diff (4,393) 2010-02-08 16:49 https://public.kitware.com/Bug/file/2851/vs_global_2.8.1rc1.diff |
|
Issue History |
Date Modified | Username | Field | Change |
2009-03-09 18:54 | Pau Garcia i Quiles | New Issue | |
2009-03-09 18:54 | Pau Garcia i Quiles | File Added: vs_global.diff | |
2009-03-09 19:08 | Pau Garcia i Quiles | Note Added: 0015613 | |
2009-11-23 09:17 | Pau Garcia i Quiles | Note Added: 0018545 | |
2010-02-08 16:49 | Pau Garcia i Quiles | File Added: vs_global_2.8.1rc1.diff | |
2010-02-08 16:50 | Pau Garcia i Quiles | Note Added: 0019486 | |
2010-12-14 15:36 | David Cole | Status | new => assigned |
2010-12-14 15:36 | David Cole | Assigned To | => David Cole |
2011-07-12 19:17 | Pau Garcia i Quiles | Note Added: 0027033 | |
2011-07-27 12:31 | David Cole | Note Added: 0027079 | |
2011-07-27 12:31 | David Cole | Target Version | => CMake 2.8.6 |
2011-07-29 11:34 | David Cole | Note Added: 0027115 | |
2011-07-29 11:34 | David Cole | Status | assigned => resolved |
2011-07-29 11:34 | David Cole | Fixed in Version | => CMake 2.8.6 |
2011-07-29 11:34 | David Cole | Resolution | open => fixed |
2012-01-02 15:56 | David Cole | Note Added: 0028108 | |
2012-01-02 15:56 | David Cole | Status | resolved => closed |
2012-11-09 08:18 | Brad King | Relationship added | related to 0013666 |
2013-10-21 11:22 | Brad King | Relationship added | related to 0014493 |
Notes |
|
(0015613)
|
Pau Garcia i Quiles
|
2009-03-09 19:08
|
|
(copy and paste from my e-mail to the list)
I have created issue 0008707 in the bugtracker and attached the patch there. It's modelled after XCODE_ATTRIBUTE_<an-attribute>.
The patch adds support for:
SET_TARGET_PROPERTIES( thetarget PROPERTIES VS_GLOBAL_<variable> value )
For instance:
SET_TARGET_PROPERTIES( thetarget PROPERTIES VS_GLOBAL_QtVersion ${QTVERSION} )
creates this section in the .vcproj:
<Global
Name="QtVersion"
Value="4.5.0"
/>
If I have understood correctly the XSD schema for vcproj files ( http://msdn.microsoft.com/en-us/library/y4sy8216.aspx [^] ), global variables with an empty name are allowed (it would probably be more correct to say they are not prohibited), so this patch allows them although I think that's just a mistake in the XSD and CMake should not create something like:
SET_TARGET_PROPERTIES( thetarget PROPERTIES VS_GLOBAL_ "blah" )
<Global
Name=""
Value="blah"
/> |
|
|
(0018545)
|
Pau Garcia i Quiles
|
2009-11-23 09:17
|
|
What's the status on this? It's a fairly trivial patch but it makes a great difference when using CMake + Qt4 + Visual Studio |
|
|
(0019486)
|
Pau Garcia i Quiles
|
2010-02-08 16:50
|
|
vs_global_2.8.1rc1.diff is the patch rebased to 2.8.1RC1. I don't know how to remove the old patch from the bug report. |
|
|
(0027033)
|
Pau Garcia i Quiles
|
2011-07-12 19:17
|
|
Any chance this will ever be included in CMake? |
|
|
(0027079)
|
David Cole
|
2011-07-27 12:31
|
|
Yes, there is a chance... |
|
|
(0027115)
|
David Cole
|
2011-07-29 11:34
|
|
|
|
(0028108)
|
David Cole
|
2012-01-02 15:56
|
|
Closing resolved issues that have not been updated in more than 4 months. |
|