MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0008649CMakeCPackpublic2009-03-02 06:062016-06-10 14:30
ReporterJan Peciva 
Assigned ToBill Hoffman 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product VersionCMake-2-6 
Target VersionFixed in Version 
Summary0008649: CPack fails to install when "Do not create shortcuts"
DescriptionThe problem is related to CPACK_NSIS_EXTRA_INSTALL_COMMANDS that allows to run custom application to finish installation. However, if I click "Do not create shortcuts" in Start Menu during the installation process, this command is not executed.

I consider it a bug. Installation of Start Menu items must be independent on the core installation procedure. Idea of not-finalizing application installation because I did not wanted start menu items seems really bad to me.

Please consider to change the behavior that is definitely buggy.
I investigated solution and attaching correct NSIS.template.in
The trick to fix it is just to swap these two lines:

  @CPACK_NSIS_EXTRA_INSTALL_COMMANDS@

  !insertmacro MUI_STARTMENU_WRITE_END

to

  !insertmacro MUI_STARTMENU_WRITE_END

  @CPACK_NSIS_EXTRA_INSTALL_COMMANDS@

Quick explanation: If CPACK_NSIS_EXTRA_INSTALL_COMMANDS is in the block MUI_STARTMENU_WRITE, it is mistakenly excluded from execution when "Do not create shortcuts" is checked.

Thanks for fix.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? NSIS.template.in (18,373) 2009-03-02 06:06
https://public.kitware.com/Bug/file/2081/NSIS.template.in
Issue History
Date ModifiedUsernameFieldChange
2009-03-02 06:06Jan PecivaNew Issue
2009-03-02 06:06Jan PecivaFile Added: NSIS.template.in
2009-03-02 09:13Bill HoffmanStatusnew => assigned
2009-03-02 09:13Bill HoffmanAssigned To => David Cole
2009-08-19 08:59Mikko VainioNote Added: 0017159
2009-10-02 09:01pcjohnNote Added: 0017896
2009-10-04 16:32David ColeAssigned ToDavid Cole => Bill Hoffman
2009-10-04 16:33David ColeNote Added: 0017939
2016-06-10 14:27Kitware RobotNote Added: 0041508
2016-06-10 14:27Kitware RobotStatusassigned => resolved
2016-06-10 14:27Kitware RobotResolutionopen => moved
2016-06-10 14:30Kitware RobotStatusresolved => closed

Notes
(0017159)
Mikko Vainio   
2009-08-19 08:59   
FYI, the fix above worked for me on Windows XP SP3 using CMake 2.6.4.
(0017896)
pcjohn   
2009-10-02 09:01   
Any chance to get it fixed?
(0017939)
David Cole   
2009-10-04 16:33   
Fixed in CVS HEAD of CMake.

/cvsroot/CMake/CMake/Modules/NSIS.template.in,v <-- Modules/NSIS.template.in
new revision: 1.39; previous revision: 1.38

Assigned to Bill to merge to the CMake-2-8 branch.
(0041508)
Kitware Robot   
2016-06-10 14:27   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.