MantisBT - CMake |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0008529 | CMake | Modules | public | 2009-02-12 23:45 | 2010-11-09 22:57 |
|
| Reporter | Philip Lowman | |
| Assigned To | Philip Lowman | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | CMake-2-6 | |
| Target Version | CMake 2.8.3 | Fixed in Version | CMake 2.8.3 | |
|
| Summary | 0008529: FindBoost is unable to detect Boost libraries compiled against STLport |
| Description | As reported on the CMake mailing list, FindBoost is unable to detect Boost libraries compiled against STLport.
http://www.boost.org/doc/libs/1_38_0/more/getting_started/windows.html#library-naming [^] |
| Steps To Reproduce | |
| Additional Information | Filenames:
boost_date_time-vc80-mt-gdp-1_38.dll
boost_date_time-vc80-mt-gdp-1_38.lib
boost_date_time-vc80-mt-gdp.lib
boost_date_time-vc80-mt-p-1_38.dll
boost_date_time-vc80-mt-p-1_38.lib
boost_date_time-vc80-mt-p.lib
boost_thread-vc80-mt-gdp-1_38.dll
boost_thread-vc80-mt-gdp-1_38.lib
boost_thread-vc80-mt-gdp.lib
boost_thread-vc80-mt-p-1_38.dll
boost_thread-vc80-mt-p-1_38.lib
boost_thread-vc80-mt-p.lib
libboost_date_time-vc80-mt-gdp-1_38.lib
libboost_date_time-vc80-mt-gdp.lib
libboost_date_time-vc80-mt-p-1_38.lib
libboost_date_time-vc80-mt-p.lib
libboost_date_time-vc80-mt-sgdp-1_38.lib
libboost_date_time-vc80-mt-sgdp.lib
libboost_date_time-vc80-mt-sp-1_38.lib
libboost_date_time-vc80-mt-sp.lib
libboost_date_time-vc80-sgdp-1_38.lib
libboost_date_time-vc80-sgdp.lib
libboost_date_time-vc80-sp-1_38.lib
libboost_date_time-vc80-sp.lib
libboost_thread-vc80-mt-gdp-1_38.lib
libboost_thread-vc80-mt-gdp.lib
libboost_thread-vc80-mt-p-1_38.lib
libboost_thread-vc80-mt-p.lib
libboost_thread-vc80-mt-sgdp-1_38.lib
libboost_thread-vc80-mt-sgdp.lib
libboost_thread-vc80-mt-sp-1_38.lib
libboost_thread-vc80-mt-sp.lib |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  FindBoost.cmake.diff (1,186) 2009-02-13 08:44
https://public.kitware.com/Bug/file/2053/FindBoost.cmake.diff
 FindBoost.cmake (48,989) 2010-09-08 00:27
https://public.kitware.com/Bug/file/3361/FindBoost.cmake |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2009-02-12 23:45 | Philip Lowman | New Issue | |
| 2009-02-13 08:44 | Mike Jackson | File Added: FindBoost.cmake.diff | |
| 2009-02-13 08:45 | Mike Jackson | Note Added: 0014924 | |
| 2009-02-13 09:40 | Philip Lowman | Note Added: 0014926 | |
| 2009-07-18 10:49 | Philip Lowman | Status | new => assigned |
| 2009-07-18 10:49 | Philip Lowman | Assigned To | => Philip Lowman |
| 2010-09-08 00:27 | Philip Lowman | Note Added: 0022124 | |
| 2010-09-08 00:27 | Philip Lowman | File Added: FindBoost.cmake | |
| 2010-09-10 08:42 | Philip Lowman | ETA | none => < 1 day |
| 2010-09-10 08:42 | Philip Lowman | Target Version | => CMake 2.8.3 |
| 2010-09-12 22:28 | Philip Lowman | Note Added: 0022195 | |
| 2010-09-12 22:28 | Philip Lowman | Status | assigned => resolved |
| 2010-09-12 22:28 | Philip Lowman | Fixed in Version | => CMake 2.8.3 |
| 2010-09-12 22:28 | Philip Lowman | Resolution | open => fixed |
| 2010-11-09 22:57 | Philip Lowman | Status | resolved => closed |
|
Notes |
|
|
(0014924)
|
|
Mike Jackson
|
|
2009-02-13 08:45
|
|
|
Patch attached. Please try this out. |
|
|
|
(0014926)
|
|
Philip Lowman
|
|
2009-02-13 09:40
|
|
I considered the same patch. Because _boost_ABI_TAG is not used during RELEASE you would miss this case below:
boost_thread-vc80-mt-p-1_38.lib
boost_thread-vc80-mt-p.lib
One approach would be to make _boost_ABI_TAG be what it should be, the ABI tags, and get rid of _boost_STATIC_TAG. I haven't done much work here but I was thinking building up two versions of the ABI_TAG, one for RELEASE and one for DEBUG incrementally in the order the options are defined by Boost...
set( _boost_ABI_TAG "-")
set( _boost_ABI_TAG_DEBUG "-")
# Build the ABI tag in the following order
# "s" => linking statically to the C++ standard library and compiler
# runtime support libraries (MSVC)
if(WIN32 AND Boost_USE_STATIC_LIBS )
set( _boost_ABI_TAG "${_boost_ABI_TAG}s")
set( _boost_ABI_TAG_DEBUG "${_boost_ABI_TAG_DEBUG}s")
endif()
# "g" => using debug versions of the standard and runtime support
# libraries
if(WIN32 AND MSVC)
set( _boost_ABI_TAG_DEBUG "${_boost_ABI_TAG_DEBUG}g")
endif()
# "y" => using special debug build of Python
# libraries
etc.
Then the actual find_library check could be simplified and the code would also be far more readable. Please feel free to complete the patch if you like this approach and have time. |
|
|
|
(0022124)
|
|
Philip Lowman
|
|
2010-09-08 00:27
|
|
|
I have implemented the approach I suggested on 2009-02-13 primarily to fix another issue (0011160). Adding support for STLport was trivial. Attached is a preliminary version for testing. |
|
|
|
(0022195)
|
|
Philip Lowman
|
|
2010-09-12 22:28
|
|
|
Fix will be in CMake 2.8.3 RC1 |
|