MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007318CMakeModulespublic2008-07-09 12:272016-06-10 14:30
ReporterMatt Leotta 
Assigned ToKitware Robot 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionmoved 
PlatformOSOS Version
Product VersionCMake-2-6 
Target VersionFixed in Version 
Summary0007318: Request for addition of FindDC1394.cmake module
DescriptionThis module has been used in VXL for finding libdc1394 version 2. This library provides drivers for IEEE 1394 (firewire) digital cameras conforming to the IIDC specs. The code runs on Linux, OS X, and will run on Windows in the future.

http://sourceforge.net/projects/libdc1394/ [^]
Steps To Reproduce
Additional InformationAttached is the module currently in use with VXL. It may or may not fully meet the standards for writing CMake modules, but it does work in Linux and OS X.

This module is for finding version 2 of the code, version 2 is incompatible with version 1 so maybe it should be FindDC1394-2.cmake or something like that? I'm not sure about your naming conventions.

I am willing to become a maintainer for this module if necessary.
TagsNo tags attached.
Relationships
Attached Files? FindDC1394.cmake (762) 2008-07-09 12:27
https://public.kitware.com/Bug/file/1589/FindDC1394.cmake
? FindDC1394.patch1 (1,171) 2008-07-21 16:46
https://public.kitware.com/Bug/file/1613/FindDC1394.patch1
Issue History
Date ModifiedUsernameFieldChange
2008-07-09 12:27Matt LeottaNew Issue
2008-07-09 12:27Matt LeottaFile Added: FindDC1394.cmake
2008-07-21 13:04Alex NeundorfNote Added: 0012774
2008-07-21 16:46Matt LeottaFile Added: FindDC1394.patch1
2008-07-21 16:50Matt LeottaNote Added: 0012781
2008-08-19 16:50Bill HoffmanStatusnew => assigned
2008-08-19 16:50Bill HoffmanAssigned To => Alex Neundorf
2008-10-13 12:41Matt LeottaNote Added: 0013861
2010-08-24 17:12Enrique FdezNote Added: 0021935
2011-03-10 15:28Alex NeundorfNote Added: 0025748
2011-03-11 14:18Enrique FdezNote Added: 0025761
2011-03-12 14:53Alex NeundorfNote Added: 0025764
2012-01-04 16:05Alex NeundorfNote Added: 0028175
2012-01-04 16:05Alex NeundorfAssigned ToAlex Neundorf =>
2012-01-04 16:05Alex NeundorfStatusassigned => backlog
2016-06-10 14:27Kitware RobotNote Added: 0041440
2016-06-10 14:27Kitware RobotStatusbacklog => resolved
2016-06-10 14:27Kitware RobotResolutionopen => moved
2016-06-10 14:27Kitware RobotAssigned To => Kitware Robot
2016-06-10 14:30Kitware RobotStatusresolved => closed

Notes
(0012774)
Alex Neundorf   
2008-07-21 13:04   
Hi,

thanks a lot for the file, here are some comments:

You don't need to list these directories, they are in the default set of search directories (see Modules/Platform/UnixPaths.cmake)

Also it would be nice if you would use the macro FIND_PACKAGE_HANDLE_STANDARD_ARGS() from the FindPackageHandleStandardArgs.cmake file. Can you post a modified patch and make sure it works with cmake 2.6 ?

Thanks
Alex
(0012781)
Matt Leotta   
2008-07-21 16:50   
Alex,

Thanks for the advice. I've posted the patch. It works with cmake 2.6 (for me). I'll patch the other modules I've recently submitted in a similar way, but I'll be away for a week so it might not get done right away.

Thanks,
Matt
(0013861)
Matt Leotta   
2008-10-13 12:41   
I've just discovered that dc1394 has some additional framework dependencies on Mac OS X. The module should probably also contain something like the following:


# Find Apple Framework dependencies
IF(APPLE AND DC1394_FOUND)
  SET(DC1394_LIBRARIES ${DC1394_LIBRARIES}
                       "-framework CoreFoundation"
                       "-framework IOKit" )
ENDIF(APPLE AND DC1394_FOUND)


Also, I am a module developer now, so if you want me to handle this just have this issue reassigned to me.
(0021935)
Enrique Fdez   
2010-08-24 17:12   
Actually, the code above doesn't work in Mac OS X 10.6. You only need CoreServices framework, not the other two. See comment here:
http://blog.gmane.org/gmane.comp.multimedia.libdc1394.devel/month=20091001 [^]

I've tested it and works perfectly. This is the cmake code:
# Find Apple Framework dependencies
IF(APPLE AND DC1394_FOUND)
  SET(DC1394_LIBRARIES ${DC1394_LIBRARIES}
                       "-framework CoreServices" )
ENDIF(APPLE AND DC1394_FOUND)

Not sure what happens in other version of OS X.
I hope this information will be useful and I'd like that cmake includes one FindDC1394.cmake or similar.
Thanks for your work and comments.
(0025748)
Alex Neundorf   
2011-03-10 15:28   
In order to get this into cmake, somebody, e.g. you, need to volunteer to maintain it in cmake: http://www.vtk.org/Wiki/CMake:Module_Maintainers [^]

Alex
(0025761)
Enrique Fdez   
2011-03-11 14:18   
If there's enough interest, I'll try to maintain this module.

Enrique
(0025764)
Alex Neundorf   
2011-03-12 14:53   
Sounds good :-)
So please follow the steps described here: http://www.cmake.org/pipermail/cmake/2007-July/015258.html [^]

You'll get git push access then etc.

Alex
(0028175)
Alex Neundorf   
2012-01-04 16:05   
So, as written above, please follow the steps as described here:
 http://www.cmake.org/pipermail/cmake/2007-July/015258.html [^]

This way you'll become the maintainer of this module in cmake.

I won't add it myself, because I'm not using it. So I'm unassigning it from me.

Alex
(0041440)
Kitware Robot   
2016-06-10 14:27   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.