MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007285CMakeModulespublic2008-07-04 13:192016-06-10 14:30
ReporterMiguel Figueroa 
Assigned ToMiguel Figueroa 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product VersionCMake-2-6 
Target VersionFixed in Version 
Summary0007285: Fix for FindXMLRPC to obey REQUIRED keyword
DescriptionReported by Alexander Bubnov:

http://www.cmake.org/pipermail/cmake/2008-July/022616.html [^]

I have attached a patch to fix this, please apply or send me a note to do so myself.

--Miguel
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch FindXMLRPC.cmake.patch (3,247) 2008-07-04 13:19
https://public.kitware.com/Bug/file/1577/FindXMLRPC.cmake.patch
Issue History
Date ModifiedUsernameFieldChange
2008-07-04 13:19Miguel FigueroaNew Issue
2008-07-04 13:19Miguel FigueroaFile Added: FindXMLRPC.cmake.patch
2008-08-19 16:53Bill HoffmanStatusnew => assigned
2008-08-19 16:53Bill HoffmanAssigned To => Bill Hoffman
2008-08-19 16:53Bill HoffmanAssigned ToBill Hoffman => Miguel Figueroa
2008-08-19 16:53Bill HoffmanNote Added: 0013088
2008-08-19 18:12Miguel FigueroaNote Added: 0013093
2008-08-19 21:53Bill HoffmanNote Added: 0013098
2008-08-19 21:54Bill HoffmanNote Added: 0013099
2016-06-10 14:27Kitware RobotNote Added: 0041437
2016-06-10 14:27Kitware RobotStatusassigned => resolved
2016-06-10 14:27Kitware RobotResolutionopen => moved
2016-06-10 14:30Kitware RobotStatusresolved => closed

Notes
(0013088)
Bill Hoffman   
2008-08-19 16:53   
Why is the patch so big? Seems like it should only have:

+INCLUDE(FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(
+ XMLRPC "${FAIL_MSG}" XMLRPC_C_CONFIG XMLRPC_INCLUDE_DIRS XMLRPC_LIBRARIES XMLRPC_FOUND)
(0013093)
Miguel Figueroa   
2008-08-19 18:12   
IIRC, the process was printing an error message at each iteration if a component wasn't found. So, I'm basically collecting this error message if any and let find_package_handle_standard_args handle it. Note that if QUIET was passed, then no message should be printed.

I also removed a piece of code that was setting XMLRPC_FOUND, since this is supposed to be set by find_package_handle_standard_args. This required the condition in the IF to be changed.

Finally, XMLRPC_<component>_FOUND variables were set as required by the standard.

So, should I commit this?

--Miguel
(0013098)
Bill Hoffman   
2008-08-19 21:53   
Sure as long as you test it.
(0013099)
Bill Hoffman   
2008-08-19 21:54   
OH, and I assume it still sets the same variables as it did before so it does not break backwards compatibility right? Thanks for helping with the modules!
(0041437)
Kitware Robot   
2016-06-10 14:27   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.