MantisBT - CDash
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0006641CDashpublic2008-03-22 11:142008-05-17 22:25
ReporterTrevor Kellaway 
Assigned ToJulien Jomier 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version1.0 
Summary0006641: Supporting other update/diff viewers (Trac+SVN)
DescriptionCdash currently doesn't have support for other styles of update/diff viewers apart from ViewCVS. Would it be possible to add a new database option for a viewer name, so additional viewers can be added in the future?

I use the Trac (wiki) which has an SVN viewer, this requires the following style update URL:

    "http://" [^] . $projecturl . $directory . $file . "?rev=" . $revision;

I've locally hacked common.php get_viewcvs_diff_url(), but it would nice be able to modify get_diff_url() to be able to call new functions like get_tracsvn_diff_url() based on project configuration.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch r785.patch (417) 2008-03-29 13:10
https://public.kitware.com/Bug/file/1374/r785.patch
patch r788.patch (581) 2008-03-29 14:10
https://public.kitware.com/Bug/file/1375/r788.patch
Issue History
Date ModifiedUsernameFieldChange
2008-03-22 11:14Trevor KellawayNew Issue
2008-03-23 17:50Julien JomierStatusnew => assigned
2008-03-23 17:50Julien JomierAssigned To => Julien Jomier
2008-03-23 17:53Julien JomierNote Added: 0010883
2008-03-24 08:06Trevor KellawayNote Added: 0010884
2008-03-24 08:15Julien JomierNote Added: 0010885
2008-03-26 18:06Julien JomierStatusassigned => closed
2008-03-26 18:06Julien JomierNote Added: 0010924
2008-03-26 18:06Julien JomierResolutionopen => fixed
2008-03-26 18:06Julien JomierFixed in Version => 1.0
2008-03-29 12:35Trevor KellawayStatusclosed => feedback
2008-03-29 12:35Trevor KellawayResolutionfixed => reopened
2008-03-29 12:35Trevor KellawayNote Added: 0010974
2008-03-29 12:36Trevor KellawayNote Edited: 0010974
2008-03-29 12:36Trevor KellawayNote Edited: 0010974
2008-03-29 12:38Trevor KellawayNote Edited: 0010974
2008-03-29 12:42Julien JomierNote Added: 0010975
2008-03-29 12:42Trevor KellawayNote Edited: 0010974
2008-03-29 13:10Trevor KellawayFile Added: r785.patch
2008-03-29 13:11Trevor KellawayNote Added: 0010977
2008-03-29 13:19Julien JomierNote Added: 0010978
2008-03-29 14:10Trevor KellawayFile Added: r788.patch
2008-03-29 14:11Trevor KellawayNote Added: 0010979
2008-03-29 14:23Julien JomierNote Added: 0010980
2008-05-17 22:25Julien JomierStatusfeedback => closed
2008-05-17 22:25Julien JomierResolutionreopened => fixed

Notes
(0010883)
Julien Jomier   
2008-03-23 17:53   
Trevor, is there a way to detect if the SVN viewer is Trac from the URL? I'm just wondering if we should add a new entry in the database or if there is a way to detect the right URL to use without it. Thanks.
(0010884)
Trevor Kellaway   
2008-03-24 08:06   
Julien,

I don't think there is an entirely reliable way of doing this, a typical URL is:

 http://.../trac/.../browser/trunk/sw/source/app/CMakeLists.txt?rev=1234 [^]

You could look for "/trac/" in the URL, but the user could have changed this in their Apache config, or you could use "/browser/".

However I think this approach is inflexible for the future, it would be much nicer to add support for future viewers in a more flexible way, but I assume that will break the existing projects databases?
(0010885)
Julien Jomier   
2008-03-24 08:15   
That makes sense. Adding new fields in the database is not that tricky. I think adding the extra field is the best. Thanks!
(0010924)
Julien Jomier   
2008-03-26 18:06   
This is fixed in SVN and will be part of the 1.0 release.
(0010974)
Trevor Kellaway   
2008-03-29 12:35   
(edited on: 2008-03-29 12:42)
Julien,

Thanks for adding this, but I have problems. My old projects now tell me to update my database, if I go to createProject.php and try and "Update Project" I get the following appearing as the first line of the generated HTML "Unknown column 'cvsviewertype' in 'field list'"

I know virtually zero about MySQL, but I don't see any "cvsviewertype" in the new cdash-upgrade-0-0.8.sql?

Also, if I try creating a new project I get the same error.

It looks like the upgrade isn't working, an I doing this wrong?

[Later] Creating a new mysql database from scratch also suffers the same problem.

[Later] OK, it is working now, you need to run the Backward Compatibility tool from here backwardCompatibilityTools.php. The fact "Edit Project" has an "Update Project" button is bound to confuse people like me!
(0010975)
Julien Jomier   
2008-03-29 12:42   
Trevor,

You need to log as the administrator in CDash and go to the 'Backward Compatibility Tools' and click on 'Upgrade CDash' and that should do it.

I had forgotten to add the SQL description when you install CDash from scratch. Thanks for the report :)

Let me know if you find any other issues.
(0010977)
Trevor Kellaway   
2008-03-29 13:11   
Julien,

Windows updates seem to pass backslashes rather than forward slashes, attached patch r785.patch fixes this.
(0010978)
Julien Jomier   
2008-03-29 13:19   
Thanks! I have added the patch. Did the upgrade worked?
(0010979)
Trevor Kellaway   
2008-03-29 14:11   
Julien,

Yes, the upgrade worked OK.

New r788.patch attached, this copes with potentially empty $directory update URLs for Trac.
(0010980)
Julien Jomier   
2008-03-29 14:23   
Patch has been applied. Thanks!