MantisBT - CMake
View Issue Details
0006583CMakeCTestpublic2008-03-10 17:472008-06-06 09:14
Orion E. Poplawski 
Bill Hoffman 
normalmajoralways
closedfixed 
 
 
0006583: CTest fails to compute correct Nightly sync time
This seems to be a duplicate of 0001924, but I'm seeing it now with cmake 2.4.8 on Fedora 8. I'm hoping that since this has been addressed before, a fix would be easy to come by.
No tags attached.
Issue History
2008-03-10 17:47Orion E. PoplawskiNew Issue
2008-03-10 17:56Bill HoffmanNote Added: 0010763
2008-03-10 18:22Orion E. PoplawskiNote Added: 0010764
2008-03-13 11:04Bill HoffmanNote Added: 0010787
2008-03-13 11:05Bill HoffmanStatusnew => closed
2008-03-13 11:05Bill HoffmanResolutionopen => no change required
2008-03-13 14:01Orion E. PoplawskiStatusclosed => feedback
2008-03-13 14:01Orion E. PoplawskiResolutionno change required => reopened
2008-03-13 14:01Orion E. PoplawskiNote Added: 0010792
2008-03-27 22:11Bill HoffmanStatusfeedback => assigned
2008-03-27 22:11Bill HoffmanAssigned To => Bill Hoffman
2008-06-05 15:34Orion E. PoplawskiNote Added: 0012262
2008-06-05 16:10Orion E. PoplawskiNote Added: 0012265
2008-06-06 09:14Bill HoffmanStatusassigned => closed
2008-06-06 09:14Bill HoffmanNote Added: 0012269
2008-06-06 09:14Bill HoffmanResolutionreopened => fixed
2008-06-06 09:14Bill HoffmanNote Added: 0012270

Notes
(0010763)
Bill Hoffman   
2008-03-10 17:56   
Can you give some more information here? Perhaps a test CMakeLists.txt file that has this problem? We use ctest 2.4.8 for many dashboards at Kitware, and it is working fine.
(0010764)
Orion E. Poplawski   
2008-03-10 18:22   
Well, I get it with cmake itself. After building it, if I run "ctest -D Nightly" I get:

$ ctest -V -D Nightly
   Site: cynosure
   Build name: Linux-g++
 Add coverage exclude regular expressions.
 Add coverage exclude: XCode
 Add coverage exclude: Kdevelop
Determine Nightly Start Time
   Specified time: 21:00:00 EDT
Create new tag: 20080309-2359 - Nightly
Start processing tests
Updating the repository
   Updating the repository: /export/home/orion/fedora/cmake/devel/cmake-2.4.8
   Use CVS repository type
Determine Nightly Start Time
   Specified time: 21:00:00 EDT
* Update repository:
cvs update: in directory .:
cvs [update aborted]: there is no version here; do 'cvs checkout' first
   Gathering version information (each . represents one updated file):
   Project is up-to-date
   Update with command: "/usr/bin/cvs" -z3 update -d -A -P -D "2008-03-09 23:59:59 UTC" failed
....

This is in DartConfiguration.tcl:

# Dashboard start time
NightlyStartTime: 21:00:00 EDT
(0010787)
Bill Hoffman   
2008-03-13 11:04   
This directory needs to be a CVS co of cmake:

/export/home/orion/fedora/cmake/devel/cmake-2.4.8
(0010792)
Orion E. Poplawski   
2008-03-13 14:01   
No, I don't that that is it. I'm working on the following bug reported in Fedora:

https://bugzilla.redhat.com/show_bug.cgi?id=436358 [^]

If you look at the following attachment to that bug:

https://bugzilla.redhat.com/attachment.cgi?id=297951&action=view [^]

you'll see that he is working in a svn repository checkout, but still getting the wrong tag.

I've also retried with a CVS checkout of cmake:

$ ctest -V -D Nightly
   Site: cynosure
   Build name: Linux-g++
 Add coverage exclude regular expressions.
 Add coverage exclude: XCode
 Add coverage exclude: Kdevelop
Determine Nightly Start Time
   Specified time: 21:00:00 EDT
Create new tag: 20080312-2359 - Nightly
Start processing tests
Updating the repository
   Updating the repository: /export/home/orion/fedora/cmake/devel/cvs/CMake.test
   Use CVS repository type
Determine Nightly Start Time
   Specified time: 21:00:00 EDT
* Update repository:
? Bootstrap.cmk
? CMakeCPackOptions.cmake
? CMakeCache.txt
? CMakeFiles
? CPackConfig.cmake
....
(0012262)
Orion E. Poplawski   
2008-06-05 15:34   
This appears to be fixed in 2.6.0. Any chance of a backport to 2.4.X, or is that branch dead?
(0012265)
Orion E. Poplawski   
2008-06-05 16:10   
This seems to be the fix:

--- cmake-2.4.8/Source/cmCTest.cxx 2008-01-21 11:59:52.000000000 -0700
+++ cmake-2.6.0/Source/cmCTest.cxx 2008-05-05 12:25:54.000000000 -0600
@@ -76,7 +71,7 @@
   //is the time at which the nightly dashboard was opened or
   //will be opened on the date of the current client machine.
   //As such, this time may be in the past or in the future.
- time_t ntime = curl_getdate(str.c_str(), &tctime);
+ time_t ntime = curl_getdate(buf, &tctime);
   cmCTestLog(this, DEBUG, " Get curl time: " << ntime << std::endl);
   tctime = time(0);
   cmCTestLog(this, DEBUG, " Get the current time: " << tctime << std::endl);
(0012269)
Bill Hoffman   
2008-06-06 09:14   
2.4.X is pretty much dead at this point. There will be no 2.4.9. Odd that the issue only seems to affect you... We (Kitware) use 2.4.X for lots of dashboards and have no problem.
(0012270)
Bill Hoffman   
2008-06-06 09:14   
2.4.X is pretty much dead at this point. There will be no 2.4.9. Odd that the issue only seems to affect you... We (Kitware) use 2.4.X for lots of dashboards and have no problem. Does the binary from Kitware work?