MantisBT - CDash
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0006582CDashpublic2008-03-10 16:562008-04-22 12:57
ReporterBill Lorensen 
Assigned ToJulien Jomier 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version1.0 
Summary0006582: CVS Link to a version 1.1 file is invalid
DescriptionClicking on a viewUpdate link for a file whose revision is 1.1 produces an invalid page. The same link for Dart Classic works fine.
Steps To Reproducefor CDash

http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Data/Baseline/Registration/ImageRegistration8RegisteredSlice.png?view=diff&root=Insight&revision=1.1 [^]

produce the response:

An Exception Has Occurred
Python Traceback

Traceback (most recent call last):
  File "/usr/lib/viewvc/viewvc.py", line 3628, in main
    request.run_viewvc()
  File "/usr/lib/viewvc/viewvc.py", line 387, in run_viewvc
    self.view_func(self)
  File "/usr/lib/viewvc/viewvc.py", line 2664, in view_diff
    p1, p2, rev1, rev2, sym1, sym2 = setup_diff(request)
  File "/usr/lib/viewvc/viewvc.py", line 2578, in setup_diff
    rev1 = r1 = query_dict['r1']
KeyError: 'r1'

For Dart Classic, everything is fine.

http://www.itk.org/cgi-bin/viewcvs.cgi/Testing/Data/Baseline/Registration/ImageRegistration8RegisteredSlice.png?root=Insight&view=markup&content-type=text%2Fx-cvsweb-markup&revision=1.1 [^]



Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-03-10 16:56Bill LorensenNew Issue
2008-03-26 17:51Julien JomierNote Added: 0010923
2008-04-22 11:48François BertelNote Added: 0011479
2008-04-22 12:56Julien JomierStatusnew => assigned
2008-04-22 12:56Julien JomierAssigned To => Julien Jomier
2008-04-22 12:57Julien JomierStatusassigned => closed
2008-04-22 12:57Julien JomierNote Added: 0011482
2008-04-22 12:57Julien JomierResolutionopen => fixed
2008-04-22 12:57Julien JomierFixed in Version => 1.0

Notes
(0010923)
Julien Jomier   
2008-03-26 17:51   
Bill, could you send me an example, I cannot reproduce the error...
(0011479)
François Bertel   
2008-04-22 11:48   
Here is an example from the VTK continuous dashboard of Monday April 21 2008:

Old dashboard:

http://www.vtk.org/Testing/Sites/dash19.kitware/Win32-bcc32/20080421-1733-Continuous/Update.html [^]

Link for TestManyActors.cxx Rev: 1.1 is
http://public.kitware.com/cgi-bin/viewcvs.cgi/Rendering/Testing/Cxx/TestManyActors.cxx?cvsroot=VTK&rev=1.1&content-type=text/x-cvsweb-markup [^]

This one works.


But the equivalent from cdash does not:

http://www.cdash.org/CDash/viewUpdate.php?buildid=59038 [^]

Link for TestManyActors.cxx Revision: 1.1 by jeff is

http://public.kitware.com/cgi-bin/viewcvs.cgi/Rendering/Testing/Cxx/TestManyActors.cxx.diff?cvsroot=VTK&rev=1.1&view=markup [^]

It leads to the following error:

http://public.kitware.com/cgi-bin/viewcvs.cgi/Rendering/Testing/Cxx/TestManyActors.cxx?view=diff&revision=1.1 [^]

An Exception Has Occurred
Python Traceback

Traceback (most recent call last):
  File "/usr/lib/viewvc/viewvc.py", line 3628, in main
    request.run_viewvc()
  File "/usr/lib/viewvc/viewvc.py", line 387, in run_viewvc
    self.view_func(self)
  File "/usr/lib/viewvc/viewvc.py", line 2664, in view_diff
    p1, p2, rev1, rev2, sym1, sym2 = setup_diff(request)
  File "/usr/lib/viewvc/viewvc.py", line 2578, in setup_diff
    rev1 = r1 = query_dict['r1']
KeyError: 'r1'
(0011482)
Julien Jomier   
2008-04-22 12:57   
Fixed in 1.0 and in the 0.8 branch. Thanks for the report.