MantisBT - ITK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0006073ITKpublic2007-11-21 13:462007-11-21 19:30
ReporterLuis Ibanez 
Assigned ToLuis Ibanez 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Resolution Date
Sprint
Sprint Status
Summary0006073: Filters related to Orientation were inconsistent
DescriptionFlip, PermuteAxes, Orient ImageFilter need reviews on how to manage the origin and directions.
Steps To Reproduce
Additional InformationBUG: FlipImageFilter - Managing directions and the sign of the origin needs to be done differently for FlipAboutOrigin and not.
BUG: FlipImageFilter - Use TransformIndexToPhysicalPoint() to account for orientations effect on the new origin
BUG: PermuteAxesImageFilter - should not permute the origin. the new image needs to occupy the same space as the old image. Only spacing, direction, and regions should permute.
BUG: OrientImageFilter - Flip filter used in the mini-pipeline needed to have FlipAboutOrigin = false. Was done in the GenerateOutputInformation() method but also needed in the GenerateData() method.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2007-11-21 13:46Luis IbanezNew Issue
2007-11-21 13:48Luis IbanezAssigned To => Luis Ibanez
2007-11-21 13:48Luis IbanezStatusnew => assigned
2007-11-21 13:53Luis IbanezNote Added: 0009726
2007-11-21 14:49Luis IbanezNote Added: 0009727
2007-11-21 19:30Luis IbanezStatusassigned => closed
2007-11-21 19:30Luis IbanezNote Added: 0009729
2007-11-21 19:30Luis IbanezResolutionopen => fixed

Notes
(0009726)
Luis Ibanez   
2007-11-21 13:53   
Jim committed fixes for these filters to the main repository.

The filters however seem to be under-tested, since the problems were not making any test fail.
(0009727)
Luis Ibanez   
2007-11-21 14:49   
The fixes have been ported to the ITK 3.4 branch:

http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkPermuteAxesImageFilter.txx?r1=1.14&root=Insight&sortby=date&r2=1.14.6.1&only_with_tag=ITK-3-4 [^]
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkFlipImageFilter.txx?r1=1.15&root=Insight&sortby=date&r2=1.15.6.1&only_with_tag=ITK-3-4 [^]
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkOrientImageFilter.txx?r1=1.15&root=Insight&sortby=date&r2=1.15.2.1&only_with_tag=ITK-3-4 [^]
(0009729)
Luis Ibanez   
2007-11-21 19:30   
An experimental submission of ITK 3.4 was green