MantisBT - ITK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005476ITKpublic2007-08-10 09:112007-08-15 14:11
ReporterLuis Ibanez 
Assigned ToLuis Ibanez 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Resolution Date
Sprint
Sprint Status
Summary0005476: RegularStepGradientDescentBaseOptimizer runs forever if NumberOfIterations is set to 0
DescriptionThe logic for stopping at NumberOfIterations if flawed for the case when NumberOfIterations is equal to 0
Steps To Reproduce
Additional InformationReported on the ITK users list by Emma Ryan
http://public.kitware.com/pipermail/insight-users/2007-August/023259.html [^]
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2007-08-10 09:11Luis IbanezNew Issue
2007-08-10 09:11Luis IbanezStatusnew => assigned
2007-08-10 09:11Luis IbanezAssigned To => Luis Ibanez
2007-08-10 09:12Luis IbanezNote Added: 0008406
2007-08-10 09:12Luis IbanezStatusassigned => acknowledged
2007-08-14 13:16Luis IbanezNote Added: 0008454
2007-08-15 14:11Luis IbanezStatusacknowledged => closed
2007-08-15 14:11Luis IbanezNote Added: 0008470
2007-08-15 14:11Luis IbanezResolutionopen => fixed

Notes
(0008406)
Luis Ibanez   
2007-08-10 09:12   
After looking at the source code, the logic flaw was confirmed.
The changes, however, are easy to make.
(0008454)
Luis Ibanez   
2007-08-14 13:16   
A fix has been committed to the CVS repository:

In the class itself:
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Numerics/itkRegularStepGradientDescentBaseOptimizer.cxx?root=Insight&sortby=date&r2=1.23&r1=1.22 [^]
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Numerics/itkRegularStepGradientDescentBaseOptimizer.h?root=Insight&sortby=date&r2=1.22&r1=1.21 [^]

In the test:
http://www.itk.org/cgi-bin/viewcvs.cgi/Testing/Code/Numerics/itkRegularStepGradientDescentOptimizerTest.cxx?r2=1.22&root=Insight&sortby=date&sortdir=down&r1=1.21 [^]
(0008470)
Luis Ibanez   
2007-08-15 14:11   
The Dashboard looks good the day after the changes.