MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005099CMakeCMakepublic2007-05-29 12:032009-03-23 15:03
ReporterStephane Rouleau 
Assigned ToBill Hoffman 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0005099: Preprocessor defintions are not properly quoted in vcproj 7 and up
DescriptionIf you add a -D define entry that contains an equal sign, CMake will output it like this:

"DEFINE=value"

The extra quotes should not be present, provided everything is alphannumerical.

cmLocalVisualStudio7GeneratorOptions::OutpuPreprocessorDefinitions should take have '=' in its list of valid characters. It should also ignore the \" which were just quoted...
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-10-09 13:08Bill HoffmanNote Added: 0013797
2008-10-09 13:12Stephane RouleauNote Added: 0013800
2009-03-23 15:03Brad KingNote Added: 0015767
2009-03-23 15:03Brad KingStatusassigned => closed
2009-03-23 15:03Brad KingResolutionopen => fixed

Notes
(0007726)
Stephane Rouleau   
2007-05-29 12:15   
Actually, if I add something like this:

DEFINE="value"

and DEFINE is alphanumerical, then it should end up, in the vcproj file:

DEFINE="value"

and not

"DEFINE="value""
(0007731)
Stephane Rouleau   
2007-05-29 15:00   
Another update -- 'j' and 'J' should be added to the list of alphanumerical values. This one confused me for a little while :)
(0013797)
Bill Hoffman   
2008-10-09 13:08   
Is this still an issue?
(0013800)
Stephane Rouleau   
2008-10-09 13:12   
I wish I knew; I had this while I was doing a consulting job last year, and since then I've moved on to other projects.
(0015767)
Brad King   
2009-03-23 15:03   
CMake 2.6 implements this correctly and has a test.