MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003841CMakeCMakepublic2006-10-04 14:052016-06-10 14:30
ReporterBrad King 
Assigned ToBrad King 
PrioritylowSeverityfeatureReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0003841: Xcode does not display custom command comments
DescriptionAt 05:08 PM 9/29/2006, you wrote:
> >Bill Hoffman wrote:
>> >> So, it was GetComment on custom command. You made it return null, and
>> >> before it returned an empty string, or was never null. This caused some
>> >> odd things to happen with the generated file stream.
>> >>
>> >> generatedfilestream foo(out);
>> >> ....
>> >> foo << s;
>> >>
>> >> This will cause no file to be created and no error message.
>> >>
>> >> So, I added an if around the GetComment().
> >
> >Actually the Xcode generator shouldn't be calling this directly anymore.
> >It should use ConstructComment:
> >
> > makefileStream << "\n#" << "Custom command rule: ";
> > std::string comment
> > = this->CurrentLocalGenerator->ConstructComment(cc);
> > if(!comment.empty())
> > {
> > makefileStream << comment;
> > }
> > makefileStream << "\n";
> >
> >This is why I didn't need to change the other generators when I made the
> >comment change, so I didn't think to look at the Xcode generator.
> >
> >However it appears from that code that the comment is just put in the
> >makefile and has no echo line. Somehow the user should be able to see
> >the comment in the build output. Can this be done?

I don't think the user sees this stuff, but I am not sure.
I will have a look on Monday.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-10-09 12:37Bill HoffmanAssigned ToBill Hoffman => Brad King
2012-08-13 10:36Brad KingStatusassigned => backlog
2012-08-13 10:36Brad KingNote Added: 0030498
2016-06-10 14:27Kitware RobotNote Added: 0041323
2016-06-10 14:27Kitware RobotStatusbacklog => resolved
2016-06-10 14:27Kitware RobotResolutionopen => moved
2016-06-10 14:30Kitware RobotStatusresolved => closed

Notes
(0030498)
Brad King   
2012-08-13 10:36   
Sending issues I'm not actively working on to the backlog to await someone with time for them.

If an issue you care about is sent to the backlog when you feel it should have been addressed in a different manner, please bring it up on the CMake mailing list for discussion. Sign up for the mailing list here, if you're not already on it:

 http://www.cmake.org/mailman/listinfo/cmake [^]

It's easy to re-activate a bug here if you can find a CMake developer or contributor who has the bandwidth to take it on.
(0041323)
Kitware Robot   
2016-06-10 14:27   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.