MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002249CMakeModulespublic2005-09-18 04:222011-04-04 12:00
ReporterEric Wing 
Assigned ToEric Wing 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in VersionCMake-2-6 
Summary0002249: FindSDL_net.cmake: Enhancements for detection
DescriptionFirst, I added more search paths to catch other packaging systems and variations I forgot last time around (DarwinPorts, Blastwave).

Second, I made some painful fixes to the OS X framework detection system because I overlooked the cases where the framework does not lie in the default search paths. Since CMake does not currently handle frameworks as it does other libraries, this needed to be handled directly in the module itself.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? FindSDL_net.cmake (2,894) 1969-12-31 19:00
https://public.kitware.com/Bug/file/384/FindSDL_net.cmake
? diff_old_to_new (40,309) 1969-12-31 19:00
https://public.kitware.com/Bug/file/387/diff_old_to_new
? diffs (57,538) 1969-12-31 19:00
https://public.kitware.com/Bug/file/396/diffs
Issue History
Date ModifiedUsernameFieldChange
2008-09-11 12:58Bill HoffmanAssigned ToBill Hoffman => Eric Wing
2010-12-16 09:31David ColeNote Added: 0024206
2010-12-16 09:31David ColeStatusassigned => resolved
2010-12-16 09:31David ColeFixed in Version => CMake-2-6
2010-12-16 09:31David ColeResolutionopen => fixed
2011-04-04 12:00David ColeNote Added: 0026066
2011-04-04 12:00David ColeStatusresolved => closed

Notes
(0003047)
Bill Hoffman   
2005-09-23 15:13   
Can you just send me all these FindSDL* files in one patch file?
(0003069)
Eric Wing   
2005-09-29 21:16   
I really suck with diff/patch. I'm not sure if this is what you really want. Keep in mind that unless somebody else made changes to the scripts that I didn't know about, then you should be able to just replace the existing ones with all the ones I submitted. But attached is an attempt at a diff.
(0003200)
Eric Wing   
2005-10-27 18:23   
Hi, it's been a month. I was just wondering if there was any progress on this item.
Thanks
(0003201)
Bill Hoffman   
2005-10-28 17:47   
The best thing to to would be for you to checkout CMake from CVS, then put your changes in. The do a
cvs diff -u > diffs.

The key is to use diff -u and not just diff.
I did get it to work, can you cvs update and make sure things are good, if you hurry I can put them in 2.2.2, coming out on Monday.

Let me know if it looks good.
(0003202)
Eric Wing   
2005-10-29 05:58   
Okay, I just uploaded the new diff. It also includes some last minute adjustments for OpenAL 1.1 from Creative Labs which just came out. I hope I got this in soon enough to make the 2.2.2 release.

Would you also be able to slip in some FindOpenSceneGraph modules I've been working on? I will file a new bug entry with attachment in a minute.
(0024206)
David Cole   
2010-12-16 09:31   
Resolving as "fixed" per "speculative" email from Eric Wing... :-)

If it needs more work, feel free to re-open it and explain what remains to be done in a new note.

Thanks!
(0026066)
David Cole   
2011-04-04 12:00   
Closing resolved issues that have not been updated in more than 3 months.