MantisBT - ITK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000221ITKpublic2003-10-02 23:332007-09-19 18:37
ReporterLydia Ng 
Assigned ToLuis Ibanez 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Resolution Date
Sprint
Sprint Status
Summary0000221: Allow basic image processing filter to take any input type
Descriptionbug transferred from GNATS (0000230)
---------------------------
Look at a means to allow the basic image processing filters, e.g., Laplacian to work correctly for different input pixel types.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0005752closed Luis Ibanez ValueType trait is incorrectly defined in Vector, RGB and Tensor Traits 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2007-09-18 09:35Luis IbanezAssigned ToJosh Cates => Luis Ibanez
2007-09-18 09:39Luis IbanezNote Added: 0009048
2007-09-18 09:41Luis IbanezNote Added: 0009049
2007-09-18 09:42Luis IbanezNote Added: 0009050
2007-09-18 09:45Luis IbanezNote Edited: 0009050
2007-09-19 14:27Luis IbanezNote Added: 0009157
2007-09-19 15:20Luis IbanezRelationship addedrelated to 0005752
2007-09-19 15:22Luis IbanezNote Added: 0009159
2007-09-19 18:36Luis IbanezNote Added: 0009170
2007-09-19 18:37Luis IbanezStatusassigned => closed
2007-09-19 18:37Luis IbanezNote Added: 0009171
2007-09-19 18:37Luis IbanezResolutionopen => fixed

Notes
(0000497)
Lydia Ng   
2004-01-16 16:23   
Josh to investigate adding concept checking to these filters.
(0001940)
Lydia Ng   
2005-01-14 14:08   
triaged - reduced priority.
(0009048)
Luis Ibanez   
2007-09-18 09:39   
Brainstorming:

We propose to use the deprecation mechanism combined with a concept checking.

The concept checking will produce a compilation error when the filter is instantiated on an image of pixel type != float.

The "undeprecation" mechanism will disable the concept checking so that old code that is instantiating this filter with float images will still compile.
(0009049)
Luis Ibanez   
2007-09-18 09:41   
Decision:

Add concept checking RealPixel Type.
(0009050)
Luis Ibanez   
2007-09-18 09:42   
(edited on: 2007-09-18 09:45)
BTW: This also matters for all the filters that use the PDE solver
So this should be done with the FiniteDifferenceImageFilter too.
(0009157)
Luis Ibanez   
2007-09-19 14:27   
ConceptCheck for real pixel type was committed for the LaplacianImageFilter:
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkLaplacianImageFilter.h?root=Insight&sortby=date&r2=1.13&r1=1.12 [^]
(0009159)
Luis Ibanez   
2007-09-19 15:22   
The FiniteDifferenceImageFilter is base class of some filters that
take scalar images as input,
as well as filters that
take vector images as input.

In order to define the concept check in a generic way, we must do it in terms
of the type

       ImageType::PixelType::ValueType
(0009170)
Luis Ibanez   
2007-09-19 18:36   
Concept checking was added to the FiniteDifferenceImageFilter:
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Common/itkFiniteDifferenceImageFilter.h?root=Insight&sortby=date&r2=1.34&r1=1.33 [^]
(0009171)
Luis Ibanez   
2007-09-19 18:37   
The concept checks were added.