Notes |
|
(0040745)
|
Brad King
|
2016-03-22 11:06
|
|
|
|
(0040747)
|
Eyal Rozenberg
|
2016-03-22 11:21
|
|
Brad, glancing at the patch, this will most probably work for me since I don't use MSVC, but - will it really work users who do? Are you sure you've not just narrowed the problem? |
|
|
(0040748)
|
Brad King
|
2016-03-22 11:29
|
|
Re 0016027:0040747: What happened between CMake 3.4 and 3.5 is there was a bug report complaining that certain source/build tree names could not be used because the generated custom commands would not quote their names correctly. To fix this the VERBATIM option was added to our add_custom_command call. When that was done the explicit quoting on the line in question here should have been removed because the VERBATIM option will take care of it. Then it turned out that the special $(VCInstallDir) syntax could not be used in combination with VERBATIM so we added a special case to not use VERBATIM if that value appears. The patch I linked in 0016027:0040745 accounts for both possibilities. |
|
|
(0040751)
|
Brad King
|
2016-03-22 13:37
|
|
|
|
(0040757)
|
Brad King
|
2016-03-23 14:47
|
|
The fix in 0016027:0040745 has been queued for merge to 'release' for inclusion in CMake 3.5.1.
|
|
|
(0040758)
|
Eyal Rozenberg
|
2016-03-23 15:12
|
|
Ok by me. I'm afraid I won't have time to devote to helping you with testing, though. I can promise to complain if you break something and it makes it to my distro... |
|
|
(0041213)
|
Kitware Robot
|
2016-06-10 14:21
|
|
This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
|