MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015809CMakeCMakepublic2015-10-26 11:542016-03-07 09:12
ReporterNuno 
Assigned ToBrad King 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 3.3.2 
Target VersionCMake 3.4Fixed in VersionCMake 3.4 
Summary0015809: Add support for Intel Fortran 2016
DescriptionIn my setup I have installed VS 2010 through VS 2015 (except VS2012) and for some reason when using the VS 2015 command line and the NMake generator the value of MSVC_VERSION comes as 1800 instead of 1900.

Also I have Intel Fortran 2013 and 2016 installed.

I have traced this issue to the file "Modules/Platform/windows-MSVC.cmake" around line 62 where the variable MSVC_VERSION is set.
The IF() statements fail except the Fortran one. And on that one CMAKE_Fortran_SIMULATE_VERSION has a value of 18.0 and then this value is used.

It seems that this comes from Modules/CMakeFortranCompilerId.F.in.
I suggest that the Modules/CMakeFortranCompilerId.F.in gets updated. There is an if statement where it checks for _MSC_VER >= 1800. The check for _MSC_VER >= 1900 should be added here for Visual Studio 2015 full support.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-26 11:54NunoNew Issue
2015-10-26 13:01Brad KingSeveritymajor => feature
2015-10-26 13:01Brad KingSummaryMSVC_VERSION is wrong => Add support for Intel Fortran 2016
2015-10-26 13:03Brad KingNote Added: 0039680
2015-10-29 13:42Brad KingNote Added: 0039704
2015-10-29 13:42Brad KingAssigned To => Brad King
2015-10-29 13:42Brad KingStatusnew => resolved
2015-10-29 13:42Brad KingResolutionopen => fixed
2015-10-29 13:42Brad KingFixed in Version => CMake 3.4
2015-10-29 13:42Brad KingTarget Version => CMake 3.4
2016-03-07 09:12Robert MaynardNote Added: 0040633
2016-03-07 09:12Robert MaynardStatusresolved => closed

Notes
(0039680)
Brad King   
2015-10-26 13:03   
This should fix it:

 Intel: Recognize MSVC version for Intel Fortran 2016
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=77be366c [^]

Please test that change locally and report back.
(0039704)
Brad King   
2015-10-29 13:42   
I installed Intel Fortran 2016 and confirmed that the fix works. I've merged it to the 'release' branch for inclusion in CMake 3.4.0-rc3.
(0040633)
Robert Maynard   
2016-03-07 09:12   
Closing resolved issues that have not been updated in more than 4 months.