MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015784CMakeCPackpublic2015-10-12 10:322016-03-07 09:12
ReporterRonny Krüger 
Assigned ToNils Gladitz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 3.3.2 
Target VersionFixed in VersionCMake 3.5 
Summary0015784: The WiX patch file parser ignores text nodes.
DescriptionThe following xml fragment is supposed to run the "test" action after the installer has finished but only if the product is not installed.

<nowiki><code xml>
  <CPackWiXPatch>
    <CPackWiXFragment Id="#PRODUCT">
      <CustomAction Id = "test" ... />
      <InstallExecuteSequence>
        <Custom Action="test" Before="InstallFinalize">NOT INSTALLED</Custom>
      </InstallExecuteSequence>
    </CPackWiXFragment>
  </CPackWiXPatch>
</nowiki>

Unfortunately this xml does not get completely through to WiX because the patch parser ignores the text node below the "Custom" node which contains the conditions on which the action is to be run.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-12 10:32Ronny KrügerNew Issue
2015-10-12 10:37Brad KingAssigned To => Nils Gladitz
2015-10-12 10:37Brad KingStatusnew => assigned
2015-10-12 16:04Nils GladitzNote Added: 0039581
2015-10-13 10:06Ronny KrügerNote Added: 0039590
2015-10-13 10:29Nils GladitzNote Added: 0039591
2015-10-15 04:15Nils GladitzNote Added: 0039606
2015-10-15 04:15Nils GladitzStatusassigned => resolved
2015-10-15 04:15Nils GladitzFixed in Version => CMake 3.5
2015-10-15 04:15Nils GladitzResolutionopen => fixed
2016-03-07 09:12Robert MaynardNote Added: 0040617
2016-03-07 09:12Robert MaynardStatusresolved => closed

Notes
(0039581)
Nils Gladitz   
2015-10-12 16:04   
Thank you for the report.

I created a new "wix-text-node" topic to fix the issue:

https://cmake.org/gitweb?p=stage/cmake.git;a=commit;h=5a266095ee778fb700c067c55ff0b59777a72c50 [^]

If you can please give it a try and see if it fixes the issue for you as well.

This test case works for me:

https://github.com/ngladitz/cmake-wix-testsuite/tree/master/custom_action_with_condition [^]
(0039590)
Ronny Krüger   
2015-10-13 10:06   
I have tested your change with my script and it works now as it should. Thanks for the quick fix.
(0039591)
Nils Gladitz   
2015-10-13 10:29   
Thank you for testing. I merged it to the "next" branch.
(0039606)
Nils Gladitz   
2015-10-15 04:15   
This is now in master: https://cmake.org/gitweb?p=cmake.git;a=commit;h=5a266095 [^]
(0040617)
Robert Maynard   
2016-03-07 09:12   
Closing resolved issues that have not been updated in more than 4 months.