MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015531CMakeModulespublic2015-04-24 05:122015-11-02 09:13
ReporterBjoern Thiel 
Assigned To 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSWindowsOS Version
Product Version 
Target VersionCMake 3.3Fixed in VersionCMake 3.3 
Summary0015531: InstallRequiredSystemLibraries misses MBCS MFC libraries
Descriptionif("${v}" LESS 12 OR EXISTS "${MSVC${v}_MFC_DIR}/mfc${v}0d.dll")
may be false for version >= 12 as ${MSVC${v}_MFC_DIR} is not always set correctly at that time.
Steps To Reproduce
Additional InformationI patched it replacing the
if(mbcs)
with
if("${v}" LESS 12 OR EXISTS "${MSVC${v}_MFC_DIR}/mfc${v}0d.dll")
and
if("${v}" LESS 12 OR EXISTS "${MSVC${v}_MFC_DIR}/mfc${v}0.dll")
and erasing the set(mbcs ... stuff.
TagsNo tags attached.
Relationships
related to 0014903closed Brad King InstallRequiredSystemLibraries CMAKE_INSTALL_MFC_LIBRARIES does not work with MSVC 2013 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-24 05:12Bjoern ThielNew Issue
2015-04-27 10:01Brad KingRelationship addedrelated to 0014903
2015-04-27 10:01Brad KingNote Added: 0038613
2015-04-27 10:13Brad KingNote Added: 0038614
2015-04-27 10:13Brad KingSeveritycrash => major
2015-04-27 10:13Brad KingStatusnew => resolved
2015-04-27 10:13Brad KingResolutionopen => fixed
2015-04-27 10:13Brad KingFixed in Version => CMake 3.3
2015-04-27 10:13Brad KingTarget Version => CMake 3.3
2015-11-02 09:13Robert MaynardNote Added: 0039790
2015-11-02 09:13Robert MaynardStatusresolved => closed

Notes
(0038613)
Brad King   
2015-04-27 10:01   
Related change made in CMake 3.0:

 InstallRequiredSystemLibraries: MBCS MFC is optional on VS 12
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c0a6646d [^]
(0038614)
Brad King   
2015-04-27 10:13   
Change applied, thanks:

 InstallRequiredSystemLibraries: Fix MBCS MFC detection
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ff183986 [^]
(0039790)
Robert Maynard   
2015-11-02 09:13   
Closing resolved issues that have not been updated in more than 4 months.